Your message dated Sat, 07 May 2005 11:02:06 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#307901: fixed in phpmyadmin 4:2.6.2-3
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 6 May 2005 09:08:30 +0000
>From [EMAIL PROTECTED] Fri May 06 02:08:30 2005
Return-path: <[EMAIL PROTECTED]>
Received: from dsl093-039-086.pdx1.dsl.speakeasy.net (localhost.localdomain)
[66.93.39.86]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DTyow-0001x8-00; Fri, 06 May 2005 02:08:30 -0700
Received: by localhost.localdomain (Postfix, from userid 1000)
id D8387172843; Fri, 6 May 2005 02:08:28 -0700 (PDT)
Date: Fri, 6 May 2005 02:08:28 -0700
From: Steve Langasek <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: phpmyadmin: fix for 307275 introduces potential for further config
breakage
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="c3bfwLpm8qysLVxt"
Content-Disposition: inline
X-Debbugs-Cc: debian-release@lists.debian.org
User-Agent: Mutt/1.5.6+20040907i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-11.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
X_DEBBUGS_CC autolearn=ham version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
--c3bfwLpm8qysLVxt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: phpmyadmin
Version: 4:2.6.2-2
Severity: important
The latest version of phpmyadmin uses the following code to undo a
release-critical bug of editing another package's conffile:
@@ -146,6 +146,15 @@
ucf --purge /etc/phpmyadmin/apache.conf
rm -f /etc/phpmyadmin/apache.conf.md5sum
fi
+ # Trying to fix the mess. Sorry :( See #307275.
+ if [ "$1" =3D "upgrade" -a -n "$2" ] && \
+ dpkg --compare-versions "$2" lt-nl "4:2.6.2-2"; then
+ if grep -qs "^# Include /etc/apache2/conf\.d/\[^\.#\]\*$" /etc/apache=
2/apache2.conf; then
+ cp -f /etc/apache2/apache2.conf /etc/apache2/apache2.conf.old.php=
myadmin
+ grep -v "^Include /etc/apache2/conf\.d/\*\.conf" /etc/apache2/apa=
che2.conf.old.phpmyadmin | \
+ sed "s%^# \(Include /etc/apache2/conf\.d/\[^\.#\]\*\)$%\1%" > /et=
c/apache2/apache2.conf
+ fi
+ fi
.
for webserver in apache apache-perl apache-ssl apache2; do
if [ -f /etc/$webserver/conf.d/phpmyadmin.conf ]; then
There are two problems with this code block:
- The only version of phpmyadmin that contained this bug, according to the
changelog, was 4:2.6.2-1. Therefore, the code should check for *exactly*
that version, instead of making further, possibly inappropriate changes to
apache2's conffile.
- This code does not preserve permissions on apache2.conf, and introduces
the possibility of breaking the config file if the grep/sed pipeline is
interrupted mid-write.
A more robust solution would be:
if [ "$1" =3D "upgrade" -a "$2" =3D "4:2.6.2-1" ]; then
if grep -qs "^# Include /etc/apache2/conf\.d/\[^\.#\]\*$" /etc/apache2=
/apache2.conf; then
grep -v "^Include /etc/apache2/conf\.d/\*\.conf" /etc/apache2/apac=
he2.conf | \
sed "s%^# \(Include /etc/apache2/conf\.d/\[^\.#\]\*\)$%\1%" > /etc=
/apache2/apache2.conf.old.phpmyadmin=20
chmod --reference=3D/etc/apache2/apache2.conf /etc/apache2/apache2=
=2Econf.old.phpmyadmin
chown --reference=3D/etc/apache2/apache2.conf /etc/apache2/apache2=
=2Econf.old.phpmyadmin
mv /etc/apache2/apache2.conf.old.phpmyadmin /etc/apache2/apache2.c=
onf
fi
fi
Please address this problem so that 2.6.2-2 can be considered for sarge.
In addition, the changelog mentions:
* Doesn't load the PHP extensions automatically in config.inc.php script.
=2E.. which sounds like a regression to me...
Thanks,
--=20
Steve Langasek
postmodern programmer
--c3bfwLpm8qysLVxt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFCezQHKN6ufymYLloRAiI+AKCFlOlXEFdDGCO1uUj5eCVox91MlwCgxz/T
XJtWyD6FN5grjkR7jiV/rU8=
=KhVL
-----END PGP SIGNATURE-----
--c3bfwLpm8qysLVxt--
---------------------------------------
Received: (at 307901-close) by bugs.debian.org; 7 May 2005 15:17:51 +0000
>From [EMAIL PROTECTED] Sat May 07 08:17:51 2005
Return-path: <[EMAIL PROTECTED]>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DUR3u-0007So-00; Sat, 07 May 2005 08:17:50 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DUQog-00025e-00; Sat, 07 May 2005 11:02:06 -0400
From: Piotr Roszatycki <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.55 $
Subject: Bug#307901: fixed in phpmyadmin 4:2.6.2-3
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sat, 07 May 2005 11:02:06 -0400
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Source: phpmyadmin
Source-Version: 4:2.6.2-3
We believe that the bug you reported is fixed in the latest version of
phpmyadmin, which is due to be installed in the Debian FTP archive:
phpmyadmin_2.6.2-3.diff.gz
to pool/main/p/phpmyadmin/phpmyadmin_2.6.2-3.diff.gz
phpmyadmin_2.6.2-3.dsc
to pool/main/p/phpmyadmin/phpmyadmin_2.6.2-3.dsc
phpmyadmin_2.6.2-3_all.deb
to pool/main/p/phpmyadmin/phpmyadmin_2.6.2-3_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Piotr Roszatycki <[EMAIL PROTECTED]> (supplier of updated phpmyadmin package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 7 May 2005 14:49:49 +0200
Source: phpmyadmin
Binary: phpmyadmin
Architecture: source all
Version: 4:2.6.2-3
Distribution: unstable
Urgency: high
Maintainer: Piotr Roszatycki <[EMAIL PROTECTED]>
Changed-By: Piotr Roszatycki <[EMAIL PROTECTED]>
Description:
phpmyadmin - set of PHP-scripts to administrate MySQL over the WWW
Closes: 307901
Changes:
phpmyadmin (4:2.6.2-3) unstable; urgency=high
.
* Fix apache2.conf only for 4:2.6.2-1 release. Closes: #307901 (critical),
#307275 (critical), #304786 (critical).
* Clean up old 'Include /etc/phpmyadmin/apache.conf' from httpd.conf in safe
way.
* Removed old code which modified httpd.conf if 'Include /etc/apache/conf.d'
was missing.
* Note for release manager: cleaning up config.inc.php doesn't change the
application logic. The autoloading of the PHP extensions is already
implemented in the upstream's code.
Files:
c83db93421cebdcc89fb4c50550d5a69 592 web extra phpmyadmin_2.6.2-3.dsc
7de04feefd0776d3afc3e9ad3d71d89e 27954 web extra phpmyadmin_2.6.2-3.diff.gz
20d611062eec50a684d29c846e58426f 2787564 web extra phpmyadmin_2.6.2-3_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCfNcMhMHHe8CxClsRAmKDAKCrvZswLRH0ypRnwkCy9k4Qci5vGwCgv+b4
qyvMuY16bsYw33/RoTKgpGo=
=zxWM
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
