Bug#775474: marked as done (Issue helpful error if user specified keyring not found)
Your message dated Sat, 07 Apr 2018 15:21:07 + with message-idand subject line Bug#754318: fixed in debootstrap 1.0.96 has caused the Debian Bug report #754318, regarding Issue helpful error if user specified keyring not found to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 754318: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=754318 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: debootstrap Tags: patch Patch attached to cause a helpful error to be issued to the user in the event that they should specify a keyring file via the --keyring parameter, but should the specified keyring file not be found (for example should the user have made a typo). From a reading of the code I believe that no such check already exists, and current behavior is to just blunder on, resulting in a SIGCHECK gpgv state, and thus an unhelpful "Error executing gpgv to check Release signature" message, combined possibly with some degree of wasted time and bandwidth through files being redownloaded after correcting the mistake (if the existing copies aren't reused, I haven't yet read enough of the code carefully to know at this point, nor have I run the code - been too busy to have time). commit b066af054dad924641bd0cfa4dfd669a9db28bc5 Author: jnqnfe Date: Fri Jan 16 05:24:50 2015 + Issue error if user specified keyring file not found diff --git a/debootstrap b/debootstrap index e024560..e1a3fbf 100755 --- a/debootstrap +++ b/debootstrap @@ -321,6 +321,9 @@ if [ $# != 0 ] ; then else error 1 NEEDARG "option requires an argument %s" "$1" fi + if [ ! -e "$KEYRING" ]; then + error 1 KEYRING "specified keyring file not found" + fi ;; --no-check-gpg) shift 1 --- End Message --- --- Begin Message --- Source: debootstrap Source-Version: 1.0.96 We believe that the bug you reported is fixed in the latest version of debootstrap, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 754...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Hideki Yamane (supplier of updated debootstrap package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Fri, 06 Apr 2018 10:02:20 +0900 Source: debootstrap Binary: debootstrap debootstrap-udeb Architecture: source all Version: 1.0.96 Distribution: unstable Urgency: medium Maintainer: Debian Install System Team Changed-By: Hideki Yamane Description: debootstrap - Bootstrap a basic Debian system debootstrap-udeb - Bootstrap the Debian system (udeb) Closes: 563647 586158 732628 734324 754318 762431 775444 775474 798564 806780 833525 Changes: debootstrap (1.0.96) unstable; urgency=medium . * Escape spaces to fix debootstrap on path contains space fails Thanks to Tianon Gravi for the based patch (Closes: #586158, #762431) * Add warning if file specified via --keyring does not exist Thanks to jnqnfe for the patch (Closes: #754318, #775474) * Avoid unnecessary keyring warning with --second-stage option (Closes: #734324) * Output warning if falling back to sha1 (Closes: #775444) Thanks to jnqnfe for the patch. * Prevent unintended removal with --print-debs option (Closes: #833525) Thanks to Johannes Schauer for the patch * Add scripts for Kali Linux (Closes: #798564) * Improve manpage description for --{unpack,make}-tarball options (Closes: #563647) . * debian/control - Add "Suggests: squid-deb-proxy-client" * debian/rules - Add Kali for ${keyring} pattern . [ Sjoerd Simons ] * Fix multiple components usage for --foreign/--second-stage (Closes: #806780) . [ Michael Vogt ] * Try to auto-detect proxy if available (e.g. squid-deb-proxy-client) (Closes: #732628) Checksums-Sha1: e283396a67afae3737229a54c142b2f26f6793b6 1991
Bug#775474: marked as done (Issue helpful error if user specified keyring not found)
Your message dated Sat, 07 Apr 2018 15:21:07 + with message-idand subject line Bug#775474: fixed in debootstrap 1.0.96 has caused the Debian Bug report #775474, regarding Issue helpful error if user specified keyring not found to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 775474: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775474 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems --- Begin Message --- Package: debootstrap Tags: patch Patch attached to cause a helpful error to be issued to the user in the event that they should specify a keyring file via the --keyring parameter, but should the specified keyring file not be found (for example should the user have made a typo). From a reading of the code I believe that no such check already exists, and current behavior is to just blunder on, resulting in a SIGCHECK gpgv state, and thus an unhelpful "Error executing gpgv to check Release signature" message, combined possibly with some degree of wasted time and bandwidth through files being redownloaded after correcting the mistake (if the existing copies aren't reused, I haven't yet read enough of the code carefully to know at this point, nor have I run the code - been too busy to have time). commit b066af054dad924641bd0cfa4dfd669a9db28bc5 Author: jnqnfe Date: Fri Jan 16 05:24:50 2015 + Issue error if user specified keyring file not found diff --git a/debootstrap b/debootstrap index e024560..e1a3fbf 100755 --- a/debootstrap +++ b/debootstrap @@ -321,6 +321,9 @@ if [ $# != 0 ] ; then else error 1 NEEDARG "option requires an argument %s" "$1" fi + if [ ! -e "$KEYRING" ]; then + error 1 KEYRING "specified keyring file not found" + fi ;; --no-check-gpg) shift 1 --- End Message --- --- Begin Message --- Source: debootstrap Source-Version: 1.0.96 We believe that the bug you reported is fixed in the latest version of debootstrap, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 775...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Hideki Yamane (supplier of updated debootstrap package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Format: 1.8 Date: Fri, 06 Apr 2018 10:02:20 +0900 Source: debootstrap Binary: debootstrap debootstrap-udeb Architecture: source all Version: 1.0.96 Distribution: unstable Urgency: medium Maintainer: Debian Install System Team Changed-By: Hideki Yamane Description: debootstrap - Bootstrap a basic Debian system debootstrap-udeb - Bootstrap the Debian system (udeb) Closes: 563647 586158 732628 734324 754318 762431 775444 775474 798564 806780 833525 Changes: debootstrap (1.0.96) unstable; urgency=medium . * Escape spaces to fix debootstrap on path contains space fails Thanks to Tianon Gravi for the based patch (Closes: #586158, #762431) * Add warning if file specified via --keyring does not exist Thanks to jnqnfe for the patch (Closes: #754318, #775474) * Avoid unnecessary keyring warning with --second-stage option (Closes: #734324) * Output warning if falling back to sha1 (Closes: #775444) Thanks to jnqnfe for the patch. * Prevent unintended removal with --print-debs option (Closes: #833525) Thanks to Johannes Schauer for the patch * Add scripts for Kali Linux (Closes: #798564) * Improve manpage description for --{unpack,make}-tarball options (Closes: #563647) . * debian/control - Add "Suggests: squid-deb-proxy-client" * debian/rules - Add Kali for ${keyring} pattern . [ Sjoerd Simons ] * Fix multiple components usage for --foreign/--second-stage (Closes: #806780) . [ Michael Vogt ] * Try to auto-detect proxy if available (e.g. squid-deb-proxy-client) (Closes: #732628) Checksums-Sha1: e283396a67afae3737229a54c142b2f26f6793b6 1991