Your message dated Sat, 01 Oct 2016 22:27:53 +0000
with message-id <e1bqsl7-0002yk...@franck.debian.org>
and subject line Bug#829000: fixed in fracplanet 0.4.0-5
has caused the Debian Bug report #829000,
regarding fracplanet: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
829000: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829000
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: fracplanet
Version: 0.4.0-3
Severity: wishlist
Tags: patch upstream
User: reproducible-bui...@lists.alioth.debian.org
Usertags: locale
X-Debbugs-Cc: reproducible-bui...@lists.alioth.debian.org

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that fracplanet could not be built reproducibly.
It lists source and header files without considering the locale, which
causes e.g. a non-deterministic linking order.

The attached patch fixes this.

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
diff --git a/debian/patches/reproducible-build.patch b/debian/patches/reproducible-build.patch
new file mode 100644
index 0000000..8e33fdb
--- /dev/null
+++ b/debian/patches/reproducible-build.patch
@@ -0,0 +1,18 @@
+Author: Reiner Herrmann <rei...@reiner-h.de>
+Description: Use C locale for sorting source and header files
+ Under different locales the order is different, which causes different
+ linking orders.
+
+--- a/fracplanet.pro
++++ b/fracplanet.pro
+@@ -6,8 +6,8 @@
+ 
+ PRECOMPILED_HEADER = precompiled.h
+ 
+-HEADERS += $$system(ls *.h)
+-SOURCES += $$system(ls *.cpp)
++HEADERS += $$system(LC_ALL=C ls *.h)
++SOURCES += $$system(LC_ALL=C ls *.cpp)
+ LIBS += -lboost_program_options -lGLU
+ 
+ DEFINES += QT_DLL
diff --git a/debian/patches/series b/debian/patches/series
index 21e94e7..a9045c0 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
 qt4.8_headers.patch
+reproducible-build.patch

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: fracplanet
Source-Version: 0.4.0-5

We believe that the bug you reported is fixed in the latest version of
fracplanet, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 829...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Chris Lamb <la...@debian.org> (supplier of updated fracplanet package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 01 Oct 2016 23:04:52 +0100
Source: fracplanet
Binary: fracplanet
Architecture: source amd64
Version: 0.4.0-5
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packa...@qa.debian.org>
Changed-By: Chris Lamb <la...@debian.org>
Description:
 fracplanet - Fractal planet generator
Closes: 829000
Changes:
 fracplanet (0.4.0-5) unstable; urgency=medium
 .
   * QA upload.
   * Make the build reproducible. Thanks to Reiner Herrmann <rei...@reiner-h.de>
     for the patch. (Closes: #829000)
Checksums-Sha1:
 30de6ac16d824db40e25dce77139012ba8d96879 1802 fracplanet_0.4.0-5.dsc
 c1b18a24ed8fccb35ba5a14aca9ccf92193eb2b4 101700 fracplanet_0.4.0.orig.tar.gz
 1b15c6175fb2a6e67a759e5c809e81aa0423d95c 4160 fracplanet_0.4.0-5.debian.tar.xz
 6627d5ab0fb3db90dc62682c14bb2267aa9d84d8 2282780 
fracplanet-dbgsym_0.4.0-5_amd64.deb
 e84aa03a14904b1b8e479feaca3dce80c85a1c0b 122234 fracplanet_0.4.0-5_amd64.deb
Checksums-Sha256:
 992e65210422f531cb2039409fc62e7f8d8080f6d517e95f93eac839a14450d6 1802 
fracplanet_0.4.0-5.dsc
 38d56aba3c5cf19d4f2c218bece471d3860b161d2210a24ba94550356723482a 101700 
fracplanet_0.4.0.orig.tar.gz
 16ff8ed5510750197f5c29b90a519a98070ca96ebb82036013afb72d7b0d677f 4160 
fracplanet_0.4.0-5.debian.tar.xz
 84a2a5b79cce6a215cac8cc9906666f763ab7f2a1db85c63cd10d8350e007656 2282780 
fracplanet-dbgsym_0.4.0-5_amd64.deb
 e0d3dce2690e6ddfa0db0c51fd80800cf9a317cb8bbdf73c7ef740900f909729 122234 
fracplanet_0.4.0-5_amd64.deb
Files:
 3f4dcdf6f561ae7756e0d369a3417066 1802 graphics optional fracplanet_0.4.0-5.dsc
 270a0712c62adf58461cd5e7f7474aa0 101700 graphics optional 
fracplanet_0.4.0.orig.tar.gz
 460c3bb38f79b123df0ebddace0c3322 4160 graphics optional 
fracplanet_0.4.0-5.debian.tar.xz
 e325f302e5ac929b16b8452dc0d93686 2282780 debug extra 
fracplanet-dbgsym_0.4.0-5_amd64.deb
 606d7c48aaa73b51e6a688e5b962975d 122234 graphics optional 
fracplanet_0.4.0-5_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJX8DT4AAoJEB6VPifUMR5YQhsP/0QWOz/T/MjMuQDoGRZGjzwq
j+mzJjRm0qi8ibe9Rac3MgK+0Ymu25mZaO9nBDOUpCfEZgYFgk68X4WL6Gq1jYB3
e7nnRG7jWafxsld6LdU64FPDMkLOQaf1qXt37sacakA98saR9EXSDQ0XAlZQgsdH
IEbzvDdYqkXl8C0S5SfTrmGRXzYIcR/thHIsRKERYdfwky6MAX6O2EE4yoWDz9GK
D/Nn6P6YMEC3/x5g7qtYoflim3UsLPuSS1vAS3w64BMI+6huBqMCyJwmjKdVhRjk
bPAmYxJMRozrH+X4sfu1aQvNc+59Peec+XT3ungviQ4Dd4QzV5sgR2Y/IN1caNJ2
pgX/UnZmWhDEbfzzeqhy6YTMq+UOMZr5SoojVgO9yDl/EuAxksofA6lUNR7I3bTV
uml4xwnmIcO8/eV8INH6phiDhYXhAaGq1fi+A7lGXENm6bF0A7+8ZPCPMGcCpTqM
LS2lYQwe0xgBmoYNzMK6hMSEL4Imb1TPu8qd1KtKIyXeshj/u9GbNlvzaduVRf3J
YWCqa5QuGlGz92zHhpUKH6uuEIRjPTgdblCwlmpM7cI2tA2wik0WcVzd2Tt670eX
JZEPxp8KcUboEeJk1Qcv4inh26X/4Oghae1L+E0QtS+AIvtQc16b7sarCO0ccyik
IhruEygRCirzW0VGWFLY
=1jSw
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to