Your message dated Wed, 20 Sep 2017 17:34:47 +0000
with message-id <e1duitb-000frr...@fasolo.debian.org>
and subject line Bug#874078: fixed in lintian 2.5.53
has caused the Debian Bug report #874078,
regarding lintian: improve binary-file-built-without-LFS-support info field
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
874078: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=874078
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Version: 2.5.52
Severity: normal
Tags: patch lfs
Dear Maintainers,
CONTEXT:
Mpgrafic-0.3.15-1 is flagged with the binary-file-built-without-LFS-support
lintian
flag despite my attempts to follow the lintian recommendations, after having
searched for LFS info in obvious places:
https://lintian.debian.org/full/debian-astro-maintain...@lists.alioth.debian.org.html#mpgrafic
Discussion at this other lintian bug looks like it will solve the mpgrafic
LFS bug:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=871956
PROBLEM:
Version 2.5.52 of the binary-file-built-without-LFS-support section of
binaries.desc has two problems that make applying LFS support
corrections difficult for someone (such as me) who is not yet familiar
with LFS, AC_SYS_LARGEFILES and their portability:
(i) It says in one sentence that we must "ensure _FILE_OFFSET_BITS is
defined and set to 64", but in the following sentence that
"this can be done by using the AC_SYS_LARGEFILE macro with autoconf".
However, AC_SYS_LARGEFILE does not seem to define _FILE_OFFSET_BITS
on amd64, since it does not seem to be needed.
In other words, these two sentences are contradictory. Either lintian
should request everyone to hardwire everything with _FILE_OFFSET_BITS and
recommend *not* using AC_SYS_LARGEFILE, or it needs to indicate that
_FILE_OFFSET_BITS is not needed on all systems and that AC_SYS_LARGEFILE
can decide on which systems _FILE_OFFSET_BITS is needed.
(ii) I have not been able to find good documentation to give more
hints on functions that may need to be modified, or even better, on
functions that only need to be modified for some architectures
(pwrite, pread in the case of mpgrafic). So a brief comment in the
lintian info field could help improve the probability of people
responding to the warning rather than ignoring it.
I'm setting this as a normal level bug, because the aim of lintian
is not only to warn package maintainers, but also to help them
fix problems.
PATCH:
My proposed updated second paragraph is here:
To support large files, code review might be needed to make sure that
those files are not slurped into memory or mmap(2)ed, and that correct
64-bit data types are used (ex: off_t instead of ssize_t), etc. Once
that has been done ensure, if needed, that <tt>_FILE_OFFSET_BITS</tt>
is defined and
set to 64 before the relevant files are included. This can be done
conditionally by
using the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf, or by appending
the output of <tt>getconf LFS_CFLAGS</tt> and <tt>getconf LFS_LDFLAGS</tt>
to <tt>CFLAGS</tt> and <tt>LDFLAGS</tt> respectively. Functions such
as pwrite and pread should be replaced by pwrite64 and pread64 in
cases where <tt>_FILE_OFFSET_BITS</tt> is defined and set to 64.
I'm also attaching it as a patch file.
Cheers
Boud
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
--- checks/binaries.desc.orig 2017-06-17 17:38:57.000000000 +0200
+++ checks/binaries.desc 2017-09-02 21:57:08.929153000 +0200
@@ -439,11 +439,15 @@
To support large files, code review might be needed to make sure that
those files are not slurped into memory or mmap(2)ed, and that correct
64-bit data types are used (ex: off_t instead of ssize_t), etc. Once
- that has been done ensure <tt>_FILE_OFFSET_BITS</tt> is defined and
- set to 64 before the relevant files are included. This can be done by
+ that has been done ensure, if needed, that <tt>_FILE_OFFSET_BITS</tt>
+ is defined and
+ set to 64 before the relevant files are included. This can be done
+ conditionally by
using the <tt>AC_SYS_LARGEFILE</tt> macro with autoconf, or by appending
the output of <tt>getconf LFS_CFLAGS</tt> and <tt>getconf LFS_LDFLAGS</tt>
- to <tt>CFLAGS</tt> and <tt>LDFLAGS</tt> respectively.
+ to <tt>CFLAGS</tt> and <tt>LDFLAGS</tt> respectively. Functions such
+ as pwrite and pread should be replaced by pwrite64 and pread64 in
+ cases where <tt>_FILE_OFFSET_BITS</tt> is defined and set to 64.
.
Take into account that even if this tag is not emitted, that does not
mean the binary is LFS-safe (ie. no OOM conditions, file truncation
--- End Message ---
--- Begin Message ---
Source: lintian
Source-Version: 2.5.53
We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 874...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Chris Lamb <la...@debian.org> (supplier of updated lintian package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 20 Sep 2017 09:25:06 +0100
Source: lintian
Binary: lintian
Architecture: source all
Version: 2.5.53
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-ma...@debian.org>
Changed-By: Chris Lamb <la...@debian.org>
Description:
lintian - Debian package checker
Closes: 681713 762956 779675 814599 835120 847144 849622 857123 865531 868897
869541 869587 869750 869788 870069 870199 870272 870649 870681 870722 870730
870758 870822 871575 871767 871957 872042 872076 872611 872843 873096 873211
873323 873434 873458 873701 873702 874078 874121 874381 875509 875985 876003
Changes:
lintian (2.5.53) unstable; urgency=medium
.
The "we are all Perl developers now" release.
.
* Summary of tag changes:
+ Added:
- alternatively-build-depends-on-python-sphinx-and-python3-sphinx
- build-depends-on-python-sphinx-only
- dependency-on-python-version-marked-for-end-of-life
- maintainer-script-interpreter
- missing-call-to-dpkg-maintscript-helper
- node-package-install-in-nodejs-rootdir
- override-file-in-wrong-package
- package-installs-java-bytecode
- python-foo-but-no-python3-foo
- script-needs-depends-on-sensible-utils
- script-uses-deprecated-nodejs-location
- transitional-package-should-be-oldlibs-optional
- unnecessary-testsuite-autopkgtest-header
- vcs-browser-links-to-empty-view
+ Removed:
- debug-package-should-be-priority-extra
- missing-classpath
- transitional-package-should-be-oldlibs-extra
.
* checks/apache2.pm:
+ [CL] Fix an apache2-unparsable-dependency false positive by allowing
periods (".") in dependency names. (Closes: #873701)
* checks/binaries.pm:
+ [CL] Apply patches from Guillem Jover & Boud Roukema to improve the
description of the binary-file-built-without-LFS-support tag.
(Closes: #874078)
* checks/changes.{pm,desc}:
+ [CL] Ignore DFSG-repacked packages when checking for upstream
source tarball signatures as they will never match by definition.
(Closes: #871957)
+ [CL] Downgrade severity of orig-tarball-missing-upstream-signature
from "E:" to "W:" as many common tools do not make including the
signatures easy enough right now. (Closes: #870722, #870069)
+ [CL] Expand the explanation of the
orig-tarball-missing-upstream-signature tag to include the location
of where dpkg-source will look. Thanks to Theodore Ts'o for the
suggestion.
* checks/copyright-file.pm:
+ [CL] Address a number of issues in copyright-year-in-future:
- Prevent false positives in port numbers, email addresses, ISO
standard numbers and matching specific and general street
addresses. (Closes: #869788)
- Match all violating years in a line, not just the first (eg.
"2000-2107").
- Ignore meta copyright statements such as "Original Author". Thanks
to Thorsten Alteholz for the bug report. (Closes: #873323)
- Expand testsuite.
* checks/cruft.{pm,desc}:
+ [CL] Downgrade severity of file-contains-fixme-placeholder
tag from "important" (ie. "E:") to "wishlist" (ie. "I:").
Thanks to Gregor Herrmann for the suggestion.
+ [CL] Apply patch from Alex Muntada (alexm) to use "substr" instead
of "substring" in mentions-deprecated-usr-lib-perl5-directory's
description. (Closes: #871767)
+ [CL] Don't check copyright_hints file for FIXME placeholders.
(Closes: #872843)
+ [CL] Don't match quoted "FIXME" variants as they are almost always
deliberate. Thanks to Adrian Bunk for the report. (Closes: #870199)
+ [CL] Avoid false positives in missing source checks for "CSS Browser
Selector". (Closes: #874381)
* checks/debhelper.pm:
+ [CL] Prevent a false positive of
missing-build-dependency-for-dh_-command that can be exposed by
following the advice for the recently added
useless-autoreconf-build-depends tag. (Closes: #869541)
* checks/debian-readme.{pm,desc}:
+ [CL] Ensure readme-debian-contains-debmake-template also checks
for templates "Automatically generated by debmake".
* checks/description.{desc,pm}:
+ [CL] Clarify explanation of description-starts-with-leading-spaces
tag. Thanks to Taylor Kline <taylor.kl...@utexas.edu> for the report
and patch. (Closes: #849622)
+ [NT] Skip capitalization-error-in-description-synopsis for
auto-generated packages (such as dbgsym packages).
* checks/fields.{desc,pm}:
+ [CL] Ensure that python3-foo packages have "Section: python", not
just python2-foo. (Closes: #870272)
+ [RG] Do no longer require debug packages to be priority extra.
+ [BR] Use Lintian::Data for name/section mapping
+ [CL] Check for packages including "?rev=0&sc=0" in Vcs-Browser.
(Closes: #681713)
+ [NT] Transitional packages should now be "oldlibs/optional" rather
than "oldlibs/extra". The related tag has been renamed accordingly.
* checks/filename-length.pm:
+ [NT] Skip the check on auto-generated binary packages (such as
dbgsym packages).
* checks/files.{pm,desc}:
+ [BR] Avoid privacy-breach-generic false positives for legal.xml.
+ [BR] Detect install of node package under /usr/lib/nodejs/[^/]*$
+ [CL] Check for packages shipping compiled Java class files. Thanks
Carnë Draug <carandraug+...@gmail.com>. (Closes: #873211)
+ [BR] Privacy breach is no longer experimental.
* checks/init.d.desc:
+ [RG] Do not recommend a versioned dependency on lsb-base in
init.d-script-needs-depends-on-lsb-base. (Closes: #847144)
* checks/java.pm:
+ [CL] Additionally consider .cljc files as code to avoid false-
positive codeless-jar warnings. (Closes: #870649)
+ [CL] Drop problematic missing-classpath check. (Closes: #857123)
* checks/menu-format.desc:
+ [CL] Prevent false positives in desktop-entry-lacks-keywords-entry
for "Link" and "Directory" .desktop files. (Closes: #873702)
* checks/python.{pm,desc}:
+ [CL] Split out Python checks from "scripts" check to a new, source
check of type "source".
+ [CL] Check for python-foo without corresponding python3-foo packages
to assist in Python 2.x deprecation. (Closes: #870681)
+ [CL] Check for packages that Build-Depend on python-sphinx only.
(Closes: #870730)
+ [CL] Check for packages that alternatively Build-Depend on the
Python 2 and Python 3 versions of Sphinx. (Closes: #870758)
+ [CL] Check for binary packages that depend on Python 2.x.
(Closes: #870822)
* checks/scripts.pm:
+ [CL] Correct false positives in
unconditional-use-of-dpkg-statoverride by detecting "if !" as a
valid shell prefix. (Closes: #869587)
+ [CL] Check for missing calls to dpkg-maintscript-helper(1) in
maintainer scripts. (Closes: #872042)
+ [CL] Check for packages using sensible-utils without declaring a
dependency after its split from debianutils. (Closes: #872611)
+ [CL] Warn about scripts using "nodejs" as an interpreter now that
nodejs provides /usr/bin/node. (Closes: #873096)
+ [BR] Add a statistic tag giving interpreter.
* checks/testsuite.{desc,pm}:
+ [CL] Remove recommendations to add a "Testsuite: autopkgtest" field
to debian/control as it is added when needed by dpkg-source(1)
since dpkg 1.17.1. (Closes: #865531)
+ [CL] Warn if we see an unnecessary "Testsuite: autopkgtest" header
in debian/control.
+ [NT] Recognise "autopkgtest-pkg-go" as a valid test suite.
+ [CL] Recognise "autopkgtest-pkg-elpa" as a valid test suite.
(Closes: #873458)
+ [CL] Recognise "autopkgtest-pkg-octave" as a valid test suite.
(Closes: #875985)
+ [CL] Update the description of unknown-testsuite to reflect that
"autopkgtest" is not the only valid value; the referenced URL
is out-of-date (filed as #876008). (Closes: #876003)
.
* data/binaries/embedded-libs:
+ [RG] Detect embedded copies of heimdal, libgxps, libquicktime,
libsass, libytnef, and taglib.
+ [RG] Use an additional string to detect embedded copies of
openjpeg2. (Closes: #762956)
* data/fields/name_section_mappings:
+ [BR] node- package section is javascript.
+ [CL] Apply patch from Guillem Jover to add more section mappings.
(Closes: #874121)
* data/fields/obsolete-packages:
+ [MR] Add dh-systemd. (Closes: #872076)
* data/fields/perl-provides:
+ [CL] Refresh perl provides.
* data/fields/virtual-packages:
+ [CL] Update data file from archive. This fixes a false positive for
"bacula-director". (Closes: #835120)
* data/files/obsolete-paths:
+ [CL] Add note to /etc/bash_completion.d entry regarding stricter
filename requirements. (Closes: #814599)
* data/files/privacy-breaker-websites:
+ [BR] Detect custom donation logos like apache.
+ [BR] Detect generic counter website.
* data/standards-version/release-dates:
+ [CL] Add 4.0.1 and 4.1.0 as known standards versions.
(Closes: #875509)
.
* debian/control:
+ [CL] Mention Debian Policy v4.1.0 in the description.
+ [CL] Add myself to Uploaders.
+ [CL] Drop unnecessary "Testsuite: autopkgtest"; this is implied from
debian/tests/control existing.
.
* commands/info.pm:
+ [CL] Add a --list-tags option to print all tags Lintian knows about.
Thanks to Rajendra Gokhale for the suggestion. (Closes: #779675)
* commands/lintian.pm:
+ [CL] Apply patch from Maia Everett to avoid British spelling when
using en_US locale. (Closes: #868897)
.
* lib/Lintian/Check.pm:
+ [CL] Stop emitting {maintainer,uploader}-address-causes-mail-loops
for @packages.debian.org addresses. (Closes: #871575)
* lib/Lintian/Collect/Binary.pm:
+ [NT] Introduce an "auto-generated" argument for "is_pkg_class".
* lib/Lintian/Data.pm:
+ [CL] Modify Lintian::Data's "all" to always return keys in insertion
order, dropping dependency on libtie-ixhash-perl.
.
* helpers/coll/objdump-info-helper:
+ [CL] Apply patch from Steve Langasek to accommodate binutils 2.29
outputting symbols in a different format on ppc64el.
(Closes: #869750)
.
* t/tests/fields-perl-provides/tags:
+ [CL] Update expected output to match new Perl provides.
* t/tests/files-privacybreach/*:
+ [CL] Add explicit test for packages including external fonts via
the Google Font API. Thanks to Ian Jackson for the report.
(Closes: #873434)
+ [CL] Add explicit test for packages including external fonts via
the Typekit API via <script/> HTML tags.
* t/tests/*/desc:
+ [CL] Add missing entries in "Test-For" fields to make
development/testing workflow less error-prone.
.
* private/generate-tag-summary:
+ [CL] git-describe(1) will usually emit 7 hexadecimal digits as the
abbreviated object name, However, as this can be user-dependent,
pass --abbrev=0 to ensure it does not vary between systems. This
also means we do not need to strip it ourselves.
* private/refresh-*:
+ [CL] Use deb.debian.org as the default mirror.
+ [CL] Update locations of Contents-<arch> files; they are now
namespaced by distribution (eg. "main").
Checksums-Sha1:
def6e964fa04e65f2b58976bd9841b33bcaffc93 2898 lintian_2.5.53.dsc
28ebcfc7d996bc4fd5d1f45e9dae8243345233d8 1237668 lintian_2.5.53.tar.xz
59ef475fbac642c7330ee3cef8c642edb3d15022 1064748 lintian_2.5.53_all.deb
867e0c05a4836845a9912124a885c51c8a05ef6b 16171 lintian_2.5.53_amd64.buildinfo
Checksums-Sha256:
b54180857da9bc15ea045c8be23aafafaee4cdf30636c02381424c486f9b3f81 2898
lintian_2.5.53.dsc
13b998d82f7cac886b42f009135783e35636e3b6c78e1de0397b3bd20f1e8748 1237668
lintian_2.5.53.tar.xz
f1c180316e612ccd7dc839b381f9b70d0cf51140dd61d1665a6aa3c9579d83e7 1064748
lintian_2.5.53_all.deb
7d5f9f503773b0648f25a3cb8b529f95f56a948ca8abdbf01e6bd29bec1f63e2 16171
lintian_2.5.53_amd64.buildinfo
Files:
a1a14db9a9a55bfa4daab892a85caa9f 2898 devel optional lintian_2.5.53.dsc
2890d2d1a7cc14eba7c192cc8dc0ca7d 1237668 devel optional lintian_2.5.53.tar.xz
e70233c86bbcc0d7696a4a3578e78c08 1064748 devel optional lintian_2.5.53_all.deb
c743028517160bfe0b79bfb34d4086e7 16171 devel optional
lintian_2.5.53_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAlnCo5wACgkQHpU+J9Qx
HlgtNg//Qy9ZQ6o3qRXNw/vh7IQk8qSCjikQ5hh5jpYl+ma/OW4fdxByv2HTtx8X
g9475xmQ1p2b2nELoQHraNCzR18C6q5JzBZp6yqMkRF0sjWau6kvilga6PnOxfMm
iPMqE2sk3EmSaGzo6DFYv5flaQVGLBBa32Jjx+gqY4gUgd1qzDRz7XlEqgbz6TC+
gm4K2B20C4LgX2DgIVdYRZ6qNCxS/K4SniOvF5aNzRsfAUzQfqILlh8UDd1OUNLX
rjOCm3dvw1IwJm/qZKWqeo9GCnpzJh8ijzmvCCkdAnLzTjR0UfaRgahOnLB+eYnp
j7xdqvtKi4H3oe5iBFepJcUJYQ6T9Fz0W0ynyNOQL9bY08kkMJa12BBO9hQ5pIQp
WL0LGy5SnYpdREJDHU7Jq5LJIkGVxrsYF4lYk/o1pc++eOdERjhOImo7yWOIGvgr
ymqLpoDAyPjgPllQNc4K6r6yoJfIXmA5ykogMGB5LNjBdiFOH2ZIBfd886QhrpwJ
nlLcv0gYnviScAPSVp1ctExJJadSG3EW+lPRZrgdIqqGjXRjdJC+zSebznuG+PZ6
pOOjV4/M1zMWMGatc057SJ9/ITKVa4vB+zuMVSSCC83c29gpSkVnqR++hVMeltiC
urDGbABHETRTJ+U1gcIAVumKVJm0jGjMBujWSskuvkhMNDAHeLE=
=j7VS
-----END PGP SIGNATURE-----
--- End Message ---
