Your message dated Fri, 23 Feb 2018 16:35:31 +0000
with message-id <e1epgjn-000gha...@fasolo.debian.org>
and subject line Bug#891196: fixed in perl 5.26.1-5
has caused the Debian Bug report #891196,
regarding perl: memory leak in S_concat_pat()
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
891196: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891196
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: perl
Version: 5.26.1-4
Severity: important
Tags: patch fixed-upstream
Forwarded: https://rt.perl.org/Public/Bug/Display.html?id=132892

As reported by 郭樂聰 in the upstream bug, this leaks memory:

% perl -e 'my %h=(qr/a/ => 1); while (1) { /$_/ for keys %h}'

This regressed in 5.25.5 with

 
https://perl5.git.perl.org/perl.git/commit/b10cb25a6c86fd96fff8f2dfa6d8df3e6b51a451

and was fixed recently in blead by

 
https://perl5.git.perl.org/perl.git/commit/910a6a8be166fb3780dcd2520e3526e537383ef2

which I'm attaching as well.
-- 
Niko Tyni   nt...@debian.org
>From 910a6a8be166fb3780dcd2520e3526e537383ef2 Mon Sep 17 00:00:00 2001
From: Yves Orton <demer...@gmail.com>
Date: Fri, 23 Feb 2018 04:13:49 +0100
Subject: [PATCH] perl #132892: avoid leak by mortalizing temporary copy of
 pattern

---
 regcomp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/regcomp.c b/regcomp.c
index 34ac9169f2..446f0bf839 100644
--- a/regcomp.c
+++ b/regcomp.c
@@ -6515,8 +6515,8 @@ S_concat_pat(pTHX_ RExC_state_t * const pRExC_state,
                     pat = msv;
                 } else {
                     /* a string with no trailing null, we need to copy it
-                     * so it we have a trailing null */
-                    pat = newSVsv(msv);
+                     * so it has a trailing null */
+                    pat = sv_2mortal(newSVsv(msv));
                 }
             }
 
-- 
2.16.1


--- End Message ---
--- Begin Message ---
Source: perl
Source-Version: 5.26.1-5

We believe that the bug you reported is fixed in the latest version of
perl, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 891...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niko Tyni <nt...@debian.org> (supplier of updated perl package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 23 Feb 2018 17:23:43 +0200
Source: perl
Binary: perl-base perl-doc perl-debug libperl5.26 libperl-dev perl-modules-5.26 
perl
Architecture: source
Version: 5.26.1-5
Distribution: unstable
Urgency: medium
Maintainer: Niko Tyni <nt...@debian.org>
Changed-By: Niko Tyni <nt...@debian.org>
Description:
 libperl-dev - Perl library: development files
 libperl5.26 - shared Perl library
 perl       - Larry Wall's Practical Extraction and Report Language
 perl-base  - minimal Perl system
 perl-debug - debug-enabled Perl interpreter
 perl-doc   - Perl documentation
 perl-modules-5.26 - Core Perl modules
Closes: 890242 891196 891229
Changes:
 perl (5.26.1-5) unstable; urgency=medium
 .
   * Mark _LIB_VERSION as an optional symbol for glibc 2.27 compatibility.
     Patch by Aurelien Jarno. (Closes: #890242)
   * Refresh cross build support files.
   * Apply an upstream patch by Yves Orton to fix a regexp related memory
     leak, regressed in 5.26. (Closes: #891196)
   * Build-Depend on libgdbm-compat-dev to restore the NDBM_File and
     ODBM_File modules. (Closes: #891229)
Checksums-Sha1:
 5b3d3ec1d597df0b266a4e7c74c9a1879a602745 2653 perl_5.26.1-5.dsc
 c3fbe8605661664330d46ec27931e83efbc2331e 162384 perl_5.26.1-5.debian.tar.xz
 74b6ddb2e33ed4747e5e0c2dd0d7123b90b4570d 4825 perl_5.26.1-5_source.buildinfo
Checksums-Sha256:
 e15bac1fa71fb9d4a85396c40ebc2b11ed7edfec8641a5b587d55fd65c520e8a 2653 
perl_5.26.1-5.dsc
 d9809b495e6d0ad2f9f06c3ef812d95f4a0abd93faa129373f7c851f7b2cb447 162384 
perl_5.26.1-5.debian.tar.xz
 4aa8af01c3d2c79344f6bd26acca9752147b60a0eeadf3295d9f6ec39606c686 4825 
perl_5.26.1-5_source.buildinfo
Files:
 6e41711c16fc7fc9d0e4cc39c80ce0ce 2653 perl standard perl_5.26.1-5.dsc
 9d031918fa1fca30fde475be7d837306 162384 perl standard 
perl_5.26.1-5.debian.tar.xz
 3924fe0ea8d08ec8dfe541e1c7b4c7ef 4825 perl standard 
perl_5.26.1-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEdqKOQsmBHZHoj7peLsD/s7cwGx8FAlqQOwAACgkQLsD/s7cw
Gx/+ww/+IMqcDOH/hbK5qo7XnlldJ9neEEPDij9fbFl6GZXS286wO9ccTWK7uSVV
LneO5yyf/d98miVtTF0mnVgVsD8BXVjmnjjS1cbguBYQaRB8sUgLvCIq6TKVCxm8
v4dwsnu24rL1W7VffgfP7cfTCfSHE32jASHBgWon6SwlsgVKRvDwgL8Sozma01he
21FCCSIOvLWLFkmKVWOrDaxzuV/qiKHZDtobBGkvILdkq8MFNZwY/rKNg+ZMxwZK
XOXzAR9xgAMJkIj+KL744mcNckn1vB3pfdkAkADQshgMExYRIOwALQCDgWe0500Q
IlG3GX5hn7MY3RD1jSXZKxhK3g/homw5DihylkMecOpEnbf9b6uowjyXXYczZjAj
UKKASbTaDO9AqePtg/chiKW5grPpyJz9+nqiTxn5QmJEWmuQAF/EbfslPhja8hqK
WkKzoFy4F2s4jzZ+6Fn2jvttLNTHeVcOqAHL0zzsLMk66MU2a28x8W6Y0PFjHZeA
YnTalbsLO+lEcTg7ojNdTnwxd0IXTojKPcvroGw6SPlEWEOcLfVWYOodKgwrG8ii
E1P8oXJTaFJQA0NrW5MdTArSDp2Yp81ll7WNmLJAMS7R4DksRuiHfJcq/g0JIQja
PXscU4eOhi/vnMBx316oWU6RD5uUcilJ/8bXS35BnfsvjgelN8w=
=JT3K
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to