Your message dated Sat, 11 Aug 2018 21:46:37 +0200
with message-id <20180811194637.bcg4svfgvwi2q...@percival.namespace.at>
and subject line Re: #749436: multipath-tools: Conflicting declarations of
devt2devname shadow undefined behaviour
has caused the Debian Bug report #749436,
regarding multipath-tools: Conflicting declarations of devt2devname shadow
undefined behaviour
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
749436: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749436
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: multipath-tools
Version: 0.5.0-1
Usertags: goto-cc
During a rebuild of all packages in a clean sid chroot (and cowbuilder+pbuilder)
the build failed with the following error. Please note that we use our research
compiler tool-chain (using tools from the cbmc package), which permits extended
reporting on type inconsistencies at link time.
[...]
cc -shared -lpthread -ldevmapper -ldl -L../libmultipath -lmultipath
-Wl,-soname=libmpathpersist.so.0 -g -O2 -fPIE -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2
-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -Wunused -Wstrict-prototypes -fPIC
-DLIB_STRING=\"lib\" -I../libmultipath -I../libmpathpersist -o
libmpathpersist.so.0 mpath_persist.o mpath_updatepr.o mpath_pr_ioctl.o
error: conflicting function declarations "devt2devname"
old definition in module mpath_persist file mpathpr.h line 53
signed int (char *, char *)
new definition in module util file util.h line 10
signed int (char *devname, signed int devname_len, char *devt)
Makefile:22: recipe for target 'libmpathpersist.so.0' failed
make[2]: *** [libmpathpersist.so.0] Error 64
For some reason mpathpr.h runs its own declaration of devt2devname rather than
including util.h - compare the two declarations:
http://sources.debian.net/src/multipath-tools/0.5.0-1/libmpathpersist/mpathpr.h?hl=53#L53
http://sources.debian.net/src/multipath-tools/0.5.0-1/libmultipath/util.h?hl=10#L10
Thus both the number and types of arguments are wrong here, resulting in
undefined behaviour:
http://sources.debian.net/src/multipath-tools/0.5.0-1/libmpathpersist/mpath_persist.c?hl=74#L74
Best,
Michael
pgpC2u92owVQu.pgp
Description: PGP signature
--- End Message ---
--- Begin Message ---
Version: 0.5.0+git1.656f8865-1
Looking at the git history, this has been fixed in commit
98614e20996f3a5b887dd7e50f6a5f874eda6be9, a long time ago.
Thanks,
Chris
--- End Message ---
