Your message dated Sat, 12 Aug 2017 13:51:22 -0400
with message-id <1188537d-2174-c69d-804d-daec556c9...@piedmont.edu>
and subject line Re: wmmon: Increase the maximum numbers of CPUs
has caused the Debian Bug report #753119,
regarding wmmon: Increase the maximum numbers of CPUs
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
753119: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753119
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: wmmon
Version: 1.1+20131205-1
Severity: wishlist
Tags: patch

Dear Maintainer,

I have a new computer containing a hexcore, hyperthreading processor. This
results in 12 CPUs. wmmon only supports 10. Can you please increase it.
Attached is a patch that increases it to 12, but it is not tested.


-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.14-1-amd64 (SMP w/12 CPU cores)
Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages wmmon depends on:
ii  libc6     2.19-4
ii  libx11-6  2:1.6.2-2
ii  libxext6  2:1.3.2-1
ii  libxpm4   1:3.5.10-1

wmmon recommends no packages.

wmmon suggests no packages.

-- no debconf information
diff --git a/wmmon/wmmon/wmmon.c b/wmmon/wmmon/wmmon.c
index 48f1041..505032b 100644
--- a/wmmon/wmmon/wmmon.c
+++ b/wmmon/wmmon/wmmon.c
@@ -120,7 +120,7 @@
 #define WMMON_VERSION "1.2.b2"
 #define HISTORY_ENTRIES 55
 #define HISTORY_ENTRIES 55
-#define MAX_CPU (10) /* depends on graph height */
+#define MAX_CPU (12) /* depends on graph height */
 #define MAX_STAT_DEVICES (4)
 
   /********************/

--- End Message ---
--- Begin Message --- The region of the window where the CPU loads are painted is only 10 pixels tall, so that's why we have a hard cap on the number of individual CPUs which can be accounted for.

Note that wmmon *does* support any number of CPUs (well, until we start making 2,147,483,648-core processors!) by displaying the average and maximum loads if this number is greater than 10.

Even if we changed the geometry of the wmmon window to accommodate 11 or 12 CPUs, then an argument might be made to increase it to 16 or 24 or what have you. Eventually we would run out of space regardless. So a cap must be set, and I propose that the current cap of 10 is fine.

I'm closing this bug.

--- End Message ---

Reply via email to