Your message dated Sun, 16 Oct 2016 10:25:09 +0000
with message-id <e1bvicv-00007c...@franck.debian.org>
and subject line Bug#824875: fixed in grub2 2.02~beta3-1
has caused the Debian Bug report #824875,
regarding /etc/init.d/grub-common uses file from initscripts without a 
dependency
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
824875: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=824875
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: grub-common
Version: 2.02~beta2-36
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch yakkety

There is some ongoing effort to stop installing "initscripts" by
default, as it's not necessary under systemd [1].

I noticed that without initscripts, the only failed service at boot is 
/etc/init.d/grub-common:

| ● grub-common.service - LSB: Record successful boot for GRUB
|    Loaded: loaded (/etc/init.d/grub-common; bad; vendor preset: enabled)
|    Active: failed (Result: exit-code) since Fr 2016-05-20 18:17:46 CEST; 23s 
ago
|      Docs: man:systemd-sysv-generator(8)
|   Process: 761 ExecStart=/etc/init.d/grub-common start (code=exited, status=2)
| 
| Mai 20 18:17:46 donald systemd[1]: Starting LSB: Record successful boot for 
GRUB...
| Mai 20 18:17:46 donald grub-common[761]: /etc/init.d/grub-common: 17: .: 
Can't open /lib/init/vars.sh
| Mai 20 18:17:46 donald systemd[1]: grub-common.service: Control process 
exited, code=exited status=2
| Mai 20 18:17:46 donald systemd[1]: Failed to start LSB: Record successful 
boot for GRUB.
| Mai 20 18:17:46 donald systemd[1]: grub-common.service: Unit entered failed 
state.
| Mai 20 18:17:46 donald systemd[1]: grub-common.service: Failed with result 
'exit-code'.

Indeed /etc/init.d/grub-common unconditionally sources /lib/init/vars.sh
without depending on initscripts. Of course we don't actually want to add this
dependency, but robustify the init.d script to get along without vars.sh.

It only uses this to conditionalize the log_action_msg call. I think
this is unjustified -- the backend/consumer of these log messages,
(like plymouth or just console) should decide what to do with the
messages, and most other packages that I know unconditionally do the
log_* LSB calls.

I attach a patch which removes the /lib/init/vars.sh sourcing and thus
the initscripts dependency.

Thanks,

Martin


[1] 
https://bugs.debian.org/cgi-bin/pkgreport.cgi?users=pkg-systemd-maintain...@lists.alioth.debian.org;dist=unstable;tag=initscripts-dep

-- 

Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)
  * debian/grub-common.init: Don't source /lib/init/vars.sh, we don't depend
    on initscripts (and don't want to). There is no reason why we would not
    use the LSB log_action_msg in non-verbose (default) mode, most other
    packages use it unconditionally. (LP: #1584134)
diff -Nru grub2-2.02~beta2/debian/grub-common.init 
grub2-2.02~beta2/debian/grub-common.init
--- grub2-2.02~beta2/debian/grub-common.init    2016-03-15 19:08:17.000000000 
+0100
+++ grub2-2.02~beta2/debian/grub-common.init    2016-05-20 18:33:30.000000000 
+0200
@@ -13,20 +13,17 @@
 
 which grub-editenv >/dev/null 2>&1 || exit 0
 
-# Load the VERBOSE setting and other rcS variables
-. /lib/init/vars.sh
-
 # Define LSB log_* functions.
 # Depend on lsb-base (>= 3.0-6) to ensure that this file is present.
 . /lib/lsb/init-functions
 
 case $1 in
     start|restart|force-reload)
-       [ "$VERBOSE" != no ] && log_action_msg "Recording successful boot for 
GRUB"
+       log_action_msg "Recording successful boot for GRUB"
        [ -s /boot/grub/grubenv ] || rm -f /boot/grub/grubenv
        mkdir -p /boot/grub
        grub-editenv /boot/grub/grubenv unset recordfail
-       [ "$VERBOSE" != no ] && log_end_msg $?
+       log_end_msg $?
        ;;
     stop)
        ;;

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message ---
Source: grub2
Source-Version: 2.02~beta3-1

We believe that the bug you reported is fixed in the latest version of
grub2, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 824...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwat...@debian.org> (supplier of updated grub2 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 16 Oct 2016 10:46:46 +0100
Source: grub2
Binary: grub2 grub-linuxbios grub-efi grub-common grub2-common grub-emu 
grub-emu-dbg grub-pc-bin grub-pc-dbg grub-pc grub-rescue-pc grub-coreboot-bin 
grub-coreboot-dbg grub-coreboot grub-efi-ia32-bin grub-efi-ia32-dbg 
grub-efi-ia32 grub-efi-amd64-bin grub-efi-amd64-dbg grub-efi-amd64 
grub-efi-ia64-bin grub-efi-ia64-dbg grub-efi-ia64 grub-efi-arm-bin 
grub-efi-arm-dbg grub-efi-arm grub-efi-arm64-bin grub-efi-arm64-dbg 
grub-efi-arm64 grub-ieee1275-bin grub-ieee1275-dbg grub-ieee1275 
grub-firmware-qemu grub-uboot-bin grub-uboot-dbg grub-uboot grub-xen-bin 
grub-xen-dbg grub-xen grub-xen-host grub-yeeloong-bin grub-yeeloong-dbg 
grub-yeeloong grub-theme-starfield grub-mount-udeb
Architecture: source
Version: 2.02~beta3-1
Distribution: unstable
Urgency: medium
Maintainer: GRUB Maintainers <pkg-grub-de...@lists.alioth.debian.org>
Changed-By: Colin Watson <cjwat...@debian.org>
Description:
 grub-common - GRand Unified Bootloader (common files)
 grub-coreboot - GRand Unified Bootloader, version 2 (Coreboot version)
 grub-coreboot-bin - GRand Unified Bootloader, version 2 (Coreboot binaries)
 grub-coreboot-dbg - GRand Unified Bootloader, version 2 (Coreboot debug files)
 grub-efi   - GRand Unified Bootloader, version 2 (dummy package)
 grub-efi-amd64 - GRand Unified Bootloader, version 2 (EFI-AMD64 version)
 grub-efi-amd64-bin - GRand Unified Bootloader, version 2 (EFI-AMD64 binaries)
 grub-efi-amd64-dbg - GRand Unified Bootloader, version 2 (EFI-AMD64 debug 
files)
 grub-efi-arm - GRand Unified Bootloader, version 2 (ARM UEFI version)
 grub-efi-arm-bin - GRand Unified Bootloader, version 2 (ARM UEFI binaries)
 grub-efi-arm-dbg - GRand Unified Bootloader, version 2 (ARM UEFI debug files)
 grub-efi-arm64 - GRand Unified Bootloader, version 2 (ARM64 UEFI version)
 grub-efi-arm64-bin - GRand Unified Bootloader, version 2 (ARM64 UEFI binaries)
 grub-efi-arm64-dbg - GRand Unified Bootloader, version 2 (ARM64 UEFI debug 
files)
 grub-efi-ia32 - GRand Unified Bootloader, version 2 (EFI-IA32 version)
 grub-efi-ia32-bin - GRand Unified Bootloader, version 2 (EFI-IA32 binaries)
 grub-efi-ia32-dbg - GRand Unified Bootloader, version 2 (EFI-IA32 debug files)
 grub-efi-ia64 - GRand Unified Bootloader, version 2 (IA64 version)
 grub-efi-ia64-bin - GRand Unified Bootloader, version 2 (IA64 binaries)
 grub-efi-ia64-dbg - GRand Unified Bootloader, version 2 (IA64 debug files)
 grub-emu   - GRand Unified Bootloader, version 2 (emulated version)
 grub-emu-dbg - GRand Unified Bootloader, version 2 (emulated debug files)
 grub-firmware-qemu - GRUB firmware image for QEMU
 grub-ieee1275 - GRand Unified Bootloader, version 2 (Open Firmware version)
 grub-ieee1275-bin - GRand Unified Bootloader, version 2 (Open Firmware 
binaries)
 grub-ieee1275-dbg - GRand Unified Bootloader, version 2 (Open Firmware debug 
files)
 grub-linuxbios - GRand Unified Bootloader, version 2 (dummy package)
 grub-mount-udeb - export GRUB filesystems using FUSE (udeb)
 grub-pc    - GRand Unified Bootloader, version 2 (PC/BIOS version)
 grub-pc-bin - GRand Unified Bootloader, version 2 (PC/BIOS binaries)
 grub-pc-dbg - GRand Unified Bootloader, version 2 (PC/BIOS debug files)
 grub-rescue-pc - GRUB bootable rescue images, version 2 (PC/BIOS version)
 grub-theme-starfield - GRand Unified Bootloader, version 2 (starfield theme)
 grub-uboot - GRand Unified Bootloader, version 2 (ARM U-Boot version)
 grub-uboot-bin - GRand Unified Bootloader, version 2 (ARM U-Boot binaries)
 grub-uboot-dbg - GRand Unified Bootloader, version 2 (ARM U-Boot debug files)
 grub-xen   - GRand Unified Bootloader, version 2 (Xen version)
 grub-xen-bin - GRand Unified Bootloader, version 2 (Xen binaries)
 grub-xen-dbg - GRand Unified Bootloader, version 2 (Xen debug files)
 grub-xen-host - GRand Unified Bootloader, version 2 (Xen host version)
 grub-yeeloong - GRand Unified Bootloader, version 2 (Yeeloong version)
 grub-yeeloong-bin - GRand Unified Bootloader, version 2 (Yeeloong binaries)
 grub-yeeloong-dbg - GRand Unified Bootloader, version 2 (Yeeloong debug files)
 grub2      - GRand Unified Bootloader, version 2 (dummy package)
 grub2-common - GRand Unified Bootloader (common files for version 2)
Closes: 815203 817084 824875 835964 837493
Changes:
 grub2 (2.02~beta3-1) unstable; urgency=medium
 .
   [ Colin Watson ]
   * New upstream beta release.
   * syslinux_test: Fix out-of-tree build handling.
   * Drop "grub-shell: Pass -no-pad to xorriso when building floppy images".
     The floppy images built by grub-shell are no longer over the floppy
     limit, and this patch now itself causes fddboot_test failures.
   * Build with GCC 6 (closes: #835964).
   * linuxefi.patch: Adjust for libgcc removal.
   * Apply openSUSE patch to accept empty modules for now so that Xen builds
     work.
 .
   [ Debconf translations ]
   * [ja] Japanese (Takuma Yamada; closes: #815203, #817084).
 .
   [ Martin Pitt ]
   * debian/grub-common.init: Don't source /lib/init/vars.sh, we don't depend
     on initscripts (and don't want to). There is no reason why we would not
     use the LSB log_action_msg in non-verbose (default) mode, most other
     packages use it unconditionally (closes: #824875, LP: #1584134).
 .
   [ Steve Beattie ]
   * debian/rules: Disable PIE builds for GRUB modules (closes: #837493).
Checksums-Sha1:
 7c8d73d77125ed39d5dc8ed3daaaf86be3649a9c 6299 grub2_2.02~beta3-1.dsc
 14a1f9239a9c974957e835dc706fc6a1e4819c83 6030784 grub2_2.02~beta3.orig.tar.xz
 8dc892d5c4e6f32d2e8ecbb48a3e0c0149d81d30 1004876 
grub2_2.02~beta3-1.debian.tar.xz
Checksums-Sha256:
 9c1fa28e4ecc3a6d9b49516c0f1c55256ddda15e2b5e2dc8f8f3fc3351ffa0dd 6299 
grub2_2.02~beta3-1.dsc
 30ec3d555e52a702c3eef449872ef874eff28b320f40b55ffc47f70db8e5ada1 6030784 
grub2_2.02~beta3.orig.tar.xz
 0f0a8d06cb00a0c2960d7e5057a08e3240fe80b86e26034a4cc00ef05e1cc425 1004876 
grub2_2.02~beta3-1.debian.tar.xz
Files:
 c9ba811897ff3cf0c6934d5b822d1dd4 6299 admin extra grub2_2.02~beta3-1.dsc
 ab399fc6f74a97d66ff77f04b743149c 6030784 admin extra 
grub2_2.02~beta3.orig.tar.xz
 f012e542b08fa5815cc486866067dd22 1004876 admin extra 
grub2_2.02~beta3-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Comment: Colin Watson <cjwat...@debian.org> -- Debian developer

iQIcBAEBCAAGBQJYA03XAAoJEDk1h9l9hlALax4P/2eCCEnjUnIQ+AN4tgDk+EJD
SXoeTuw6ILt8WQsCkZeFu6vk4WRqFv/ULMdV4N9hmUCHCfjTnNb8MqsgSQP2pBlz
VXsiDS2benrB2zhiaYHbj1bqEJIqKmbMTqezNHmQ/e3GTIuo3HEN269zFWOf/b6n
BmfwH/ajRIlu/dUDsz7wSUJp60CC2zaxSzr2cZZRjAkJ/uCfiaeLjqaPHGTTYNZl
TZ6LCIGS8gpfI+PsHsT4wWceoZqo8qTLhC1hoawhh476FfOdwREsSgRsOyaGZ2wI
lIjyrYQbNXxqYylC8qrx1U5Si1dc0o4qSwaObwCPmand9y3Drw6ywTr8XPYP4vVQ
YbQF5SWDEOrLqaY2Re+ElTllF5ICPmPBKwlBuSS5vpv0IBYilWKgF2fSRpjn3xFG
BiOlfidctRtAatcQCuNrtuTWeil6phYs4OErffb2yyHNNV0A1nQuYk/DLW8yEITI
rBm9bkn9LnQJ9ppWN91g6EhwqtKt71OkAp2EbPmfXwYvNkuRQwgwLXy+OK5d3Ezu
++KzqrkqSrynBJmIvE1Dly0Q79vw08qtvm6NL9k9JsWbxzDELy+j84UjNMOt3ewW
X9+OMz+hFJ4VE33+y+kgzMCr+2u0+CWOyKn2Q+lrzCwt7JQTJspzFrC30zNnj+E+
RZVpC+tpZMuvrA364qmq
=DzDN
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to