Your message dated Sat, 17 Sep 2016 12:28:13 +0000 with message-id <e1blej7-0007oe...@franck.debian.org> and subject line Bug#837732: fixed in ifupdown 0.8.14 has caused the Debian Bug report #837732, regarding ifupdown: ifup & ifdown crash if multiple interfaces are listed in no-scripts to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 837732: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837732 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: ifupdown Version: 0.8.10ubuntu1 Severity: important Tags: patch Dear Maintainer, This was reported in Ubuntu as https://bugs.launchpad.net/ubuntu/+source/ifupdown/+bug/1618726 but is present in sid too. Quoting from that report: ---- This is a trivially reproducible crash in ifup/ifdown, with a patch attached. Steps to reproduce: 1) echo no-scripts foo bar >> /etc/network/interfaces 2) ifup baz Expected results: Unknown interface baz Actual results: Segmentation fault (core dumped) It's irrelevant whether the second interface is on the same no-scripts line or separate one. This will crash just the same: echo no-scripts foo >> /etc/network/interfaces echo no-scripts bar >> /etc/network/interfaces ---- I'm attaching a patch based on the one the reporting user provided. Cheers, mwh -- System Information: Debian Release: stretch/sid APT prefers xenial-updates APT policy: (500, 'xenial-updates'), (500, 'xenial-security'), (500, 'xenial'), (400, 'xenial-proposed'), (100, 'xenial-backports') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.4.0-36-generic (SMP w/4 CPU cores) Locale: LANG=en_NZ.UTF-8, LC_CTYPE=en_NZ.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages ifupdown depends on: ii adduser 3.113+nmu3ubuntu4 ii init-system-helpers 1.29ubuntu2 ii iproute2 4.3.0-1ubuntu3 ii libc6 2.23-0ubuntu3 ii lsb-base 9.20160110ubuntu0.2 Versions of packages ifupdown recommends: ii isc-dhcp-client [dhcp-client] 4.3.3-5ubuntu12.1 Versions of packages ifupdown suggests: ii ppp 2.4.7-1+2ubuntu1 pn rdnssd <none> -- no debconf information>From 74c10be956dc95d7368345445a21e1b8066ab537 Mon Sep 17 00:00:00 2001 From: Richard Laager <rlaa...@wiktel.com> Date: Wed, 14 Sep 2016 11:51:29 +1200 Subject: [PATCH] Fix a crash when multiple interfaces are specified for no-scripts. --- config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.c b/config.c index c14f625..bfade0f 100644 --- a/config.c +++ b/config.c @@ -395,7 +395,7 @@ static void add_to_list(char ***list, int *count, const char *item) { perror("realloc"); exit(1); } - *list[*count - 1] = strdup(item); + (*list)[*count - 1] = strdup(item); if (!(*list)[*count - 1]) { perror("strdup"); exit(1); -- 2.7.4
--- End Message ---
--- Begin Message ---Source: ifupdown Source-Version: 0.8.14 We believe that the bug you reported is fixed in the latest version of ifupdown, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 837...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Guus Sliepen <g...@debian.org> (supplier of updated ifupdown package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sat, 17 Sep 2016 11:40:39 +0200 Source: ifupdown Binary: ifupdown Architecture: source amd64 Version: 0.8.14 Distribution: unstable Urgency: medium Maintainer: Guus Sliepen <g...@debian.org> Changed-By: Guus Sliepen <g...@debian.org> Description: ifupdown - high level tools to configure network interfaces Closes: 814785 830212 834820 837732 Changes: ifupdown (0.8.14) unstable; urgency=medium . [ Benjamin Drung ] * Add InfiniBand parititon key support. Closes: #830212 . [ Richard Laager ] * Fix a crash when multiple interfaces are specified for no-scripts. Closes: #837732 . [ Bjørn Mork ] * Ignore link state when bringing up hotplug interfaces at boot. Closes: #814785, #834820 . [ Guus Sliepen ] * Add a test case for the no-scripts keyword. * Flush automatically assigned addresses on ifup when accept_ra=0. Checksums-Sha1: 4ffded0027e12ac71e3ca6bb2b66764a4a0bdf31 1545 ifupdown_0.8.14.dsc f4ba709f5db2c25d385a0b48851ea4b6661f7aa7 71968 ifupdown_0.8.14.tar.xz b23cfdd218f21aaa5062eb6a11d62b575a9bd60f 64878 ifupdown-dbgsym_0.8.14_amd64.deb cb3dfd92dbed2a48c1092edbc9c51ca8cdd51274 74530 ifupdown_0.8.14_amd64.deb Checksums-Sha256: 3ea5215e3051d9d304e08457e6db23cf2a51cfe6dc3be5b91ad91f2c26083189 1545 ifupdown_0.8.14.dsc 7efed5feb5f160d7b2df50e2e42768d8516c6a65f2541cf65a44e109541efa82 71968 ifupdown_0.8.14.tar.xz 41ac11a71c6e284f8d7f335acb8ad234059306ff580792bda11799f95c9a81f4 64878 ifupdown-dbgsym_0.8.14_amd64.deb 0c8b566e59fcf5f0046e515bffd4c5478e42bf6187eec1da2c747a483af1d8dc 74530 ifupdown_0.8.14_amd64.deb Files: be0a0146c2f7d4b9f2a1839eba29d408 1545 admin important ifupdown_0.8.14.dsc 5e4205e34f1f8e21b8e364e68ae57de0 71968 admin important ifupdown_0.8.14.tar.xz faeefd31b042c883bd51bd33a8163b2c 64878 debug extra ifupdown-dbgsym_0.8.14_amd64.deb 02f5cccd5e7d8fa757ff39b5bd445751 74530 admin important ifupdown_0.8.14_amd64.deb -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJX3Q/3AAoJED9JDeuHHvn6mJsQAIt/m1vPQImON0DP33O3wM48 3dxx7wJ/y6i4spR94YtMwHkBXJZRc6hEpbxPd+8imraOqmlv+kC1nE0XrtDmZZin qGPa58tDywD6gGzL0bI8oWlssi/7lNMu6IoQBA6oFvD9nUEmtmABzsWiiuwA3cdH alympnN8uSrFwWnIgfLsb9LnyGzayNPCk2zgezJMavswQxjitC3nIcoY5bV6sIlC VqwmCdWqnh9zD8JCWURdbqAsf0JU5IK//Y7aVSVPSN+hi/Y0XkdvGOZK/hcWXt48 1g9RHmOY4lmQ2e/3Id40wklAmgGtEnx+TJqAzOl/KYeoG6/I0WDBcK2mwIPaD0ZV SOACw2e5okrSShaA9NtOuHuFy379IEPwMGx9decmWa4lCJOYxJO7bEIEwiLIUzXx VbB5v1RPT0eVgffCjAwMn8aljoZmNJQqhFloqPvT0a5DHcaORfyKmm1BM1B96g7E OZoJ9uAjI1cxRr+CF0r2vs7PLfB8nbSTD/OAxAlPNqVqoPs4LnW4gGdNMcLBRWF7 8blO22APJGU7czHvhxVsD77F30s3FgQ6zrZASgd9JGj97NK3qN9B13Cc66VpQzC7 Y6AQqbtmmQlSJ2OWfN9ittgZRMcXUB174m0OqTsCSsBQ4y9JECAGwD2tENiYdwx7 5nbNTN6GY1JRWWqZ8wqz =6pza -----END PGP SIGNATURE-----
--- End Message ---
