Your message dated Sat, 12 Aug 2017 22:23:45 +0000
with message-id <e1dgeor-000b5b...@fasolo.debian.org>
and subject line Bug#870508: fixed in rhash 1.3.4-3
has caused the Debian Bug report #870508,
regarding rhash FTCBFS: wrong compiler, wrong strip, runs tests
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
870508: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=870508
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: rhash
Version: 1.3.4-2
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

rhash fails to cross build from source for a number of reasons:
 * It uses the build architecture compilers (as a Makefile default).
   Wrapping the build in dh_auto_build fixes that, because debhelper
   knows how to pass cross compilers.
 * It runs the tests despite DEB_BUILD_OPTIONS=nocheck.
 * It strips at install time with the build architecture strip (install
   default). Skipping the stripping at install time lets dh_strip
   generate a debug package and still honours the nostrip option.

After fixing all of the above, rhash cross builds successfully. Please
apply the attached patch.

Helmut
diff --minimal -Nru rhash-1.3.4/debian/changelog rhash-1.3.4/debian/changelog
--- rhash-1.3.4/debian/changelog        2017-07-10 15:54:30.000000000 +0200
+++ rhash-1.3.4/debian/changelog        2017-08-02 16:37:09.000000000 +0200
@@ -1,3 +1,13 @@
+rhash (1.3.4-2.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + Let dh_auto_build pass cross compilers to $(MAKE).
+    + Honour DEB_BUILD_OPTIONS=nocheck.
+    + Let dh_strip strip.
+
+ -- Helmut Grohne <hel...@subdivi.de>  Wed, 02 Aug 2017 16:37:09 +0200
+
 rhash (1.3.4-2) unstable; urgency=medium
 
   * Team upload (collab-maint).
diff --minimal -Nru rhash-1.3.4/debian/rules rhash-1.3.4/debian/rules
--- rhash-1.3.4/debian/rules    2017-07-10 15:54:20.000000000 +0200
+++ rhash-1.3.4/debian/rules    2017-08-02 16:37:07.000000000 +0200
@@ -15,9 +15,6 @@
 ifneq (,$(findstring debug,$(DEB_BUILD_OPTIONS)))
        CFLAGS += -g
 endif
-ifneq (,$(findstring nostrip,$(DEB_BUILD_OPTIONS)))
-       INSTALL_PROGRAM += -s
-endif
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
        NUMJOBS = $(patsubst parallel=%,%,$(filter 
parallel=%,$(DEB_BUILD_OPTIONS)))
        MAKEFLAGS += -j$(NUMJOBS)
@@ -38,18 +35,19 @@
 %:
        dh $@
 
-build:
+override_dh_auto_build:
        # Compile static/shared libraries and the program.
-       $(MAKE) lib-static lib-shared build-shared CFLAGS="$(CFLAGS)" 
LDFLAGS="$(LDFLAGS)" \
+       dh_auto_build -- lib-static lib-shared build-shared CFLAGS="$(CFLAGS)" 
LDFLAGS="$(LDFLAGS)" \
                LIBCFLAGS="$(LIBCFLAGS)" LIBLDFLAGS="$(LIBLDFLAGS)"
 
-override_dh_auto_build:
+ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)
 override_dh_auto_test:
        # note: static and shared libraries will be built if not exist yet
        $(MAKE) test-static-lib CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" \
                LIBCFLAGS="$(LIBCFLAGS)" LIBLDFLAGS="$(LIBLDFLAGS)"
        $(MAKE) test-shared CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" \
                LIBCFLAGS="$(LIBCFLAGS)" LIBLDFLAGS="$(LIBLDFLAGS)" 
LD_LIBRARY_PATH="$(LD_LIB)"
+endif
 
 override_dh_auto_install:
        # v1.3.2: quick fix for fail on parallel build

--- End Message ---
--- Begin Message ---
Source: rhash
Source-Version: 1.3.4-3

We believe that the bug you reported is fixed in the latest version of
rhash, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 870...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Helmut Grohne <hel...@subdivi.de> (supplier of updated rhash package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 02 Aug 2017 16:37:09 +0200
Source: rhash
Binary: rhash librhash0 librhash-dev librhash0-dbg
Architecture: source
Version: 1.3.4-3
Distribution: unstable
Urgency: medium
Maintainer: Aleksey Kravchenko <rhash.ad...@gmail.com>
Changed-By: Helmut Grohne <hel...@subdivi.de>
Description:
 librhash-dev - header files and a static library for librhash
 librhash0  - shared library for hash functions computing
 librhash0-dbg - debugging symbols for librhash
 rhash      - utility for computing hash sums and magnet links
Closes: 870508
Changes:
 rhash (1.3.4-3) unstable; urgency=medium
 .
   [ Gianfranco Costamagna ]
   * Team upload (collab-maint).
 .
   [ Helmut Grohne ]
   * Fix FTCBFS: (Closes: #870508)
     + Let dh_auto_build pass cross compilers to $(MAKE).
     + Honour DEB_BUILD_OPTIONS=nocheck.
     + Let dh_strip strip.
Checksums-Sha1:
 c74b1778c1e91a6176990996b967a87ce7f67675 1992 rhash_1.3.4-3.dsc
 444a6b27ede46c4a105f06363aa123ae7c7efe30 5696 rhash_1.3.4-3.debian.tar.xz
Checksums-Sha256:
 b9a1fad48008e64d4ba1aa2e0c45b2077d434db313875539f4ade7e15dbfd4bb 1992 
rhash_1.3.4-3.dsc
 52b23374d1d50a46600797707e798751920b7873c439190d8aacbc3751f70677 5696 
rhash_1.3.4-3.debian.tar.xz
Files:
 f9dfbbf84e1d62429d780e74607766a6 1992 utils optional rhash_1.3.4-3.dsc
 267eb92ba0a1201acf41d59fffb6825a 5696 utils optional 
rhash_1.3.4-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIcBAEBCAAGBQJZgkXGAAoJEPNPCXROn13Z2roP/jujPbQSkDyf4ANax4/XMyEd
Mwh6jMRFC//Mc9TONVAGg/KaNc2tIpedlyZn9h/+BYQVwlIOHTUVgf+++J9/fhvx
5GNFDe4yjmYjNicFW3B+3Ld8XgsceTDc4zBWEhOaqehswZWuN1D7aDE43EfU9N8y
+fV7z91s23PyaMxT/JAbO46xdb+LRcbEXr3bQrbPu6AWNSr/ZCrcbXjDvX3IEFXr
frdM8IsK2vUiNcfAAWazxtu3sGtXoB1FUKUs5z/Fqozz+lz3JkOk1wow6t4JvAAE
zJxc+92uAibRzIHPLIosJd4A7CGq+BR0EKT4fhVY7y/zwa271T7Vlxox87zF2o9Z
NezOP77Q6H0NgJP+3Rems5XaRCLJ/F/WxApAN+N3esMg1wdcKarLWE6Li8VtVry7
l4a8XuF1OUime8QFMQ9k5ej18xR+BqxVQSLBZAgif9jiOC0WZYAxf0Pw9OCyLSQw
qd+a9cHh7KAHGie5O94JPHjSaV4/ahZgDQmGejD+jj3SIxXK/MmVVUl4ZSp87She
fKPQWEYKihQneYOGj/oFGgdsLdYdQuqNL1dmG1tNI5/uTnFMZiLdKZQ7ugX6qVVf
GfBmd0AD3JHIzaiQWH4ULZESzCbSbIVkrX+elgld46/S6kpuZuCZ6N6g6AJPQHeG
MIkImz4M0Lr5DrYAv8Wi
=tl/K
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to