Your message dated Fri, 02 Mar 2018 22:47:15 +0000
with message-id <e1ertsn-000hhp...@fasolo.debian.org>
and subject line Bug#883208: fixed in libvirt 3.0.0-4+deb9u2
has caused the Debian Bug report #883208,
regarding libvirt0 version 3.0.0-4+deb9u1 fails to migrate qemu guests that use 
disks with cache='directsync'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
883208: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=883208
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: libvirt0
Version: 3.0.0-4+deb9u1

libvirt0 version 3.0.0-4+deb9u1 fails to migrate qemu guests that use disks 
with cache='directsync'

Directsync is necessary for us to maintain drbd data integrity. However, 
libvirt in the stable debian release prevents us from using that cache mode for 
live migration.

This has been fixed in the git version:

https://github.com/libvirt/libvirt/commit/fed9cc85eaff6f75e3d232e350d78a53f314815f#diff-6ec6f76d45ea0e7e9e53e36eac65a923

Here is my attempt at backporting that change:


--- qemu_migration.c.orig    2017-11-30 15:58:34.143882478 +0100
+++ qemu_migration.c    2017-11-30 16:26:27.801361294 +0100
@@ -2377,7 +2377,8 @@
         /* Our code elsewhere guarantees shared disks are either readonly (in
          * which case cache mode doesn't matter) or used with cache=none */
         if (qemuMigrateDisk(disk, nmigrate_disks, migrate_disks) &&
-            disk->cachemode != VIR_DOMAIN_DISK_CACHE_DISABLE) {
+            disk->cachemode != VIR_DOMAIN_DISK_CACHE_DISABLE &&
+            disk->cachemode != VIR_DOMAIN_DISK_CACHE_DIRECTSYNC) {
             int rc;

             if (virDomainDiskGetType(disk) == VIR_STORAGE_TYPE_FILE) {
@@ -2396,7 +2397,7 @@

             virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s",
                            _("Migration may lead to data corruption if disks"
-                             " use cache != none"));
+                             " use cache != none or cache != directsync"));
             return false;
         }
     }


Mit freundlichen Grüßen

Carsten Burkhardt

--
Dipl. Ing.Carsten Burkhardt | c.burkha...@b-c-s.de
bcs kommunikationslösungen
Inh. Dipl. Ing. Carsten Burkhardt
Harz 51 | 06108 Halle (Saale) | Germany
tel +49 345 29849-0 | fax +49 345 29849-22
www.b-c-s.de | www.halle.it | www.wivewa.de

SIE MÖCHTEN EINFACH IHRE ADRESSEN, GEBURTSTAGE UND DOKUMENTE VERWALTEN UND 
TROTZDEM IHRE DATEN SICHER WISSEN. DANN ÜBERZEUGEN SIE SICH VON WIVEWA unter: 
www.wivewa.de

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


--- End Message ---
--- Begin Message ---
Source: libvirt
Source-Version: 3.0.0-4+deb9u2

We believe that the bug you reported is fixed in the latest version of
libvirt, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 883...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guido Günther <a...@sigxcpu.org> (supplier of updated libvirt package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 20 Jan 2018 17:51:39 +0100
Source: libvirt
Binary: libvirt-clients libvirt-daemon libvirt-daemon-system libvirt0 
libvirt-doc libvirt-dev libvirt-sanlock libnss-libvirt
Architecture: source
Version: 3.0.0-4+deb9u2
Distribution: stretch
Urgency: medium
Maintainer: Debian Libvirt Maintainers 
<pkg-libvirt-maintain...@lists.alioth.debian.org>
Changed-By: Guido Günther <a...@sigxcpu.org>
Description:
 libnss-libvirt - nss plugin providing IP add ress resolution for virtual 
machines
 libvirt-clients - Programs for the libvirt library
 libvirt-daemon - Virtualization daemon
 libvirt-daemon-system - Libvirt daemon configuration files
 libvirt-dev - development files for the libvirt library
 libvirt-doc - documentation for the libvirt library
 libvirt-sanlock - Sanlock plugin for virtlockd
 libvirt0   - library for interfacing with different virtualization systems
Closes: 883208 887700
Changes:
 libvirt (3.0.0-4+deb9u2) stretch; urgency=medium
 .
   * CVE-2018-5748: qemu: avoid denial of service reading from QEMU monitor
     (Closes: #887700)
   * qemu: shared disks with cache=directsync should be safe for migration.
     Thanks to Carsten Burkhardt (Closes: #883208)
Checksums-Sha1:
 ac273c3d460bcc2ad7e0c536635a9c09aa694fe5 3954 libvirt_3.0.0-4+deb9u2.dsc
 ee88b9b60970549ce7893ec3d91bb8d26e6b73e3 70280 
libvirt_3.0.0-4+deb9u2.debian.tar.xz
 35768977375f84eca5a7ba4ca35b7a8eb5a95ea7 16066 
libvirt_3.0.0-4+deb9u2_amd64.buildinfo
Checksums-Sha256:
 a92829d754f131322bf14e1527ccbefdaa4f688bee93525378c1905594f95663 3954 
libvirt_3.0.0-4+deb9u2.dsc
 5d51f7fc05f8ffc4fc12a68719a275bfa8c0739b4fc52897910562ae95a5d1eb 70280 
libvirt_3.0.0-4+deb9u2.debian.tar.xz
 91593544cb1c32f0ba4f85d177842f9f2b32ae3d5e9a57e3771c23adedbedf1a 16066 
libvirt_3.0.0-4+deb9u2_amd64.buildinfo
Files:
 362039d4e3ab3018e709a3fa15183d42 3954 libs optional libvirt_3.0.0-4+deb9u2.dsc
 3ee1c2f71da450d6c8d723e2ca210cf2 70280 libs optional 
libvirt_3.0.0-4+deb9u2.debian.tar.xz
 e63724b179df60fb0849bf12f911b77c 16066 libs optional 
libvirt_3.0.0-4+deb9u2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEvHzQcjh1660F3xzZB7i3sOqYEgsFAlqT7n8ACgkQB7i3sOqY
EgtP5hAAjrXd2VP2CQtA+Xk9GrrMfZ8CQ4YtuyQZeBiYpaMsgVpvDqj7bDz7VQv2
7XBqS+dlz4ft8fYXcX3QuPO9GtUmvisCZQoIqZ6oxDttr3MUcoUQ78S70atxd1w5
PkmcRqnWqrOAZEXnF8mBdTiFU9NwrbgEIl8u56PPlRhGGqX8P9VPT53fACpddWaP
bj3EC7JuMlJknVnu0ltW1Z7hp9Fs3ORgSmuWVXW6PRksNHEDe0zpCqLmd8suOHpL
4FSyJ1Sn2RA6UXjErqO5mSIsl95azarLxKQAEslaUXPHm98KV22P4nkE6LSX8zUy
/kcm9UJgheH6teq6CdLLS1zSi48y2nyqMBuQ+wU2qdoG5eP6+xll57vY/HnqMWVh
oXW6qX3ROUve3fkKcqYQ4HBWMjRvp3CTBkwzpquHoWqQxIl/tG05iEbO4JDitmPC
95kky7NGj9RK3IXTYB1FeQbaBfRVDNsbLfS8Q4p8+3/KEwuiLElnUhk4MKv+f31l
GBdwLcc3aqFrOayUPiyOFlcMPwT3reqlGDE+bPcVPiQf1eA12n3ZMyE6v+0fDypt
lYlpxiH6QuPlTOwHviA+KTZ8i6+VHKDI/Tzd9kahgCV7NbD8/qRxe/KyGsftU3j/
GhkZLGleVlTZFeHj+M9J5owcl1BPVS0nNL5GhILSXS6qSvxebxI=
=ViXe
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to