Your message dated Mon, 12 Mar 2018 01:49:13 +0000
with message-id <e1evcap-0001wo...@fasolo.debian.org>
and subject line Bug#887636: fixed in fltk1.1 1.1.10-24
has caused the Debian Bug report #887636,
regarding fltk1.1 FTCBFS: multiple reasons
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
887636: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887636
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: fltk1.1
Version: 1.1.10-23
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap
Control: affects 871470 + src:fltk1.1

fltk1.1 fails to cross build from source. There are a number of reasons
for that. Let me discuss them individually.

 * The upstream makefile includes "makeinclude" and for building
   makeinclude, it configures the package. Thus when "dh_auto_clean"
   issues make clean, the package actually configures itself. It does so
   for the build architecture and aborts, because it doesn't find some
   dependencies. Thus dh_auto_clean fails.

   The cure here is to create makeinclude prior to dh_auto_clean and
   then supply the one variable (RMDIR) it needs from that file.

 * Then the packaging supplies CC and CXX to dh_auto_configure.
   Unfortunately, those variables contain the build architecture
   compilers. Again configure aborts failing to find dependencies.
   Removing the erroneous assignments cures this.

 * Next, dh_auto_build builds the "test" directory and that fails
   during cross compilation. That subdirectory should really only be
   built by an indep build or by dh_auto_test (unless DEB_BUILD_OPTIONS
   contains nocheck). So we should remove it from DIRS in an arch-only
   build.

 * Finally, #871470 breaks the build.

The attached patch fixes all of the issues but the last one. Please
consider applying it. When doing so, please close this bug even though
fltk1.1 will still fail to cross build.

Helmut
diff --minimal -Nru fltk1.1-1.1.10/debian/changelog 
fltk1.1-1.1.10/debian/changelog
--- fltk1.1-1.1.10/debian/changelog     2017-01-25 05:25:20.000000000 +0100
+++ fltk1.1-1.1.10/debian/changelog     2017-08-29 20:57:48.000000000 +0200
@@ -1,3 +1,13 @@
+fltk1.1 (1.1.10-23.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Address FTCBFS: (Closes: #-1)
+    + Avoid configuring during clean.
+    + Do not pass build architecture compiler to configure.
+    + Do not build directory test during arch-only build.
+
+ -- Helmut Grohne <hel...@subdivi.de>  Tue, 29 Aug 2017 20:57:48 +0200
+
 fltk1.1 (1.1.10-23) unstable; urgency=medium
 
   * debian/control:
diff --minimal -Nru fltk1.1-1.1.10/debian/rules fltk1.1-1.1.10/debian/rules
--- fltk1.1-1.1.10/debian/rules 2017-01-25 05:25:20.000000000 +0100
+++ fltk1.1-1.1.10/debian/rules 2017-08-29 20:57:48.000000000 +0200
@@ -19,22 +19,23 @@
 
 override_dh_auto_configure:
        mv fltk.spec fltk.spec.saved
-       dh_auto_configure -- CC="$(CC)" CXX="$(CXX)" \
+       dh_auto_configure -- \
             DSOFLAGS="$(filter-out -fPIE -pie,$(LDFLAGS))" \
            --enable-shared --enable-threads --enable-xft \
            --enable-xinerama --without-links --libdir=$(libdir) \
            --with-optim=$(filter -O%,$(CXXFLAGS))
        mv fltk.spec.saved fltk.spec
 
-override_dh_auto_build:
-       dh_auto_build     -- OPTIM="$(CFLAGS) $(XCFLAGS)" STRIP=@:
-# documentation/Makefile ignores errors from htmldoc, so this command
-# should be safe to run unconditionally.
+override_dh_auto_build-arch:
+       dh_auto_build     -- OPTIM="$(CFLAGS) $(XCFLAGS)" STRIP=@: 
DIRS='$$(IMAGEDIRS) src fluid'
+override_dh_auto_build-indep:
+       dh_auto_build     -- OPTIM="$(CFLAGS) $(XCFLAGS)" STRIP=@: DIRS='test 
documentation'
        $(MAKE) -C documentation fltk.pdf fltk.ps
 
 override_dh_auto_clean:
        mv fltk.spec fltk.spec.saved
-       dh_auto_clean
+       touch makeinclude # avoid reconfigure. removed by distclean
+       dh_auto_clean -- RMDIR='rm -Rf'
        mv fltk.spec.saved fltk.spec
 
 override_dh_clean:

--- End Message ---
--- Begin Message ---
Source: fltk1.1
Source-Version: 1.1.10-24

We believe that the bug you reported is fixed in the latest version of
fltk1.1, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 887...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aaron M. Ucko <u...@debian.org> (supplier of updated fltk1.1 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 11 Mar 2018 21:30:58 -0400
Source: fltk1.1
Binary: libfltk1.1-dev libfltk1.1 fltk1.1-doc fltk1.1-games
Architecture: source
Version: 1.1.10-24
Distribution: unstable
Urgency: medium
Maintainer: Aaron M. Ucko <u...@debian.org>
Changed-By: Aaron M. Ucko <u...@debian.org>
Description:
 fltk1.1-doc - Fast Light Toolkit - documentation
 fltk1.1-games - Fast Light Toolkit - example games: checkers, sudoku
 libfltk1.1 - Fast Light Toolkit - shared libraries
 libfltk1.1-dev - Fast Light Toolkit - development files
Closes: 887636 892341
Changes:
 fltk1.1 (1.1.10-24) unstable; urgency=medium
 .
   * debian/compat: Advance to 10 (holding off on 11 due to lack of
     --runstatedir support).
   * debian/control:
     - Add pkg-config to Build-Depends.
     - Advance debhelper Build-Depends version constraint to (>= 10~).
     - Rules-Requires-Root: no (confirmed not to affect binary packages).
     - Vcs-{Browser,Git}: Move to salsa.debian.org.
     - Standards-Version: 4.1.3 (was just missing nodoc, now implemented).
   * debian/rules:
     - Address FTCBFS, based on a patch from Helmut Grohne (Closes: #887636).
       + Avoid configuring during clean.
       + Do not pass build architecture compiler to configure.
       + In arch-only builds, limit coverage of test/ to the three targets we
         specifically need for fltk1.1-games.  (Many of the others involve
         trying to run freshly built fluid.)
     - Pass "/usr/bin/pkg-config freetype2" off as FTCONFIG (in lieu of
       freetype-config, which is now deprecated).  (Closes: #892341.)
     - Set DEB_BUILD_MAINT_OPTIONS more readably.
     - Use ?= for DEB_HOST_ARCH, as already done for DEB_HOST_MULTIARCH.
     - override_dh_auto_build-indep: Support nodoc in DEB_BUILD_OPTIONS.
     - Run dh --without autoreconf; debhelper enables autoreconf by default
       as of compat level 10, but it breaks here and isn't worth fixing.
Checksums-Sha1:
 177b5563fb99deb26f48b9fe1db60081956c2d30 2350 fltk1.1_1.1.10-24.dsc
 899b373bef7de4447d6e8da1fe5880dd0e41917c 43624 fltk1.1_1.1.10-24.debian.tar.xz
Checksums-Sha256:
 6c292d5914abc94b6acb1b6726c6a722c9dc399c75b54f35dd5276bdee2c8d8c 2350 
fltk1.1_1.1.10-24.dsc
 e30142c4c89a3f2309806ae697209d97a3287facd097151bf41eeeb8143e0ad2 43624 
fltk1.1_1.1.10-24.debian.tar.xz
Files:
 0b316a61f11efd28eadfa20dbe212bc8 2350 libs optional fltk1.1_1.1.10-24.dsc
 32e18ee5bf15aa7a572c7415a9fa322e 43624 libs optional 
fltk1.1_1.1.10-24.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEfDq5z9IwvTDdAJxZHnCRsfFKZKIFAlql2NEACgkQHnCRsfFK
ZKKUhRAAp8pNmzxrhEeP5cbSrkUElcyq+Qw3zAbsmPZq3RoEYWGD3xrB6zs7wHyZ
ciMQxhAiSLBAWQvOOEs7uVf0WWmOpQSwDd3uURFCTb0pVBAApZD74HsIGcNQQZba
7RTe4dL7WZNkfjG2PDST04+k3B+UpWP2KrigHKI4bXuzfv0dJjIhqWpD5+xaZG9N
38oChH97dCVbvolZ7nlV+ZSHwBeaKp8DDSJccqsKY+7rWaqdIfioc6Leb73rpigz
sBZlkKb5i8Hw76ZdglhCZ4XX+lb7UUBQa9Jmk3b68qJX8BOXp9w4zHOuZXZwL2H6
fFZSmbI4Nz25l+A9mw2Kj+DWuJqzRMoIr0GgaYYLMHTULVDf+d1Zq1Do4iVakHkv
GYjb6yZrie8rDu2brjjA2JQuZKF5UhtlHWKLGsQPGMdKtQxRCvDvvylFcFLypAez
R/2NhgBgNNhJ0WUKWRNDenUe973qFxMzpQsnQ+5D5mWe6KAnsgp7Rp8Dp6Fx/0vb
wewk4G6Vt8TYsIrCYiysG6onXGWElIR2LWNGqqHOcP5xLbSYb8rXSuKUrw9rNbZx
+bAH/6FwWFZXE84KpvauWykMGBcPyEJM3uhc6CzTJbFaFVSEzK8LyUEh0uspPfbQ
qHQpoSoCnKqFpvqtJdP34ur6h2Ga21KKTkoUVpcS9aQgpNWwWMk=
=EkLx
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to