Your message dated Wed, 14 Mar 2018 01:53:42 +0000
with message-id <e1evvbq-000gqg...@fasolo.debian.org>
and subject line Bug#887908: fixed in openbox 3.6.1-7
has caused the Debian Bug report #887908,
regarding toggled hover and pressed images masks not loaded
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
887908: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=887908
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: openbox
Version: 3.5.2-8+deb8u1

toggled hover and pressed images masks in openbox themes are not loaded which broke many existing themes e.g.

https://www.box-look.org/p/1017288/

in the same page there exists a link with the upstream patch that fixes the problem:

http://git.openbox.org/?p=mikachu/openbox.git;a=commitdiff;h=f1f5610cca8511be3bd03198f49a6a4e9fc15314

it would be very nice if the patch is applied to the Jessie package. Although this patch was included in versions >= 3.6.0 the bug was re-introduced and Stretch and Sid packages are also affected.

A simple workaround is attached in the bug report to fix the problem in versions >= 3.6.0, there is a swap in the prefix filenames and variable names in the code which prevents the masks to be loaded.

Please also apply this fix in Stretch or contact upstream if needed,
Many thanks
Index: openbox-3.6.1/obrender/theme.c
===================================================================
--- openbox-3.6.1.orig/obrender/theme.c
+++ openbox-3.6.1/obrender/theme.c
@@ -1494,8 +1494,10 @@ static void read_button_styles(XrmDataba
     READ_BUTTON_MASK_COPY(disabled, btn->unpressed_mask);
     READ_BUTTON_MASK_COPY(hover, btn->unpressed_mask);
     if (toggled_mask) {
-        READ_BUTTON_MASK_COPY(pressed_toggled, btn->unpressed_toggled_mask);
-        READ_BUTTON_MASK_COPY(hover_toggled, btn->unpressed_toggled_mask);
+        g_snprintf(name, 128, "%s_toggled_pressed.xbm", btnname);
+        READ_MASK_COPY(name, btn->pressed_toggled_mask, btn->unpressed_toggled_mask);
+        g_snprintf(name, 128, "%s_toggled_hover.xbm", btnname);
+        READ_MASK_COPY(name, btn->hover_toggled_mask, btn->unpressed_toggled_mask);
     }
 
 #define READ_BUTTON_APPEARANCE(typedots, type, fallback) \

--- End Message ---
--- Begin Message ---
Source: openbox
Source-Version: 3.6.1-7

We believe that the bug you reported is fixed in the latest version of
openbox, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 887...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mateusz Łukasik <mat...@linuxmint.pl> (supplier of updated openbox package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 12 Mar 2018 10:41:03 +0100
Source: openbox
Binary: openbox libobt2v5 libobrender32v5 openbox-dev gnome-panel-control 
openbox-gnome-session openbox-kde-session
Architecture: source
Version: 3.6.1-7
Distribution: unstable
Urgency: medium
Maintainer: Mateusz Łukasik <mat...@linuxmint.pl>
Changed-By: Mateusz Łukasik <mat...@linuxmint.pl>
Description:
 gnome-panel-control - command line utility to invoke GNOME panel run 
dialog/menu
 libobrender32v5 - rendering library for openbox themes
 libobt2v5  - parsing library for openbox
 openbox    - standards-compliant, fast, light-weight and extensible window man
 openbox-dev - development files for the openbox window manager
 openbox-gnome-session - command line utility to run Openbox as GNOME session
 openbox-kde-session - command line utility to run Openbox as KDE SC session
Closes: 887908 892006
Changes:
 openbox (3.6.1-7) unstable; urgency=medium
 .
   * Adjust adapt-to-gsd-324.patch for plugin dropped in
     gnome-settings-daemon 3.28 (Closes: #892006)
   * Add patch to fix toggled hover and pressed images masks not loaded.
     (Closes: #887908)
Checksums-Sha1:
 db4d4883c2046ee4566bb602a9b65809bba74156 2464 openbox_3.6.1-7.dsc
 da1e62f9b46bc9abd6cde6155dfe7357c2785899 52632 openbox_3.6.1-7.debian.tar.xz
 f544876c87488f547ab8dd1c3250b4cbbf78e1cc 6254 openbox_3.6.1-7_source.buildinfo
Checksums-Sha256:
 34b18e080173d97c573392849f942e924db509afafeeec9333d985af449f8df7 2464 
openbox_3.6.1-7.dsc
 3ea4b6fe0133ec8150ee24674c55fa3f1f303e8df940093ef7f9cb186124b86b 52632 
openbox_3.6.1-7.debian.tar.xz
 d24ce17de30bbd37c0c842c85a139146a680df1f9744fae91c7f2bce6c4fd60d 6254 
openbox_3.6.1-7_source.buildinfo
Files:
 c1a090b8cb26653d1e328736e425a3a4 2464 x11 optional openbox_3.6.1-7.dsc
 a809b1630d1d9b84dc9d58d127eab6b5 52632 x11 optional 
openbox_3.6.1-7.debian.tar.xz
 89c9c0c8a649a7467ec9543a2e732849 6254 x11 optional 
openbox_3.6.1-7_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEkjZVexcMh/iCHArDweDZLphvfH4FAlqoeakACgkQweDZLphv
fH45/BAA0zcVRQem807NeMTIV/fNzx9r54CdoRA7ShI1FAR1IzWTAsxeb8NVqRE2
fGpLw0W+U68sZHurGRUPFxCmBnLNfDx7cLqOSD6xUhUKrbpBHIStBmQgVXmh/s6l
jw+wytfX6MLVN96xN4SNJAWUnK4cRr/C1gGTO+UFauxUao7jRVlxeGOYeRFBB1lr
1Dqg2GMUZmQi1mAwm0FyJlJS9aYBJvZ9HbNx8yt+BR4VExnGq/2TtbVjpop97m1G
eOQ4CKWZRQRwnwSdkj54jFA74UyxDrvsIy3I6GfbpyfiCv6MOz8/pFO4XOpUaJ2v
wlK8RTsQ7wKXI44rjFc0abbI6HkwaPubhxl9zfcjht+wbOHDtwdiq/pNvUMSoLBq
rsauzPGLKN10c37WFnfz3eF4oUsfPuIGZqfelgWjsTetdWHoXS1Jd0rYCrbIV277
qUEwd95ZuqPjbmtCzxHdPkoO/r2qUZ3/Fh6ZAVh37gG6tfX5Erp/OvXFm2eIbbet
c709tUJJaJzIN8EPfNcltQ1AESluZSN30wyOoTjwOWPUwjsSZgzsR2KzTXBPGo/m
H8VB3y3cLEfKoBpDtWA8j8PGhecWnsbItjFDhhIrBh+6EbGGwwVeG60VN2Qk6iBe
svF2Yx+vBBuFb4Y7p5bY3ez89GakfV0fDREBM2YytSjpr/abui8=
=A54/
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to