Your message dated Tue, 13 Mar 2018 10:11:53 +0000 with message-id <e1evgup-000ato...@fasolo.debian.org> and subject line Bug#891263: fixed in puppet 5.4.0-2 has caused the Debian Bug report #891263, regarding puppet: please make the build reproducible to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 891263: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891263 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: puppet Version: 5.4.0-1 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: timestamps hostname X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0], we noticed that puppet could not be built reproducibly. This is because it includes the current time in the manpages, as well as the build host's domain name. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `---- a/lib/puppet/defaults.rb 2018-02-23 22:03:04.353812204 +0000 --- b/lib/puppet/defaults.rb 2018-02-23 22:32:13.241364756 +0000 @@ -703,7 +703,7 @@ # We have to downcase the fqdn, because the current ssl stuff (as opposed to in master) doesn't have good facilities for # manipulating naming. :certname => { - :default => lambda { Puppet::Settings.default_certname.downcase }, + :default => lambda { ENV.has_key?('SOURCE_DATE_EPOCH') ? '(node\'s fully qualified domain name)' : Puppet::Settings.default_certname.downcase }, :desc => "The name to use when handling certificates. When a node requests a certificate from the CA puppet master, it uses the value of the `certname` setting as its requested Subject CN. --- a/lib/puppet/util/reference.rb 2018-02-23 22:03:04.349812169 +0000 --- b/lib/puppet/util/reference.rb 2018-02-23 22:25:12.937581256 +0000 @@ -2,6 +2,12 @@ require 'puppet/util/methodhelper' require 'fileutils' +if ENV['SOURCE_DATE_EPOCH'].nil? + $now = Time.now +else + $now = Time.at(ENV['SOURCE_DATE_EPOCH'].to_i).gmtime +end + # Manage Reference Documentation. class Puppet::Util::Reference include Puppet::Util @@ -13,7 +19,7 @@ instance_load(:reference, 'puppet/reference') def self.footer - "\n\n----------------\n\n" + _("*This page autogenerated on %{current_time}*\n") % { current_time: Time.now.to_s } + "\n\n----------------\n\n" + _("*This page autogenerated on %{current_time}*\n") % { current_time: $now.to_s } end def self.modes @@ -112,7 +118,7 @@ # First the header text = markdown_header(@title, 1) #TRANSLATORS message accompanied by date of generation - text << _("\n\n**This page is autogenerated; any changes will get overwritten** *(last generated on %{current_time})*\n\n") % { current_time: Time.now.to_s } + text << _("\n\n**This page is autogenerated; any changes will get overwritten** *(last generated on %{current_time})*\n\n") % { current_time: $now.to_s } text << @header
--- End Message ---
--- Begin Message ---Source: puppet Source-Version: 5.4.0-2 We believe that the bug you reported is fixed in the latest version of puppet, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 891...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Apollon Oikonomopoulos <apoi...@debian.org> (supplier of updated puppet package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Tue, 13 Mar 2018 10:54:34 +0200 Source: puppet Binary: puppet puppet-master puppetmaster puppet-master-passenger puppetmaster-passenger puppet-common Architecture: source all Version: 5.4.0-2 Distribution: unstable Urgency: medium Maintainer: Puppet Package Maintainers <pkg-puppet-de...@lists.alioth.debian.org> Changed-By: Apollon Oikonomopoulos <apoi...@debian.org> Description: puppet - configuration management system puppet-common - transitional dummy package puppet-master - configuration management system, master service puppet-master-passenger - configuration management system, scalable master service puppetmaster - configuration management system, master service - transitional pa puppetmaster-passenger - configuration management system, scalable master service - transi Closes: 891263 Changes: puppet (5.4.0-2) unstable; urgency=medium . * Switch Vcs-* URLs to salsa * Ensure the package builds reproducibly. Patch by Chris Lamb, thanks! (Closes: #891263) * Add Breaks against ruby-gettext-setup (<< 0.17), see #892737 for details. Checksums-Sha1: 93756984849f789b6a834ff0c74dd002f5e3e758 2722 puppet_5.4.0-2.dsc 6794f6fe3f6de98f6bc1d974b40799e354fa02fe 37864 puppet_5.4.0-2.debian.tar.xz 571c574822fba0a639df072e9281fb4bea3b35d6 24516 puppet-common_5.4.0-2_all.deb 4330d9db2b5d40e023084a5d40bb036455bb8d1b 28108 puppet-master-passenger_5.4.0-2_all.deb b95f143052d714e23036e8b2211cc1496e0af3c0 27036 puppet-master_5.4.0-2_all.deb 398ac30ff887652db03f8aea362bc074b5678d66 1250248 puppet_5.4.0-2_all.deb dd23743767d6ca7fcad92b834b5eddea54d9da52 9145 puppet_5.4.0-2_amd64.buildinfo 3d1438aa5b6a4a98939a92672283a0bc628f76a3 23824 puppetmaster-passenger_5.4.0-2_all.deb 9c8b801e74d6966173758c8059aa179e51781892 23996 puppetmaster_5.4.0-2_all.deb Checksums-Sha256: 5cba9bec82547dd0925f777a65114500a8f59092030396a1541786f082412d52 2722 puppet_5.4.0-2.dsc e49f77e0c91a51a5c8b40d959a16932c6fc36f45b5878bfba7b81b6fb435fdad 37864 puppet_5.4.0-2.debian.tar.xz 30205d9b1526811302bd2906a1af7a6eefc5d2f852f83dbfcd4099cb49a46a3c 24516 puppet-common_5.4.0-2_all.deb cf0fa1229cbdaeba19418fd87d8d52596d298e769afde8968c2630a6231362ff 28108 puppet-master-passenger_5.4.0-2_all.deb 9a4bde2b02d145468d3244c8373fba1aebfc64dce9c5d4ce592b539d4f0c4736 27036 puppet-master_5.4.0-2_all.deb 1eedb3c7e8ed1ab04d8de9739070ccc1ff0076cb6c8c311fac0fba72611fb102 1250248 puppet_5.4.0-2_all.deb 1ce4f1488c058f3beb3e51f094b3c09b1efd2a93f16b30c476418b97bae3d4e7 9145 puppet_5.4.0-2_amd64.buildinfo 781735dac82c892b25137ac5accabb3d53087fbae9ad6e0c68e91d22775b7030 23824 puppetmaster-passenger_5.4.0-2_all.deb f1c727c0f49ea80fc7ffc910d193c2c3fac3302d43e3ee4620b7805ba9be7879 23996 puppetmaster_5.4.0-2_all.deb Files: 4e5f558b383e0d2a93dbe0d7f77c6f0f 2722 admin optional puppet_5.4.0-2.dsc 1e6b38a6644bd79d8854b893ef296600 37864 admin optional puppet_5.4.0-2.debian.tar.xz 33a74a8685442dd5fce5b6f292cbb1b0 24516 oldlibs optional puppet-common_5.4.0-2_all.deb 185ac848abc4cc94ad12600b79ce8741 28108 admin optional puppet-master-passenger_5.4.0-2_all.deb bed97921890e0a58b7bbe11f3337c1d9 27036 admin optional puppet-master_5.4.0-2_all.deb 3b4c4fd2a844b1b34e51301ac2962663 1250248 admin optional puppet_5.4.0-2_all.deb ea921c93b91ea5b2711d828990af484d 9145 admin optional puppet_5.4.0-2_amd64.buildinfo 23f80a0b171b8a370a925c916322590a 23824 oldlibs optional puppetmaster-passenger_5.4.0-2_all.deb 8882c401664b427a553b05caefc720ef 23996 oldlibs optional puppetmaster_5.4.0-2_all.deb -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEPgL9ZlYpWVIRC6uZ9RsYxyAkgiQFAlqnmNEACgkQ9RsYxyAk giR2VA/+KQoZT2xGxyMV+yH4Fq2hMx3yd0RbdTB5kMuGLdz5OUdih4bt2pQ8+pc5 wdBpSXyYYaYy6TDtQVxPkYJZivTop2Zrn3Xy1cgfVjGIErRV4ogOCDckJo8gzvMC 22lb3Y8Tq5lkg3UkPuy/NLqzQsj1UTTWsMAkS7pDCwFdziW8hR/8v0UWLYoLRdEi hAKPLgwalHdgBy7FyMdwv93j55gcBhLOyWzhZqHQb8dicamy9Qv4NwHMi4vthZrG gXkL1EFmcmbybOkaCdnEU97zOBnM3BviRgMJzlkEkbSJpsUuknx9XFsFCAugeUvK JBhcpNgkPbEQjVQMaTjj6OZOESpk0msfezxWqH/1hQAZGo/ZGq04x6o8wHeIB6ux pc3FoM7JiG4Ac+4EIdFLL8jx0M7cct0+PGSnzHySzN/xg/asjQo7vjd57mlwPn0m WlckC1+Y4Se6QCPuRD6m/nE35o/ieaRDuAP7E5swgqpaMo0GAjwv/01RHMmtl4rz EBAGyYBV5nbZKAdF/MowCdxXoRRXVKUko6zARkD7MhSsgRhBUMNzYkQ3+Ajrwuz+ pCiHBr8gDCG6FrP0L2JhmEczSD5rUlgjC1GJYhelwFmeQrevzc+rgGVGkFre7v06 77bjWUI0PsQc3hHUPw84MGlKJdWjGGM5s/Fc5ZdLpiWPjV7cXks= =+mmO -----END PGP SIGNATURE-----
--- End Message ---
