Hello, I believe Ludwig Reiter's patch, <pwgen-2.06-ambiguous.patch <https://bugs.debian.org/cgi-bin/bugreport.cgi?msg=10;filename=pwgen-2.06-ambiguous.patch;att=1;bug=574265>>, to be misguided.
The mechanism of this bug seems to be that -B/--ambiguous/PW_AMBIGUOUS only excludes uppercase O but pw_phonemes(), the phonemic generator, can generate a lowercase o, which is first checked against the exclusion, and then, if PW_UPPERS is turned on, uppercased. Strangely enough, this erroneous order is Debian-specific: it appears in pwgen 2.06-1 but it does not appear in the upstream. (Specifically, the PW_AMBIGUOUS flag is first implemented in < http://pwgen.cvs.sourceforge.net/viewvc/pwgen/src/pw_phonemes.c?r1=1.8&r2=1.9>, which uses the correct order.) Thus, a better solution would be to make sure Debian's pwgen source matches the upstream rather than adding an extra test for what is already being tested in the upstream code. Although the reporter of that bug does not specify whether they're using the Debian codebase, I suspect it's possible that < https://sourceforge.net/p/pwgen/bugs/7/> may also be caused by this issue. There's another strange issue regarding the Debianisation of this package: instead of the standard structure of containing an upstream distribution and a Debianising diff, there's an opaque <pwgen_2.06.orig.tar.gz <http://ftp.de.debian.org/debian/pool/main/p/pwgen/pwgen_2.06.orig.tar.gz>> together with Debian-specific files and an empty <pwgen_2.06-1.diff.gz <http://ftp.de.debian.org/debian/pool/main/p/pwgen/pwgen_2.06-1.diff.gz>>.) If the diff actually listed changes between the upstream source and the Debianised source, this spurious change would have been more likely to be noticed before. -- Andres Soolo
