Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-04-02 Thread Hannes Frederic Sowa
On Wed, Apr 03, 2013 at 12:12:12AM +, Huang, Xiong wrote: > > > Hannes, Thanks for your testing ! > > > > > > simply revising MAX_TX_BUF_LEN to 0x4000 will cause incorrect TX > > configuration... > > > I mean you can try to put a gso size limit of 0x4000 (or 0x5000) > > > > I tested both

Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-04-02 Thread Hannes Frederic Sowa
On Tue, Apr 02, 2013 at 03:34:53PM -0700, Eric Dumazet wrote: > Really I don't understand why people use u16 instead of u32. > > u16 is slower most of the time, and more prone to overflows. > > diff --git a/drivers/net/ethernet/atheros/atl1e/atl1e_main.c > b/drivers/net/ethernet/atheros/atl1e/at

Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-04-02 Thread Hannes Frederic Sowa
On Tue, Apr 02, 2013 at 10:23:54PM +, Huang, Xiong wrote: > > > > > On Tue, Apr 02, 2013 at 09:51:12PM +, Huang, Xiong wrote: > > > > The error vanishes as soon as I put a gso size limit of > > > > MAX_TX_BUF_LEN in the driver. MAX_TX_BUF_LEN seems to be > > arbitrary > > > > set to 0x200

Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-04-02 Thread Hannes Frederic Sowa
On Tue, Apr 02, 2013 at 03:34:53PM -0700, Eric Dumazet wrote: > On Wed, 2013-04-03 at 00:15 +0200, Hannes Frederic Sowa wrote: > > On Tue, Apr 02, 2013 at 03:00:38PM -0700, Eric Dumazet wrote: > > > On Tue, 2013-04-02 at 23:15 +0200, Hannes Frederic Sowa wrote: > > > &g

Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-04-02 Thread Hannes Frederic Sowa
On Tue, Apr 02, 2013 at 09:51:12PM +, Huang, Xiong wrote: > > The error vanishes as soon as I put a gso size limit of MAX_TX_BUF_LEN in > > the driver. MAX_TX_BUF_LEN seems to be arbitrary set to 0x2000. I can even > > raise it to 0x3000 and don't see any tcp retransmits. Do you have an advice

Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-04-02 Thread Hannes Frederic Sowa
On Tue, Apr 02, 2013 at 03:00:38PM -0700, Eric Dumazet wrote: > On Tue, 2013-04-02 at 23:15 +0200, Hannes Frederic Sowa wrote: > > > The error vanishes as soon as I put a gso size limit of MAX_TX_BUF_LEN > > in the driver. MAX_TX_BUF_LEN seems to be arbitrary set to 0x2000. I

Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-04-02 Thread Hannes Frederic Sowa
On Mon, Apr 01, 2013 at 02:51:56AM +, Huang, Xiong wrote: > > > > > > I checked windows driver, it does limit the max packet length for TSO > > > windows XP : 32*1024 bytes (include MAC header and all MAC payload). No > > support IP/TCP option. > > > Windows 7: 15, 000 bytes, support IP/TCP o

Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-04-02 Thread Hannes Frederic Sowa
On Tue, Apr 02, 2013 at 09:35:04AM +0200, Anders Boström wrote: > I'm sorry, but I can't test this at the moment. The computer with the > TSO-problem is running as a file-server => can't be used for testing. > Also, we don't use the Atheros Ethernet interface any more due to > other problems, hard

Bug#565404: linux-image-2.6.26-2-amd64: atl1e: TSO is broken

2013-03-31 Thread Hannes Frederic Sowa
On Sun, Mar 31, 2013 at 12:25:58AM +, Ben Hutchings wrote: > On Tue, 2010-01-26 at 09:34 +0100, Anders Boström wrote: > > > "JY" == Jie Yang writes: > > > > JY> Anders Boström wrote: > > > > JY> following is my test cese, > > >> > > JY> a nfs server server with ar8131chip, device i