Bug#851359: diffoscope: Improve support for comparing images

Hi Chris, Thanks again for your guidance and help! On 24.04.2017 19:13, Chris Lamb wrote: > So, I think… > > if get_image_size(self.path) != get_image_size(other.path): > raise AssertionError > > … are better written as: > > assert get_image_size(self.path) ==

Bug#851359: diffoscope: Improve support for comparing images

Hi Chris, On 21.04.2017 22:58, Chris Lamb wrote: > Hey Maria, Thank you for looking into this! > Some very quick thoughts: > [...] I tried to improve indentation and other cosmetic things. What do you think of the current state? Regarding Config().html_output -- I put the comment that should

Bug#851359: diffoscope: Improve support for comparing images

Hi Chris! > Could you push this to a branch so we can more easily play with it? :) Pushed to siamezzze/image-visual-comparison . Thanks for your input! Maria signature.asc Description: OpenPGP digital signature

Bug#851359: diffoscope: Improve support for comparing images

Hi, I believe the attached patch provides the requested feature. I would be very grateful for any review or general advice on how to make it better. From 7bdcf310284a11e788fe761f86b1d1dbb51cf968 Mon Sep 17 00:00:00 2001 From: Maria Glukhova <siamez...@gmail.com> Date: Sat, 1 Apr 2017 22

Bug#850758: diffoscope: redundant undecoded AndroidManifest.xml (Binary XML) comparison in APK comparator

exist('apktool', 'zipinfo') +def test_skip_undecoded_android_manifest(differences): +assert not any(difference.source1 == 'original/AndroidManifest.xml' for difference in differences) +assert not any(difference.source2 == 'original/AndroidManifest.xml' for difference in differences) -- 2.11

Bug#850501: rerunning using diffoscope 67-21-gfe7ae15

Chris, вс, 15 янв. 2017 г. в 4:57, Chris Lamb : > As it happens I wrote my own fix before I saw your email > and I have pushed it — what do you think? > > Making APK metadata appear at fixed place surely looks better. IMO, that approach follows the original intent of the

Bug#850501: rerunning using diffoscope 67-21-gfe7ae15

-- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`- > From 67e0ca7b632699f54aec27069efd4e0c547ab708 Mon Sep 17 00:00:00 2001 From: Maria Glukhova <siamez...@gmail.com> Date: Fri, 13 Jan 2017 23:22:10 +0200 Subjec

Bug#850501: rerunning using diffoscope 67-21-gfe7ae15

to run even on toy examples, so adding these tests would extend the time taken by the whole testing process significantly (almost doubles it at my system). Which makes me wonder if that was the reason such tests were not added together with APK comparator in the first place... Maria G

Bug#848049: diffoscope: Add detection of order-only differences in plain text formats

at idea! Maria From 7abab29f878f7fe8e1229995c06a404d5d4e0b40 Mon Sep 17 00:00:00 2001 From: Maria Glukhova <siamez...@gmail.com> Date: Sat, 7 Jan 2017 18:42:19 +0300 Subject: [PATCH] Generic order-line difference for all kind of inputs. --- diffoscope/comparators/text.py | 13 - diffosco