Bug#1003951: DROPBEAR_OPTIONS is silently ignored when missing quotes

2022-02-09 Thread Lee Garrett
On 09/02/2022 16:55, Guilhem Moulin wrote: > Hi Lee, > > On Wed, 19 Jan 2022 at 14:45:47 +0100, Lee Garrett wrote: >> Ah, I wasn't aware that it was directly sourced by a shell. This makes >> much more sense now. > > I see, then I guess it needs to be clarified indeed. Made an attempt at > https

Bug#1003951: DROPBEAR_OPTIONS is silently ignored when missing quotes

2022-02-09 Thread Guilhem Moulin
Hi Lee, On Wed, 19 Jan 2022 at 14:45:47 +0100, Lee Garrett wrote: > Ah, I wasn't aware that it was directly sourced by a shell. This makes > much more sense now. I see, then I guess it needs to be clarified indeed. Made an attempt at https://salsa.debian.org/debian/dropbear/-/commit/06b27a9abfb5

Bug#1003951: DROPBEAR_OPTIONS is silently ignored when missing quotes

2022-01-19 Thread Lee Garrett
On 18/01/2022 16:21, Guilhem Moulin wrote: > Control: severity -1 minor > > Hi, > > On Tue, 18 Jan 2022 at 15:58:43 +0100, Lee Garrett wrote: >> A low-effort fix would be to change the shipped config to >> # DROPBEAR_OPTIONS="" >> to indicate that they're required. Ideally the initramfs hook sh

Bug#1003951: DROPBEAR_OPTIONS is silently ignored when missing quotes

2022-01-18 Thread Guilhem Moulin
Control: severity -1 minor Hi, On Tue, 18 Jan 2022 at 15:58:43 +0100, Lee Garrett wrote: > A low-effort fix would be to change the shipped config to > # DROPBEAR_OPTIONS="" > to indicate that they're required. Ideally the initramfs hook should either > fail > when unquoted, or accept the full pa

Bug#1003951: DROPBEAR_OPTIONS is silently ignored when missing quotes

2022-01-18 Thread Lee Garrett
Package: dropbear-initramfs Version: 2020.81-3 Severity: normal X-Debbugs-Cc: deb...@rocketjump.eu Hi, steps to reproduce: 1) install dropbear-initramfs 2) edit /etc/dropbear-initramfs/config 3) Set DROPBEAR_OPTIONS=-s -j -k -I 180 -c /usr/bin/cryptroot-unlock 4) update-initramfs -k all -u On re