Bug#1010397: Fwd: Bug#1010397: git-annex sync fails in rsync remotes with rsync 3.2.4-1

2022-05-03 Thread Sean Whitton
Hello, On Tue 03 May 2022 at 12:13PM -04, Joey Hess wrote: > Fixed with attached patch. Cool, thanks. Seems like there might be a release soon so I'll hold off patching Debian's version? -- Sean Whitton signature.asc Description: PGP signature

Bug#1010397: Fwd: Bug#1010397: git-annex sync fails in rsync remotes with rsync 3.2.4-1

2022-05-03 Thread Joey Hess
Fixed with attached patch. -- see shy jo From 43701759a32e38613c61de6dc923c24069f435d6 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Tue, 3 May 2022 12:12:25 -0400 Subject: [PATCH] disable shellescape for rsync 3.2.4 rsync 3.2.4 broke backwards-compatability by preventing exposing filenames

Bug#1010397: Fwd: Bug#1010397: git-annex sync fails in rsync remotes with rsync 3.2.4-1

2022-05-03 Thread Joey Hess
> > git-annex enableremote foo shellescape=no I've confirmed that this workaround works. Also, the client's version of rsync is what matters. 3.2.3 client and 3.2.4 server does not have the problem. -- see shy jo signature.asc Description: PGP signature

Bug#1010397: Fwd: Bug#1010397: git-annex sync fails in rsync remotes with rsync 3.2.4-1

2022-05-02 Thread Joey Hess
Sean Whitton wrote: > > git-annex can be configured to not do its own shell escaping when accessing > > a rsync special remote. If your remote is named "foo", you can configure it > > that way as follows: > > > > git-annex enableremote foo shellescape=no > > Thanks for looking into it. Do

Bug#1010397: Fwd: Bug#1010397: git-annex sync fails in rsync remotes with rsync 3.2.4-1

2022-05-02 Thread Sean Whitton
Hello, On Mon 02 May 2022 at 12:51PM -04, Joey Hess wrote: > Joey Hess wrote: >> The rsync command that git-annex runs has a trailing close quote, as >> seen in the first excerpt above. But rsync then complains about the path >> with that close quote removed. >> >> I'm having a hard time not

Bug#1010397: Fwd: Bug#1010397: git-annex sync fails in rsync remotes with rsync 3.2.4-1

2022-05-02 Thread Joey Hess
Joey Hess wrote: > The rsync command that git-annex runs has a trailing close quote, as > seen in the first excerpt above. But rsync then complains about the path > with that close quote removed. > > I'm having a hard time not seeing this as a bug in rsync. # NEWS for rsync 3.2.4 (15 Apr 2022)

Bug#1010397: Fwd: Bug#1010397: git-annex sync fails in rsync remotes with rsync 3.2.4-1

2022-05-02 Thread Joey Hess
> [2022-04-30 13:00:20.39881781] (Utility.Process) process [1635096] read: > rsync ["-e","'ssh' '-S' '../.git/annex/ssh/user@host-key' '-o' > 'ControlMaster=auto' '-o' 'ControlPersist=yes' '-l' 'user' > '-T'","--progress","--inplace", >