Bug#1027734: prometheus-blackbox-exporter: FTBFS: inconsistent test failures

2023-01-04 Thread Daniel Swarbrick
I think I just found the smoking gun, so to speak. In the reproducible builds log, I spotted this: === RUN   TestDNSProtocol     dns_test.go:490: "localhost" doesn't resolve to ::1. --- SKIP: TestDNSProtocol (0.00s) This is due to this check in TestDNSProtocol:     _, err :=

Bug#1027734: prometheus-blackbox-exporter: FTBFS: inconsistent test failures

2023-01-03 Thread Daniel Swarbrick
Studying the test failure with the panic more closely, I think it is due to the inherent raciness caused by tests which spin up http servers, tcp servers etc in goroutines within the same test. I think that what's happening is that the grpc server in the goroutine is not ready in time, so

Bug#1027734: prometheus-blackbox-exporter: FTBFS: inconsistent test failures

2023-01-02 Thread Daniel Swarbrick
In general, the gRPC tests (in a pristine v0.23.0 checkout) seem to be utterly broken. What's more, isolating the tests to just the GRPC tests fails in a completely different way: $ go test ./... ok  github.com/prometheus/blackbox_exporter (cached) ok 

Bug#1027734: prometheus-blackbox-exporter: FTBFS: inconsistent test failures

2023-01-02 Thread Daniel Swarbrick
Hi Mathias, Given that a pristine, upstream checkout fails on that test for the last two releases, I think we will have to just skip the test. See https://github.com/prometheus/blackbox_exporter/issues/969 OpenPGP_signature Description: OpenPGP digital signature

Bug#1027734: prometheus-blackbox-exporter: FTBFS: inconsistent test failures

2023-01-02 Thread Mathias Gibbens
Source: prometheus-blackbox-exporter Version: 0.23.0-1 Severity: serious Justification: FTBFS Tags: bookworm sid ftbfs There appear to be inconsistent test failures in prometheus-blackbox- exporter, specifically TestGRPCTLSConnection and TestNoTLSConnection. I noticed this while rebuilding the