Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock X-Debbugs-Cc: evolut...@packages.debian.org, Jeremy Bicha <jbi...@ubuntu.com> Control: affects -1 + src:evolution
Please unblock package evolution [ Reason ] Due to a change in WebKitGTK, pressing the space key often (but not always) doesn't scroll through the message preview, making it much harder to skim through email quickly. https://gitlab.gnome.org/GNOME/evolution/-/issues/2302 https://lists.osuosl.org/pipermail/evolution-users/2023-March/166704.html Since evolution upstream no longer supports 3.46.x, I asked the GNOME team to cherry-pick the patch and Jeremy Bicha did that, also added translation update patches and asked me to file this unblock request. [ Impact ] Reading email involves more use of the mouse for the evolution users, since scrolling with keyboard no longer works reliably. This could have an impact on users with keyboard preferences or users who aren't able to use a mouse easily or at all. [ Tests ] I manually tested that the updated package fixes the issue and tested the message previewing more generally for both HTML and plain text emails and noticed no regressions or strange behaviour. [ Risks ] The patch is small and direct from upstream. The evolution MUA is part of the default GNOME desktop, so a better user experience is important. [ Checklist ] [x] all changes are documented in the d/changelog [x] I reviewed all changes and I approve them [x] attach debdiff against the package in testing [ Other info ] I have filtered out the translation update patches in the debdiff, because otherwise the debdiff is very large: debdiff evolution_3.46.4-1.dsc evolution_3.46.4-2.dsc > evolution_3.46.4-1_3.46.4-2.debdiff filterdiff -x '*/debian/patches/*-translation*.patch' < evolution_3.46.4-1_3.46.4-2.debdiff > evolution_3.46.4-1_3.46.4-2.filtered.debdiff [ Unblock ] unblock evolution/3.46.4-2 -- bye, pabs https://wiki.debian.org/PaulWise
diff -Nru evolution-3.46.4/debian/changelog evolution-3.46.4/debian/changelog --- evolution-3.46.4/debian/changelog 2023-02-10 20:12:00.000000000 +0800 +++ evolution-3.46.4/debian/changelog 2023-04-12 22:28:02.000000000 +0800 @@ -1,3 +1,10 @@ +evolution (3.46.4-2) unstable; urgency=medium + + * Cherry-pick patch from GNOME 44 to fix spacebar to scroll preview messages + * Cherry-pick translation updates from gnome-43 branch + + -- Jeremy Bicha <jbi...@ubuntu.com> Wed, 12 Apr 2023 10:28:02 -0400 + evolution (3.46.4-1) unstable; urgency=medium * New upstream release diff -Nru evolution-3.46.4/debian/patches/I-2302-Mail-Space-bar-no-longer-scrolls-preview-messages.patch evolution-3.46.4/debian/patches/I-2302-Mail-Space-bar-no-longer-scrolls-preview-messages.patch --- evolution-3.46.4/debian/patches/I-2302-Mail-Space-bar-no-longer-scrolls-preview-messages.patch 1970-01-01 08:00:00.000000000 +0800 +++ evolution-3.46.4/debian/patches/I-2302-Mail-Space-bar-no-longer-scrolls-preview-messages.patch 2023-04-12 22:28:02.000000000 +0800 @@ -0,0 +1,51 @@ +From: Milan Crha <mc...@redhat.com> +Date: Mon, 27 Mar 2023 13:54:02 +0200 +Subject: I#2302 - Mail: Space bar no longer scrolls preview messages + +This started with WebKitGTK 2.40.0. + +Closes https://gitlab.gnome.org/GNOME/evolution/-/issues/2302 + +(cherry picked from commit c3db2b69133baba1264386c1dd38e277338140d5) +--- + data/webkit/e-web-view.js | 13 ++++++++++--- + 1 file changed, 10 insertions(+), 3 deletions(-) + +diff --git a/data/webkit/e-web-view.js b/data/webkit/e-web-view.js +index ab9ca5a..78f7dc3 100644 +--- a/data/webkit/e-web-view.js ++++ b/data/webkit/e-web-view.js +@@ -805,6 +805,9 @@ Evo.MailDisplayUpdateIFramesHeight = function() + + if (scrolly != -1 && document.defaultView.scrollY != scrolly) + document.defaultView.scrollTo(0, scrolly); ++ ++ Evo.mailDisplayResizeContentToPreviewWidth(); ++ Evo.mailDisplayUpdateMagicSpacebarState(); + } + + if (this instanceof Window && this.document) { +@@ -956,7 +959,9 @@ Evo.mailDisplayResizeContentToPreviewWidth = function() + width -= 20; /* 10 + 10 margins of body */ + + traversar.set_iframe_and_body_width(document, width, width, 0); +- window.webkit.messageHandlers.scheduleIFramesHeightUpdate.postMessage(0); ++ ++ if (document.documentElement.clientWidth - 20 > width) ++ window.webkit.messageHandlers.scheduleIFramesHeightUpdate.postMessage(0); + } + + Evo.mailDisplayUpdateMagicSpacebarState = function() +@@ -1284,8 +1289,10 @@ Evo.MailDisplayBindDOM = function(iframe_id, markCitationColor) + Evo.mailDisplayResizeContentToPreviewWidth(); + Evo.mailDisplayUpdateMagicSpacebarState(); + +- document.defaultView.onresize = Evo.mailDisplayResized; +- document.defaultView.onscroll = Evo.mailDisplayUpdateMagicSpacebarState; ++ if (document.body) { ++ document.body.onresize = Evo.mailDisplayResized; ++ document.body.onscroll = Evo.mailDisplayUpdateMagicSpacebarState; ++ } + } + + Evo.MailDisplayShowAttachment = function(element_id, show) diff -Nru evolution-3.46.4/debian/patches/series evolution-3.46.4/debian/patches/series --- evolution-3.46.4/debian/patches/series 2023-02-10 20:12:00.000000000 +0800 +++ evolution-3.46.4/debian/patches/series 2023-04-12 22:28:02.000000000 +0800 @@ -1,2 +1,10 @@ 10_revert_libevolution_avoid-version.patch ubuntu_gettext_domain.patch +I-2302-Mail-Space-bar-no-longer-scrolls-preview-messages.patch +Update-German-translation.patch +Update-German-translation-1.patch +Update-Serbian-translation.patch +Update-Slovak-translation.patch +Update-Hungarian-translation.patch +Update-Russian-translation.patch +Update-Abkhazian-translation.patch
signature.asc
Description: This is a digitally signed message part
