Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: gro...@packages.debian.org
Control: affects -1 + src:groovy

Dear Release Team,

Please consider an unblock for package groovy.

[ Reason ]
Andreas Beckmann discovered a missing dependency on libjsp-api-java,
reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1035850.

libjsp-api-java was a transitive dependency of libservlet3.1-java,
but not of libservlet-api-java, so this missing dependency was
introduced earlier in the bookworm cycle in 2.4.21-3 [1].

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1020429

[ Impact ]
The missing dependency impacts groovy-servlet [2], which probably isn't
widely used (although I have not no data to substantiate that claim).

The libservlet3.1-java transitional package is still present in
bookworm, so a user would have to remove libjsp-api-java during an
upgrade to cause the breakage, but with fewer reverse-dependencies
present in the release, it's conceivable that it could happen.  A new
install that used groovy-servlet would also be broken.

[2] https://groovy-lang.org/servlet.html

[ Tests ]
The updated package passes piuparts.

[ Risks ]
There are no code changes.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]
The debdiff includes differences in the groovy-doc package that are due
to changes in the javadoc toolchain since upload of 2.4.21-7.  I rebuilt
2.4.21-7 against bookworm to verify that the same debdiff is present due
to the rebuild, not due to the added dependency on libjsp-api-java.
That debdiff is also attached for reference.

Thank you for your consideration.  If it's too late for the freeze, this
can be addressed in bookworm-pu.

Thank you,
tony

unblock groovy/2.4.21-8
diff -Nru groovy-2.4.21/debian/changelog groovy-2.4.21/debian/changelog
--- groovy-2.4.21/debian/changelog      2022-10-16 21:02:21.000000000 -0700
+++ groovy-2.4.21/debian/changelog      2023-05-14 20:41:50.000000000 -0700
@@ -1,3 +1,10 @@
+groovy (2.4.21-8) unstable; urgency=medium
+
+  * Team upload.
+  * Add dependency on libjsp-api-java (Closes: #1035850)
+
+ -- tony mancill <tmanc...@debian.org>  Sun, 14 May 2023 20:41:50 -0700
+
 groovy (2.4.21-7) unstable; urgency=medium
 
   * Team upload.
diff -Nru groovy-2.4.21/debian/control groovy-2.4.21/debian/control
--- groovy-2.4.21/debian/control        2022-10-16 21:02:21.000000000 -0700
+++ groovy-2.4.21/debian/control        2023-05-14 20:41:50.000000000 -0700
@@ -51,6 +51,7 @@
  libcommons-logging-java,
  libjansi-java,
  libjline2-java,
+ libjsp-api-java,
  libqdox-java,
  libservlet-api-java,
  libxstream-java,
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .changes but not in first
-----------------------------------------
-rw-r--r--  root/root   /usr/share/doc/groovy/api/legal/ASSEMBLY_EXCEPTION
-rw-r--r--  root/root   /usr/share/doc/groovy/api/legal/jquery.md
-rw-r--r--  root/root   /usr/share/doc/groovy/api/legal/jqueryUI.md
-rw-r--r--  root/root   /usr/share/doc/groovy/api/module-search-index.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/script-dir/jquery-3.6.0.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/script-dir/jquery-ui.min.css
-rw-r--r--  root/root   /usr/share/doc/groovy/api/script-dir/jquery-ui.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/tag-search-index.js

Files in first .changes but not in second
-----------------------------------------
-rw-r--r--  root/root   /usr/share/doc/groovy/api/allclasses.html
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/external/jquery/jquery.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jquery-3.6.0.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jquery-ui.min.css
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jquery-ui.min.js
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/jszip-utils/dist/jszip-utils-ie.js
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/jszip-utils/dist/jszip-utils-ie.min.js
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/jszip-utils/dist/jszip-utils.js
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/jszip-utils/dist/jszip-utils.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jszip/dist/jszip.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jszip/dist/jszip.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/member-search-index.zip
-rw-r--r--  root/root   /usr/share/doc/groovy/api/package-search-index.zip
-rw-r--r--  root/root   /usr/share/doc/groovy/api/type-search-index.zip

Control files of package groovy: lines which differ (wdiff format)
------------------------------------------------------------------
Depends: antlr, default-jre-headless (>= 2:1.7) | java7-runtime-headless, ivy, 
junit4, libasm-java (>= 6.0~alpha-2~), libbsf-java, libcommons-cli-java, 
libcommons-logging-java, libjansi-java, libjline2-java, {+libjsp-api-java,+} 
libqdox-java, libservlet-api-java, libxstream-java
Installed-Size: [-28631-] {+28647+}
Version: [-2.4.21-7-] {+2.4.21-8+}

Control files of package groovy-doc: lines which differ (wdiff format)
----------------------------------------------------------------------
Installed-Size: [-122475-] {+118282+}
Version: [-2.4.21-7-] {+2.4.21-8+}
[The following lists of changes regard files as different if they have
different names, permissions or owners.]

Files in second .deb but not in first
-------------------------------------
-rw-r--r--  root/root   /usr/share/doc/groovy/api/legal/ASSEMBLY_EXCEPTION
-rw-r--r--  root/root   /usr/share/doc/groovy/api/legal/jquery.md
-rw-r--r--  root/root   /usr/share/doc/groovy/api/legal/jqueryUI.md
-rw-r--r--  root/root   /usr/share/doc/groovy/api/module-search-index.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/script-dir/jquery-3.6.0.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/script-dir/jquery-ui.min.css
-rw-r--r--  root/root   /usr/share/doc/groovy/api/script-dir/jquery-ui.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/tag-search-index.js

Files in first .deb but not in second
-------------------------------------
-rw-r--r--  root/root   /usr/share/doc/groovy/api/allclasses.html
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/external/jquery/jquery.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jquery-3.6.0.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jquery-ui.min.css
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jquery-ui.min.js
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/jszip-utils/dist/jszip-utils-ie.js
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/jszip-utils/dist/jszip-utils-ie.min.js
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/jszip-utils/dist/jszip-utils.js
-rw-r--r--  root/root   
/usr/share/doc/groovy/api/jquery/jszip-utils/dist/jszip-utils.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jszip/dist/jszip.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/jquery/jszip/dist/jszip.min.js
-rw-r--r--  root/root   /usr/share/doc/groovy/api/member-search-index.zip
-rw-r--r--  root/root   /usr/share/doc/groovy/api/package-search-index.zip
-rw-r--r--  root/root   /usr/share/doc/groovy/api/type-search-index.zip

Control files: lines which differ (wdiff format)
------------------------------------------------
Installed-Size: [-122475-] {+118282+}

Attachment: signature.asc
Description: PGP signature

Reply via email to