Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: addu...@packages.debian.org, mh+debian-packa...@zugschlus.de
Control: affects -1 + src:adduser

Please unblock package adduser

[ Reason ]

After apt dropped its dependency on adduser, we want to make sure that
all packages requiring adduser in their purge removal maintainer scripts
can still be purged. Instead of adding adduser to the Essential:yes set,
we add the Protected:yes field to make harder to remove it once it is
installed. In the past, apt's dependency on adduser made it hard to
remove. Only five packages in testing still rely on adduser to purge.
More context can be found in #1035654

[ Impact ]

Then it could happen that a user upgrading to bookworm first upgrades
apt, then removes adduser and then is unable to purge packages they had
removed earlier.

[ Tests ]

piuparts correctly concluded that adduser cannot be removed anymore
(without supplying the --allow-remove-essential flag).

[ Risks ]

adduser is a central package but the change is small (see debdiff
below). The mmdebstrap autopkgtest heavily tests the pseudo-essential
set and none of its test cases broke by the addition of the
Protected:yes field.

What did break is the adduser piuparts result. So it is not sufficient
to just reduce the required age for adduser but to also force its
transition despite its piuparts failure. The piuparts failure is an
intended result from this change. The failure shows that the change has
the desired effect. To solve this, changes have to happen on the
piuparts side. See #1035654 for more discussion around this.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing

[ Other info ]

Do not forget to add an additional hint that makes adduser migrate despite its
piuparts failure.

unblock adduser/3.133


diff -Nru adduser-3.132/debian/changelog adduser-3.133/debian/changelog
--- adduser-3.132/debian/changelog      2023-03-08 21:45:42.000000000 +0100
+++ adduser-3.133/debian/changelog      2023-05-16 23:27:12.000000000 +0200
@@ -1,3 +1,10 @@
+adduser (3.133) unstable; urgency=medium
+
+  [ Johannes Schauer Marin Rodrigues ]
+  * mark adduser as Protected:yes. This is a temporary fix for #1035694
+
+ -- Marc Haber <mh+debian-packa...@zugschlus.de>  Tue, 16 May 2023 23:27:12 
+0200
+
 adduser (3.132) unstable; urgency=medium
 
   * This is a translation/documentation only release
diff -Nru adduser-3.132/debian/control adduser-3.133/debian/control
--- adduser-3.132/debian/control        2023-03-08 21:45:42.000000000 +0100
+++ adduser-3.133/debian/control        2023-05-16 23:27:12.000000000 +0200
@@ -15,6 +15,7 @@
 Multi-Arch: foreign
 Pre-Depends: ${misc:Pre-Depends}
 Depends: passwd, ${misc:Depends}
+Protected: yes
 Suggests: liblocale-gettext-perl, perl, cron, quota
 Description: add and remove users and groups
  This package includes the 'adduser' and 'deluser' commands for creating
diff -Nru adduser-3.132/doc/po4a/po/adduser.pot 
adduser-3.133/doc/po4a/po/adduser.pot
--- adduser-3.132/doc/po4a/po/adduser.pot       2023-03-08 21:45:42.000000000 
+0100
+++ adduser-3.133/doc/po4a/po/adduser.pot       2023-05-16 23:27:12.000000000 
+0200
@@ -7,7 +7,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: PACKAGE VERSION\n"
-"POT-Creation-Date: 2023-03-17 12:15+0100\n"
+"POT-Creation-Date: 2023-05-17 12:17+0200\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <l...@li.org>\n"
diff -Nru adduser-3.132/doc/po4a/po/fr.po adduser-3.133/doc/po4a/po/fr.po
--- adduser-3.132/doc/po4a/po/fr.po     2023-03-08 21:45:42.000000000 +0100
+++ adduser-3.133/doc/po4a/po/fr.po     2023-05-16 23:27:12.000000000 +0200
@@ -8,7 +8,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: adduser 3.115\n"
-"POT-Creation-Date: 2023-03-17 12:15+0100\n"
+"POT-Creation-Date: 2023-05-17 12:17+0200\n"
 "PO-Revision-Date: 2023-01-18 08:09+0100\n"
 "Last-Translator: Jean-Paul Guillonneau <guillonneau.jeanp...@free.fr>\n"
 "Language-Team: French <debian-l10n-fre...@lists.debian.org>\n"
diff -Nru adduser-3.132/doc/po4a/po/pt.po adduser-3.133/doc/po4a/po/pt.po
--- adduser-3.132/doc/po4a/po/pt.po     2023-03-08 21:45:42.000000000 +0100
+++ adduser-3.133/doc/po4a/po/pt.po     2023-05-16 23:27:12.000000000 +0200
@@ -5,7 +5,7 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: adduser 3.130\n"
-"POT-Creation-Date: 2023-03-17 12:15+0100\n"
+"POT-Creation-Date: 2023-05-17 12:17+0200\n"
 "PO-Revision-Date: 2023-01-06 23:30+0000\n"
 "Last-Translator: Américo Monteiro <a_monte...@gmx.com>\n"
 "Language-Team: Portuguese <>\n"

Reply via email to