Source: valgrind
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: umask
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The permissions debian.supp differs depending on the umask of the build
environment:

  
https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/valgrind.html

  
-rw-r--r--···0·root·········(0)·root·········(0)·····1136·2022-08-28·10:40:16.000000·./usr/lib/valgrind/debian.supp
  vs.
  
-rw-rw-r--···0·root·········(0)·root·········(0)·····1136·2022-08-28·10:40:16.000000·./usr/lib/valgrind/debian.supp


The attached patch to debian/rules explicitly sets the permissions on
debian.supp after dh_fixperms is run.

Another approach is to remove the exclusion on .supp files from the
dh_fixperms call, though presumeably this was added for a reason and
that might need to be fixed some other way.

According to my local tests, with this patch applied valgrind should
build reproducibly on tests.reproducible-builds.org!

Thanks for maintaining valgrind!

live well,
  vagrant
From 6438e2e60aaf4c84222ea578fc80357c3f5c0d19 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Wed, 28 Jun 2023 15:31:58 -0700
Subject: [PATCH] debian/rules: Explicitly set permissions on debian.supp file.

https://tests.reproducible-builds.org/debian/issues/unstable/different_due_to_umask_issue.html
---
 debian/rules | 1 +
 1 file changed, 1 insertion(+)

diff --git a/debian/rules b/debian/rules
index 1dba244..5c7fcec 100755
--- a/debian/rules
+++ b/debian/rules
@@ -44,6 +44,7 @@ override_dh_install:
 
 override_dh_fixperms:
 	dh_fixperms -X.css -X.html -X.js -X.so -X.supp -X.xml
+	chmod u=rw,go=r debian/valgrind/usr/lib/valgrind/debian.supp
 
 override_dh_installchangelogs:
 	dh_installchangelogs NEWS
-- 
2.39.2

Attachment: signature.asc
Description: PGP signature

Reply via email to