Package: edb-debugger
Version: 1.3.0-2
Severity: normal
Tag: upstream, patch
X-Debbugs-Cc: none, Hilko Bengen <ben...@debian.org>

Dear Maintainer,

edb-debugger fails to build from source against capstone 5 (now in
experimental) due to 2 identifiers (X86_INS_VCVTPD2DQX,
X86_INS_VCVTPD2PSX) that are now missing from header files.

Upstream has fixed this in Git commti
b1bc4d02bfc7ca9c871e7b518aeb795d83e7f88b, see attached patch.

I have verified that this patch does fix the issue.

Cheers,
-Hilko
>From b1bc4d02bfc7ca9c871e7b518aeb795d83e7f88b Mon Sep 17 00:00:00 2001
From: Sam James <s...@cmpct.info>
Date: Tue, 13 Sep 2022 19:51:08 +0100
Subject: [PATCH] Fix build with Capstone 5 (#824)

Capstone 5 drops X86_INS_VCVTPD2DQX and X86_INS_VCVTPD2PSX from
x86.h (happened in https://github.com/capstone-engine/capstone/commit/dd91f03fef5102492352756e2adb5972dd79a70f
but no real explanation).

Given:
1. these instructions had no wiring up;
2. other Capstone consumers have done the same
let's drop them entirely as we have no idea what they are. They don't
appear in any Intel documentation and there's very little reference
to them online at all.

Bug: https://bugs.gentoo.org/843755
Closes: https://github.com/eteran/edb-debugger/issues/823
Signed-off-by: Sam James <s...@gentoo.org>

Signed-off-by: Sam James <s...@gentoo.org>
---
 src/capstone-edb/Instruction.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/capstone-edb/Instruction.cpp b/src/capstone-edb/Instruction.cpp
index 7b2dfc8a..e5fe0f1b 100644
--- a/src/capstone-edb/Instruction.cpp
+++ b/src/capstone-edb/Instruction.cpp
@@ -880,8 +880,6 @@ bool is_SIMD_PD(const Operand &operand) {
 	case X86_INS_CVTPD2PI:
 	case X86_INS_CVTPD2PS:
 	case X86_INS_VCVTPD2PS:
-	case X86_INS_VCVTPD2DQX: // FIXME: what's this?
-	case X86_INS_VCVTPD2PSX: // FIXME: what's this?
 	// case X86_INS_VCVTPD2QQ: // FIXME: Capstone seems to not support it
 	case X86_INS_VCVTPD2UDQ:
 		// case X86_INS_VCVTPD2UQQ: // FIXME: Capstone seems to not support it
-- 
2.39.2

Reply via email to