Package: libharfbuzz-dev

Version: 8.0.0-1

Severity: serious


Hi,


Am 11.07.23 um 19:00 schrieb Debian FTP Masters:
Format: 1.8
Date: Mon, 10 Jul 2023 04:00:02 +0200
Source: harfbuzz
Binary: gir1.2-harfbuzz-0.0 libharfbuzz-bin libharfbuzz-bin-dbgsym libharfbuzz-cairo0 libharfbuzz-cairo0-dbgsym libharfbuzz-dev libharfbuzz-doc libharfbuzz-gobject0 libharfbuzz-gobject0-dbgsym libharfbuzz-icu0 libharfbuzz-icu0-dbgsym libharfbuzz-subset0 libharfbuzz-subset0-dbgsym libharfbuzz0-udeb libharfbuzz0b libharfbuzz0b-dbgsym
Architecture: source amd64 all
Version: 8.0.0-1
Distribution: unstable
Urgency: medium
Maintainer: أحمد المحمودي (Ahmed El-Mahmoudy) <aelmahmo...@users.sourceforge.net> Changed-By: أحمد المحمودي (Ahmed El-Mahmoudy) <aelmahmo...@users.sourceforge.net>
Description:
 gir1.2-harfbuzz-0.0 - OpenType text shaping engine (GObject introspection data)
 libharfbuzz-bin - OpenType text shaping engine (utility)
 libharfbuzz-cairo0 - OpenType text shaping engine Cairo backend
 libharfbuzz-dev - Development files for OpenType text shaping engine
 libharfbuzz-doc - Documentation files for the HarfBuzz library
 libharfbuzz-gobject0 - OpenType text shaping engine ICU backend (GObject library)
 libharfbuzz-icu0 - OpenType text shaping engine ICU backend
 libharfbuzz-subset0 - OpenType text shaping engine (subset library)
 libharfbuzz0-udeb - OpenType text shaping engine (udeb)
 libharfbuzz0b - OpenType text shaping engine (shared library)
Closes: 1030612 1035669 1037687 1039498
Changes:
 harfbuzz (8.0.0-1) unstable; urgency=medium
[...]
   * Add invalid-language-zero.patch to remove typecast from
     HB_LANGUAGE_INVALID definition.
     Thanks to James Addison <j...@jp-hosting.net>James Addison <j...@jp-hosting.net> (Closes: #1035669)

You can't just do that. This changes public API and if at all should be done upstream.

I see it's at https://github.com/harfbuzz/harfbuzz/issues/4263 and this should be done there. Because with that change you cause FTBFS in packages:

https://codesearch.debian.net/search?q=HB_LANGUAGE_INVALID&perpkg=1

While some of it are internal copies I see pango, freetype, libreoffice etc.


libreoffice fails as of now with:

/home/rene/LibreOffice/git/libreoffice-7-6/vcl/source/font/PhysicalFontFace.cxx: In member function 'rtl::OUString vcl::font::PhysicalFontFace::GetName(vcl::font::NameID, const LanguageTag&) const': /home/rene/LibreOffice/git/libreoffice-7-6/vcl/source/font/PhysicalFontFace.cxx:477:42: error: invalid conversion from 'hb_language_t' {aka 'const hb_language_impl_t*'} to 'int' [-fpermissive]   477 |         aHbLang = hb_language_from_string(aLanguage.getStr(), aLanguage.getLength());
      | ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                          |
      |                                          hb_language_t {aka const hb_language_impl_t*} /home/rene/LibreOffice/git/libreoffice-7-6/vcl/source/font/PhysicalFontFace.cxx:480:57: error: invalid conversion from 'int' to 'hb_language_t' {aka 'const hb_language_impl_t*'} [-fpermissive]   480 |     auto nName = hb_ot_name_get_utf16(pHbFace, aNameID, aHbLang, nullptr, nullptr);
      | ^~~~~~~
      |                                                         |
      | int
In file included from /usr/include/harfbuzz/hb-ot-color.h:37,
                 from /usr/include/harfbuzz/hb-ot.h:33,
                 from /home/rene/LibreOffice/git/libreoffice-7-6/vcl/inc/font/PhysicalFontFace.hxx:37,                  from /home/rene/LibreOffice/git/libreoffice-7-6/vcl/inc/sft.hxx:53,                  from /home/rene/LibreOffice/git/libreoffice-7-6/vcl/source/font/PhysicalFontFace.cxx:30: /usr/include/harfbuzz/hb-ot-name.h:150:40: note:   initializing argument 3 of 'unsigned int hb_ot_name_get_utf16(hb_face_t*, hb_ot_name_id_t, hb_language_t, unsigned int*, uint16_t*)'
  150 |                       hb_language_t    language,
      |                       ~~~~~~~~~~~~~~~~~^~~~~~~~
/home/rene/LibreOffice/git/libreoffice-7-6/vcl/source/font/PhysicalFontFace.cxx:484:42: error: invalid conversion from 'hb_language_t' {aka 'const hb_language_impl_t*'} to 'int' [-fpermissive]
  484 |         aHbLang = hb_language_from_string("en", 2);
      |                   ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
      |                                          |
      |                                          hb_language_t {aka const hb_language_impl_t*} /home/rene/LibreOffice/git/libreoffice-7-6/vcl/source/font/PhysicalFontFace.cxx:485:56: error: invalid conversion from 'int' to 'hb_language_t' {aka 'const hb_language_impl_t*'} [-fpermissive]   485 |         nName = hb_ot_name_get_utf16(pHbFace, aNameID, aHbLang, nullptr, nullptr);
      | ^~~~~~~
      |                                                        |
      |                                                        int
/usr/include/harfbuzz/hb-ot-name.h:150:40: note:   initializing argument 3 of 'unsigned int hb_ot_name_get_utf16(hb_face_t*, hb_ot_name_id_t, hb_language_t, unsigned int*, uint16_t*)'
  150 |                       hb_language_t    language,
      |                       ~~~~~~~~~~~~~~~~~^~~~~~~~
/home/rene/LibreOffice/git/libreoffice-7-6/vcl/source/font/PhysicalFontFace.cxx:492:48: error: invalid conversion from 'int' to 'hb_language_t' {aka 'const hb_language_impl_t*'} [-fpermissive]   492 |         hb_ot_name_get_utf16(pHbFace, aNameID, aHbLang, &nName, aBuf.data());
      |                                                ^~~~~~~
      |                                                |
      |                                                int
/usr/include/harfbuzz/hb-ot-name.h:150:40: note:   initializing argument 3 of 'unsigned int hb_ot_name_get_utf16(hb_face_t*, hb_ot_name_id_t, hb_language_t, unsigned int*, uint16_t*)'
  150 |                       hb_language_t    language,
      |                       ~~~~~~~~~~~~~~~~~^~~~~~~~
make[2]: *** [/home/rene/LibreOffice/git/libreoffice-7-6/solenv/gbuild/LinkTarget.mk:334: /home/rene/LibreOffice/git/libreoffice-7-6/workdir/CxxObject/vcl/source/font/PhysicalFontFace.o] Error 1


Please revert.


Regards,


Rene

Reply via email to