Source: kuttypy Version: 2.1.1-2 Severity: normal Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: shell X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Newlines are handled differently depending on which shell implementation is in use, resulting in differences dependent on the build environment: https://tests.reproducible-builds.org/debian/rb-pkg/bullseye/amd64/diffoscope-results/kuttypy.html /usr/share/kuttypy/utilities/build_details.py QT_VERSION·=·'PyQt5'\nPY_VERSION·=·3\n vs. QT_VERSION·=·'PyQt5' PY_VERSION·=·3 The attached patch fixes this in the upstream Makefile by making multiple echo calls rather than relying on the shell-dependent echo handling of "\n". With this patch applied to kutty 2.1.1-4, based on my local tests, kuttypy should build reproducibly on tests.reproducible-builds.org! Thanks for maintaining kuttypy! live well, vagrant
From 25b7eeb2072424c31b21ceea5ae95d583faa5bcd Mon Sep 17 00:00:00 2001 From: Vagrant Cascadian <vagr...@reproducible-builds.org> Date: Tue, 14 Nov 2023 15:34:37 -0800 Subject: [PATCH] Makefile: Split echo call into multiple lines to avoid shell-dependent handling of "\n". https://tests.reproducible-builds.org/debian/issues/unstable/bin_sh_is_bash_issue.html --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 68839f1..4927281 100644 --- a/Makefile +++ b/Makefile @@ -27,7 +27,8 @@ all: recursive_all recursive_all: @echo '?. Using QT Version:' $(QT_VERSION) $(PYUIC) $(PYRCC) $(PYLUPDATE) $(PY_VERSION) - @echo "QT_VERSION = '$(QT_VERSION)'\nPY_VERSION = $(PY_VERSION)\n" > utilities/build_details.py + @echo "QT_VERSION = '$(QT_VERSION)'" > utilities/build_details.py + @echo "PY_VERSION = $(PY_VERSION)" >> utilities/build_details.py for d in $(SUBDIRS); do $(MAKE) PYUIC=$(PYUIC) PYRCC=$(PYRCC) PYLUPDATE=$(PYLUPDATE) PY_VERSION=$(PY_VERSION) -C $$d all; done clean: recursive_clean -- 2.39.2
signature.asc
Description: PGP signature
