Control: tag 1059424 patch (switching to the cloned xfsprogs bug)
On Mon, Dec 25, 2023 at 09:15:59AM +0100, Julian Andres Klode wrote:
> Control: clone -1 -2
> Control: reassign -2 xfsprogs
>
> On Sat, Dec 23, 2023 at 11:11:53PM +0100, Cyril Brulebois wrote:
> > Hi,
> >
> > Anthony Iliopoulos <ail...@suse.com> (2023-10-30):
> > > On Mon, Oct 30, 2023 at 04:19:32PM +0100, Philip Hands wrote:
> > > > Anthony Iliopoulos <ail...@suse.com> writes:
> > > >
> > > > > On Sun, Oct 29, 2023 at 09:02:01PM +0100, Philip Hands wrote:
> > > > ...
> > > > >> error: invalid XFS directory entry.
> > > > ...
> > > > > This issue exists independently of the large extent counter, and it is
> > > > > related to grub commit ef7850c75 ("fs/xfs: Fix issues found while
> > > > > fuzzing the XFS filesystem"). That's actually the issue described in
> > > > > #1051543.
> > > >
> > > > Ah, yes -- good point.
> > > >
> > > > > There's a proposed fix at [1], and it works as expected with that
> > > > > patch
> > > > > applied.
> > > > ...
> > > > > [1]
> > > > > https://lore.kernel.org/grub-devel/20231018030347.36174-1-n...@vault24.org/
> > > >
> > > > I can confirm that having applied both patches:
> > > >
> > > > https://salsa.debian.org/philh/grub2/-/pipelines/596346
> > > >
> > > > it now succeeds at both installing grub, and then booting the system:
> > > >
> > > > https://openqa.debian.net/tests/200503#details
> > >
> > > Thanks for confirming, perhaps then you can add your tested-by in the
> > > respective patches upstream.
> > >
> > > BTW, another handy way to test if this works is via grub-mount.
> >
> > Any chance we could have an updated grub2 package to fix this?
>
> The final grub 2.12 that includes the fix should hit unstable in the
> middle of January. As you might be aware many are busy with family
> stuff and holiday celebrations right now.
>
> As always though it stands to reason that this is a change that should
> (have been) reverted in xfsprogs first until a grub that understands it
> has been released in a stable point release such that you can use a
> stable grub to inspect an XFS filesystem created by a trixie xfsprogs.
>
> It seems the bug has been wrongly reassigned instead of being cloned
> and reassigned, so I'm cloning it back to xfsprogs.
Ah I see I fixed this in Ubuntu's xfsprogs back in November, so patch
attached, I seem to have forgotten to forward this?
--
debian developer - deb.li/jak | jak-linux.org - free software dev
ubuntu core developer i speak de, en
xfsprogs_6.5.0-1_6.5.0-1ubuntu1.diff.gz
Description: application/gzip
