Source: wims
Version: 2:4.27a+dfsg1-3
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lu...@debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc -o canvasdraw.o -g -O2 -Werror=implicit-function-declaration 
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong 
> -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection 
> -Wdate-time -D_FORTIFY_SOURCE=2  -c canvasdraw.c
> canvasdraw.c: In function ‘main’:
> canvasdraw.c:3239:17: error: implicit declaration of function ‘strcasestr’; 
> did you mean ‘strparstr’? [-Werror=implicit-function-declaration]
>  3239 |             if( strcasestr(temp,"NOCONTROLS") ){
>       |                 ^~~~~~~~~~
>       |                 strparstr
> canvasdraw.c: In function ‘getMML’:
> canvasdraw.c:6341:3: warning: ignoring return value of ‘fgets’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>  6341 |   fgets(buffer, MAX_BUFFER, stream);
>       |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> canvasdraw.c: In function ‘getSVGMOL’:
> canvasdraw.c:6383:5: warning: ignoring return value of ‘read’ declared with 
> attribute ‘warn_unused_result’ [-Wunused-result]
>  6383 |     read(link[0],buffer, 1+sizeof(buffer));
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> canvasdraw.c:6383:5: warning: ‘read’ writing 65538 bytes into a region of 
> size 65537 overflows the destination [-Wstringop-overflow=]
>  6383 |     read(link[0],buffer, 1+sizeof(buffer));
>       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> canvasdraw.c:6367:8: note: destination object ‘buffer’ of size 65537
>  6367 |   char buffer[MAX_BUFFER+1];
>       |        ^~~~~~
> In file included from /usr/include/unistd.h:1214,
>                  from ../../Lib/../includes.h:27,
>                  from ../../Lib/libwims.h:21,
>                  from canvasdraw.h:2,
>                  from canvasdraw.c:12:
> /usr/include/x86_64-linux-gnu/bits/unistd.h:36:1: note: in a call to function 
> ‘read’ declared with attribute ‘access (write_only, 2, 3)’
>    36 | read (int __fd, void *__buf, size_t __nbytes)
>       | ^~~~
> In file included from /usr/include/features.h:490,
>                  from /usr/include/assert.h:35,
>                  from canvasdraw.h:1:
> In function ‘read’,
>     inlined from ‘getSVGMOL’ at canvasdraw.c:6383:5:
> /usr/include/x86_64-linux-gnu/bits/unistd.h:38:10: warning: call to 
> ‘__read_chk_warn’ declared with attribute warning: read called with bigger 
> length than size of the destination buffer [-Wattribute-warning]
>    38 |   return __glibc_fortify (read, __nbytes, sizeof (char),
>       |          ^~~~~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[5]: *** [Makefile:22: canvasdraw.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/wims_4.27a+dfsg1-3_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lu...@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.

Reply via email to