Package: spamassassin
Version: 4.0.1~pre1-1
Severity: normal
Tags: patch

In this following commit systemd timers were introduced.

    
https://salsa.debian.org/debian/spamassassin/-/commit/f2753c72e8052f03e60c5a5532ccb4e1080b6406#b323bf39a23be9c27fd25690d333c4e9dbcddec7

In this following commit the test condition on line 24 was corrected.
Because multiple other programs now make use of that directory too and
the original test became insufficient.  This change implements the
corrected test condition.

    
https://salsa.debian.org/debian/spamassassin/-/commit/211e60e8bfec56f31e4fe54100438a6a899953fa

That was a good change.  But that fix and improvement was not applied
to line 34 a few lines further down which continued to have only the
previous condition test.

It would be most appreciated if the same change were applied to the
test on line 34 as well so that it would have the same behavior.  I am
certain that not applying the same fix there was simply an accidental
oversight.  To be explicit here is the proposed patch.

    -if [ -d /run/systemd ] && [ ! -e /etc/spamassassin/skip-timer-conversion 
]; then
    +if [ -d /run/systemd/system ] && [ ! -e 
/etc/spamassassin/skip-timer-conversion ]; then

I also wanted to say thank you and that I appreciate having the
skip-timer-conversion option available.  That's what I have been using
on my main system and that is why I have not been seeing this problem
on those systems.  But recently when setting up an additional system I
experienced the problem there with a fresh installation of the
spamassassin package.

Thank you for maintaining spamassassin!

Bob



-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 6.4.0-4-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=C, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: sysvinit (via /sbin/init)

Reply via email to