Bug#266052: jack: doesn't support UTF8 freedb entries

2005-06-20 Thread Martin Michlmayr
tags 266052 + patch pending thanks Arne, Here is a full patch for UTF-8 support, based on an initial bug report and patch by Peter Maydell; it has been heavily modified and extended by me. MP3 support was added by Chris Vanden Berghe; it's now using the eyeD3 bindings for MP3 since they are bett

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-28 Thread Martin Michlmayr
* Chris Vanden Berghe <[EMAIL PROTECTED]> [2005-04-27 02:57]: > I tried porting jack from python-id3lib to python-eyed3, which is also > an ID3 library but still developed (and with utf8 support). ... * Chris Vanden Berghe <[EMAIL PROTECTED]> [2005-04-26 13:37]: > I could probably fix this quite e

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-26 Thread Chris Vanden Berghe
Martin, I tried porting jack from python-id3lib to python-eyed3, which is also an ID3 library but still developed (and with utf8 support). Would you be willing to take a quick look at the attached patch as this is my first experience with Python and jack? In particular, I don't understand the ge

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-26 Thread Chris Vanden Berghe
Thanks! I looked myself a bit already... changing the byte exactly before every ID3 string from 00 to 03 results in a correct UTF8 ID3v2 tag. This is good news, since this means that everything except for the setting of the encoding itself works fine... I could probably fix this quite easily by

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-26 Thread Martin Michlmayr
* Chris Vanden Berghe <[EMAIL PROTECTED]> [2005-04-26 01:39]: > Argh, forgot to look at the ID3(v2) tag... the filenames are correct, > but the UTF8 characters in the ID3 tag are interpreted as two seperate > characters. I guess that the encoding of the ID3 content should also be > set to UTF8. (

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-25 Thread Chris Vanden Berghe
Argh, forgot to look at the ID3(v2) tag... the filenames are correct, but the UTF8 characters in the ID3 tag are interpreted as two seperate characters. I guess that the encoding of the ID3 content should also be set to UTF8. (as in http://www.id3.org/id3v2.4.0-structure.txt) I'm not sure if the

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-24 Thread Chris Vanden Berghe
Thanks, that did the trick! I really hope these patches go into the standard jack deb package... Cheers, Chris. --- Martin Michlmayr wrote: > * Chris Vanden Berghe <[EMAIL PROTECTED]> [2005-04-23 12:00]: > >>I've tried it with MP3's and got the following error message. I looked >>very quickly

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-23 Thread Martin Michlmayr
* Chris Vanden Berghe <[EMAIL PROTECTED]> [2005-04-23 12:00]: > I've tried it with MP3's and got the following error message. I looked > very quickly in the code, but didn't immediately found the problem. If > v2tag.album = a_title > pyid3lib.ID3Error: 'album' attribute must be string Yeah,

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-23 Thread Chris Vanden Berghe
Martin, Thanks for making your patch public... it's really useful! I've tried it with MP3's and got the following error message. I looked very quickly in the code, but didn't immediately found the problem. If you have an idea what could be the problem, then please let me know. Otherwise I'll ta

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-22 Thread Martin Michlmayr
Attached below is a patch to add UTF-8 support to jack 3.1.1. I've tested this in a Latin1 and UTF-8 locale with OGG; MP3 hasn't been tested. -- Martin Michlmayr http://www.cyrius.com/ diff -urN site-packages.orig/jack_config.py site-packages/jack_config.py --- site-packages.orig/jack_config.py

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-14 Thread pmaydell
Martin Michlmayr wrote: >* tbm <[EMAIL PROTECTED]> [2005-04-15 03:43]: >> > There's a lot that needs to be done here to make this proper >> > production quality. >> >> Do you know what else is needed? > >Well, I guess one problem is that the curses library shipped with jack >doesn't seem to handle

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-14 Thread Martin Michlmayr
* tbm <[EMAIL PROTECTED]> [2005-04-15 03:43]: > > There's a lot that needs to be done here to make this proper > > production quality. > > Do you know what else is needed? Well, I guess one problem is that the curses library shipped with jack doesn't seem to handle UTF-8 100%, but otoh the curses

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-04-14 Thread Martin Michlmayr
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> [2005-03-11 06:10]: > There's a lot that needs to be done here to make this proper > production quality. Do you know what else is needed? I briefly tried your patch and got it more or less working. I had to manually set charset to utf-8 in ~/.jack3rc becau

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-03-10 Thread pmaydell
Michael Banck wrote: >On Mon, Aug 16, 2004 at 03:15:52PM +0100, [EMAIL PROTECTED] wrote: >> jack doesn't cope properly with CDs whose track titles have non >> ISO-8859-1 characters in them. >> I made a quick hack change to my copy of jack so it used protocol >> level 6, and it seems to work OK >s

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-03-10 Thread Michael Banck
Hi, sorry I forgot to reply. I talked to upstream about this, and he said he'd address this once he got time (which is pretty rare) On Mon, Aug 16, 2004 at 03:15:52PM +0100, [EMAIL PROTECTED] wrote: > jack doesn't cope properly with CDs whose track titles have non > ISO-8859-1 characters in them.

Bug#266052: jack: doesn't support UTF8 freedb entries

2005-03-05 Thread Chris Vanden Berghe
Package: jack Version: 3.1.1-1 Followup-For: Bug #266052 As far as I can see, the problem described in bug 266052 is still present in the current version of jack. Would it be possible for the maintainer to patch jack in a similar way as the submitter of this bug has done? The current situatio