Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-03-01 Thread Gerrit Pape
On Mon, Feb 28, 2005 at 09:01:28PM +1100, Herbert Xu wrote: Please give this one a go and see if you can break it again :) Didn't work this time ;-), this one does well in all my tests. See below for the patch against version 0.5.2 I plan to apply to the Debian package to fix this bug. Thanks,

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-03-01 Thread Herbert Xu
On Tue, Mar 01, 2005 at 08:38:22PM +, Gerrit Pape wrote: Didn't work this time ;-), this one does well in all my tests. See below for the patch against version 0.5.2 I plan to apply to the Debian package to fix this bug. Looks good. Thanks. -- Visit Openswan at

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-28 Thread Herbert Xu
On Sun, Feb 27, 2005 at 08:18:09PM +, Gerrit Pape wrote: Hi Herbert, this does fine with the subshell. Unfortunately I stumbled across another problem with these patches as well as with the previous single one. After the EXEVAL exception is raised in the or list, dash stops processing

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-27 Thread Gerrit Pape
On Fri, Feb 25, 2005 at 10:11:54PM +1100, Herbert Xu wrote: On Fri, Feb 25, 2005 at 09:09:11PM +1100, herbert wrote: Good catch. We need to check whether the EXEVAL is thrown by a subshell and if so relay it to the top. Please try these two patches instead. We need one more patch.

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-25 Thread Herbert Xu
On Thu, Feb 24, 2005 at 09:07:50PM +, Gerrit Pape wrote: A subshell forked in eval or a dot file within an or list does not return, causing the parent shell to block: Good catch. We need to check whether the EXEVAL is thrown by a subshell and if so relay it to the top. Please try these

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-25 Thread Herbert Xu
On Fri, Feb 25, 2005 at 09:09:11PM +1100, herbert wrote: Good catch. We need to check whether the EXEVAL is thrown by a subshell and if so relay it to the top. Please try these two patches instead. We need one more patch. EXEVAL should not modify the exit status. -- Visit Openswan at

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-24 Thread Gerrit Pape
On Wed, Feb 23, 2005 at 10:33:14PM +1100, Herbert Xu wrote: I'd like to present a different fix though. I'd prefer to keep the set -e behaviour within the string being evaluated. In other words, set -e if eval 'false; echo hi'; then :; fi should not execute the echo statement. Please

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-23 Thread Herbert Xu
On Tue, Feb 22, 2005 at 08:10:43PM +, Gerrit Pape wrote: Hi Herbert, it turns out bug #268944 'sh: wrong errexit with eval' breaks at least one other package's postinst, raising its severity. See I agree with the assessment. below for a patch that I think fixes the problem. I'd like

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-22 Thread Marco Nenciarini
On Tue, Feb 22, 2005 at 01:43:17AM +0100, Jeroen van Wolffelaar wrote: On Thu, Nov 25, 2004 at 10:42:13AM +0100, Marco Nenciarini wrote: I reported same problem installing phpbb2-conf-mysql I tried to remove the whole package and mysql and reinstall it, with no success. The db was

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-22 Thread Jeroen van Wolffelaar
severity 276964 minor tags 276964 - moreinfo unreproducible reassign 276964 dash,wwwconfig-common retitle 276964 wwwconfig-common's mysql-ifnot-exec.sh aborts with dash thanks On Tue, Feb 22, 2005 at 01:05:33PM +0100, Marco Nenciarini wrote: On Tue, Feb 22, 2005 at 01:43:17AM +0100, Jeroen van

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-22 Thread Jeroen van Wolffelaar
reassign 276964 dash retitle 276964 set -e; if eval ...; then ...; else ...; fi exits if false, rather than executing 'else' severity 276964 critical severity 268944 critical forwarded 276964 upstream merge 268944 276964 submitter 276964 ! thanks On Tue, Feb 22, 2005 at 01:43:17AM +0100, Jeroen

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-22 Thread Gerrit Pape
tags 276964 + patch quit On Tue, Feb 22, 2005 at 02:05:23PM +0100, Jeroen van Wolffelaar wrote: On Tue, Feb 22, 2005 at 01:43:17AM +0100, Jeroen van Wolffelaar wrote: | elif ! eval $mysqlcmd -f $dbname -e \$statement\ /dev/null 21 ; then | log=${log}Executing command to mysql. |

Bug#276964: phpbb2-conf-mysql: I reported same problem

2005-02-21 Thread Jeroen van Wolffelaar
On Thu, Nov 25, 2004 at 10:42:13AM +0100, Marco Nenciarini wrote: I reported same problem installing phpbb2-conf-mysql I tried to remove the whole package and mysql and reinstall it, with no success. The db was created, but it remains empty. I've attached the output of postinst called with