Bug#284274: Re: Bug#284274: Patch for the hardlink replacement bug request

2013-03-10 Thread Paul Seelig
Hi, for the time being, it would probably be much more reasonable to limit that function to the current local filesystem only, instead of trying to crack a nut with a sledgehammer. Finding duplicates over filesystems should be considered being a special use case which could/should be handled sepa

Bug#284274: Patch for the hardlink replacement bug request

2012-10-21 Thread Albert Cahalan
Getting rid of the only race condition that matters: Create the link first, with an unused name. Instead of relying on the return code, which may be wrong for NFS, call stat to find out if you created the file. Rename the link over top of the file it is intended to replace. In case that fails, rem

Bug#284274: Patch for the hardlink replacement bug request

2012-06-20 Thread Sandro Tosi
Hi, On Thu, Jun 21, 2012 at 2:24 AM, Javier Fernandez-Sanguino wrote: > Maybe you did not understand the proposed algorithm, no copies are > involved, just file renaiming. Ah Indeed, I didn't understand that - that's much better than what I had understood on the first reply (delete + try to hard

Bug#284274: Patch for the hardlink replacement bug request

2012-06-20 Thread Javier Fernandez-Sanguino
Hi there, Maybe you did not understand the proposed algorithm, no copies are involved, just file renaiming. I was thinking more in the lines of doing this: IF A and B are the same THEN - move B to a temporary file (predefined name or random name, as long as the file does not exist) - create a har

Bug#284274: Patch for the hardlink replacement bug request

2012-06-20 Thread Sandro Tosi
On Mon, Jun 18, 2012 at 7:56 PM, Javier Fernández-Sanguino Peña wrote: > It might not be too difficult to introduce a check in the patch that tries > the hard link and, if it fails, it restores the file and complains. I'll see > what I can do. Having a working -L option would be awesome! I think

Bug#284274: Patch for the hardlink replacement bug request

2012-06-18 Thread Javier Fernández-Sanguino Peña
On Sun, Jun 17, 2012 at 09:40:49PM +0200, Sandro Tosi wrote: > On Fri, Jul 31, 2009 at 12:56 AM, Javier Fernández-Sanguino Peña > wrote: > > > > tags 284274 patch > > thanks > > > > Attached is a patch to the program sources (through the use of a dpatch > > patch > > in the Debian package) that a

Bug#284274: Patch for the hardlink replacement bug request

2012-06-17 Thread Sandro Tosi
Resending to the bug too, now that the bugs is reopened. On Sun, Jun 17, 2012 at 9:40 PM, Sandro Tosi wrote: > unarchive 284274 > reopen 284274 > thanks > > On Fri, Jul 31, 2009 at 12:56 AM, Javier Fernández-Sanguino Peña > wrote: >> >> tags 284274 patch >> thanks >> >> Attached is a patch to th

Bug#284274: Patch for the hardlink replacement bug request

2009-07-31 Thread Sandro Tosi
Hi Javier, 2009/7/31 Javier Fernández-Sanguino Peña : > > tags 284274 patch > thanks > > Attached is a patch to the program sources (through the use of a dpatch patch > in the Debian package) that adds a new -L / --linkhard option to fdupes. This > option will replace all duplicate files with hard

Bug#284274: Patch for the hardlink replacement bug request

2009-07-30 Thread Javier Fernández-Sanguino Peña
tags 284274 patch thanks Attached is a patch to the program sources (through the use of a dpatch patch in the Debian package) that adds a new -L / --linkhard option to fdupes. This option will replace all duplicate files with hardlinks which is useful in order to reduce space. It has been tested