Bug#342948: Patch [was: Re: Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars]

2006-01-13 Thread Martin Pitt
Hi again! Bdale Garbee [2006-01-11 22:04 -0700]: On Wed, 2006-01-11 at 16:38 +0100, Martin Schulze wrote: Bdale, what do you think? I'm ok with it. Does someone have a patch representing this behavior? I now finished the first version of the patch [1]. Please note that I tried to keep

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2006-01-12 Thread Bdale Garbee
On Wed, 2006-01-11 at 16:38 +0100, Martin Schulze wrote: Bdale, what do you think? I'm ok with it. Does someone have a patch representing this behavior? What's the current implementation in version 1.6.8p12-1 anyway1? What upstream shipped for p12, plus env_reset added to sudoers when

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2006-01-12 Thread Martin Pitt
Hi! Bdale Garbee [2006-01-11 22:04 -0700]: On Wed, 2006-01-11 at 16:38 +0100, Martin Schulze wrote: Bdale, what do you think? I'm ok with it. Does someone have a patch representing this behavior? No, but if we all agree, I'll cook one. I'll report back. Martin -- Martin Pitt

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2006-01-11 Thread Martin Schulze
Martin Pitt wrote: I still think that the current sid version is broken: it does nothing to fix this vulnerability for similar cases (JAVA_TOOL_OPTIONS, PYTHONHOME, RUBYLIB, etc. pp) in existing installations and upgrades from stable, and for new installations it disables environment passing

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2006-01-05 Thread Martin Pitt
Hi Bdale, hi Joey! I still think that the current sid version is broken: it does nothing to fix this vulnerability for similar cases (JAVA_TOOL_OPTIONS, PYTHONHOME, RUBYLIB, etc. pp) in existing installations and upgrades from stable, and for new installations it disables environment passing

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2006-01-05 Thread Andres Salomon
I find myself agreeing with Martin here; this isn't really optimal for sid, as it doesn't take into account existing installations and upgrades. Even at the risk of changing behavior, I think this is an important enough fix to warrant making env_reset the default behavior. Differentiating

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2005-12-29 Thread Martin Schulze
Bdale Garbee wrote: On Thu, 2005-12-22 at 09:15 +0100, Martin Schulze wrote: It's a box of pandora. You can hardly hit all variables. Bdale, what's your opinion? One of the workarounds suggested by upstream in the p12 release announcement is: Alternately, the administrator

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2005-12-28 Thread Bdale Garbee
On Thu, 2005-12-22 at 09:15 +0100, Martin Schulze wrote: It's a box of pandora. You can hardly hit all variables. Bdale, what's your opinion? One of the workarounds suggested by upstream in the p12 release announcement is: Alternately, the administrator can add a line to the top of

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2005-12-22 Thread Martin Schulze
Moritz Muehlenhoff wrote: Martin Schulze wrote: The attached patch only uses the variables listed in env_check to be passed to the setuid environment. This will preserve language settings by default, but nothing more. What do people think about this? The patch itself looks fine for

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2005-12-21 Thread Moritz Muehlenhoff
Martin Schulze wrote: The attached patch only uses the variables listed in env_check to be passed to the setuid environment. This will preserve language settings by default, but nothing more. What do people think about this? The patch itself looks fine for sid (although HOME, LOGNAME,

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2005-12-12 Thread Martin Schulze
Moritz Muehlenhoff wrote: Package: sudo Severity: important Tags: security Quoting from http://www.sudo.ws/sudo/alerts/perl_env.html : | The PERL5LIB and PERLLIB environment variables can be used to provide a list of | directories in which to look for perl library files before the system

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2005-12-12 Thread Martin Schulze
Martin Schulze wrote: It's been fixed upstream in 1.6.8p12. This is true, but it becomes rediculous. Finally allocated some time to develop a minimal patch. The attached patch only uses the variables listed in env_check to be passed to the setuid environment. This will preserve language

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2005-12-12 Thread Martin Schulze
Martin Schulze wrote: Martin Schulze wrote: It's been fixed upstream in 1.6.8p12. This is true, but it becomes rediculous. Finally allocated some time to develop a minimal patch. The attached patch only uses the variables listed in env_check to be passed to the setuid environment.

Bug#342948: CVE-2005-4158: Insecure handling of PERLLIB PERL5LIB PERL5OPT environment vars

2005-12-11 Thread Moritz Muehlenhoff
Package: sudo Severity: important Tags: security Quoting from http://www.sudo.ws/sudo/alerts/perl_env.html : | The PERL5LIB and PERLLIB environment variables can be used to provide a list of | directories in which to look for perl library files before the system directories are | searched. It