Bug#393283: RFC: change chown *not* to look up numeric user/group names

2007-01-20 Thread Jim Meyering
Paul Eggert [EMAIL PROTECTED] wrote: Jim Meyering [EMAIL PROTECTED] writes: * lib/userspec.c (parse_with_separator): If a user or group string starts with +, skip the corresponding name-to-ID look-up, since such a look-up must fail: user and group names may not include +. The

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2007-01-20 Thread Paul Eggert
Jim Meyering [EMAIL PROTECTED] writes: * lib/userspec.c (parse_with_separator): If a user or group string starts with +, skip the corresponding name-to-ID look-up, since such a look-up must fail: user and group names may not include +. The usage is portable to OpenBSD 3.9

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2007-01-19 Thread Jim Meyering
Jim Meyering [EMAIL PROTECTED] wrote: ... I propose to change GNU chown to perform that look-up of an all-numeric user or group string only when the POSIXLY_CORRECT envvar is set. Otherwise, (when POSIXLY_CORRECT is not set and a name is a valid user ID or group ID), chown would use the value

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2006-10-20 Thread Pádraig Brady
Andreas Schwab wrote: Michael Stone [EMAIL PROTECTED] writes: I guess it's a case of numeric usernames are stupid vs will it break something. I don't see much reason *not* to be posix compliant in this case, though. Perhaps there should just be an option to force the numeric name to be

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2006-10-20 Thread Pádraig Brady
Jim Meyering wrote: Do you know if they still do that? Just checked and yes they do. Also it was mentioned on a local list that mobile phone companies all over the world that use Linux as a messaging platform, use the mobile number as the username. If numeric user names are still common

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2006-10-20 Thread Michael Stone
On Thu, Oct 19, 2006 at 11:29:23AM +0200, Jim Meyering wrote: My motivation for making this change is mainly security. The paranoid user of chown (usually root) should not have to imagine that a numeric user name argument like 1000 might be interpreted as a name and mapped to 0. Can anyone

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2006-10-20 Thread Andreas Schwab
Michael Stone [EMAIL PROTECTED] writes: I guess it's a case of numeric usernames are stupid vs will it break something. I don't see much reason *not* to be posix compliant in this case, though. Perhaps there should just be an option to force the numeric name to be interpreted as a number.

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2006-10-20 Thread Bob Proulx
Pádraig Brady wrote: Jim Meyering wrote: Can anyone present a case for *not* making this change? This is also controlled by /etc/nsswitch.conf. A typical configuration would always search local files first and then search network configuration after failing to get a local answer. (In the

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2006-10-20 Thread Helge Hafting
Bob Proulx wrote: I strongly believe that not having a root entry in the local password file is a wrong configuration. I strongly believe that configuring a network override of local files is a wrong configuration. At boot time when the network is not yet configured the local file will be

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2006-10-19 Thread Pádraig Brady
Jim Meyering wrote: In http://bugs.debian.org/393283, Helge Hafting objected to the fact that GNU chown performs a DB look-up for a numeric user name, e.g., in chown 0 FILE. chown does this deliberately, in case 0 is an actual user *name*, that is associated potentially, with some numeric

Bug#393283: RFC: change chown *not* to look up numeric user/group names

2006-10-19 Thread Jim Meyering
In http://bugs.debian.org/393283, Helge Hafting objected to the fact that GNU chown performs a DB look-up for a numeric user name, e.g., in chown 0 FILE. chown does this deliberately, in case 0 is an actual user *name*, that is associated potentially, with some numeric user ID. That is the