Package: libsql-abstract-perl Version: 1.21-2 Severity: minor Tags: patch When rebuilding libclass-dbi-abstractsearch-perl these warnings are produced:
/usr/bin/make -C . OPTIMIZE="-g -Wall -O2" test make[1]: Entering directory `/home/bart/src/libclass-dbi-abstractsearch-perl/libclass-dbi-abstractsearch-perl-0.07' PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00_compile.....ok t/01_abstract....Use of uninitialized value in string eq at /usr/share/perl5/SQL/Abstract.pm line 198. Use of uninitialized value in concatenation (.) or string at /usr/share/perl5/SQL/Abstract.pm line 201. ok All tests successful. The attached patch reduces the output to this: /usr/bin/make -C . OPTIMIZE="-g -Wall -O2" test make[1]: Entering directory `/home/bart/src/libclass-dbi-abstractsearch-perl/libclass-dbi-abstractsearch-perl-0.07' PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00_compile.....ok t/01_abstract....ok All tests successful.
diff -ruN orig/libsql-abstract-perl-1.21/lib/SQL/Abstract.pm libsql-abstract-perl-1.21/lib/SQL/Abstract.pm --- orig/libsql-abstract-perl-1.21/lib/SQL/Abstract.pm 2006-03-08 02:28:09.000000000 +0100 +++ libsql-abstract-perl-1.21/lib/SQL/Abstract.pm 2006-11-19 09:07:51.000000000 +0100 @@ -196,9 +196,9 @@ my $label = shift; return $label - if $label eq '*'; + if defined($label) && $label eq '*'; - return $self->{quote_char} . $label . $self->{quote_char} + return $self->{quote_char} . (defined($label)?$label:'') . $self->{quote_char} if !defined $self->{name_sep}; return join $self->{name_sep},
signature.asc
Description: This is a digitally signed message part