Bug#439790: Assumes MSF offset is always 150

2007-09-05 Thread Eric Gillespie
Martin Michlmayr [EMAIL PROTECTED] writes: * Martin Michlmayr [EMAIL PROTECTED] [2007-08-29 12:09]: In order words, INDEX 00 00:00:00 INDEX 01 00:00:32 is printed for the first track. So I'd propose: Thanks, Martin, and sorry for not responding earlier. This looks good to

Bug#439790: Assumes MSF offset is always 150

2007-08-29 Thread Martin Michlmayr
* Eric Gillespie [EMAIL PROTECTED] [2007-08-27 14:31]: I suppose this patch should fix it? Not tested, but I think it matches your original patch. I'm not sure why you removed the first TRACK 01 AUDIO line, but neither am I sure why it's there. I removed it but at the same time I decreased

Bug#439790: Assumes MSF offset is always 150

2007-08-29 Thread Martin Michlmayr
* Martin Michlmayr [EMAIL PROTECTED] [2007-08-29 12:09]: In order words, INDEX 00 00:00:00 INDEX 01 00:00:32 is printed for the first track. So I'd propose: Index: fa-rip === --- fa-rip (revision 2155) +++ fa-rip

Bug#439790: Assumes MSF offset is always 150

2007-08-27 Thread Martin Michlmayr
Package: mkcue Version: 1-2 Severity: important As a comment in mkcue.cc says, mkcue assumes that the first song always starts after 150 frames. However, this assumption is wrong. As I understand it (from investigating this issue as it relates to jack, see #319901), every CD has 150 frames that

Bug#439790: Assumes MSF offset is always 150

2007-08-27 Thread Eric Gillespie
Martin Michlmayr [EMAIL PROTECTED] writes: Package: mkcue Version: 1-2 Severity: important As a comment in mkcue.cc says, mkcue assumes that the first song always starts after 150 frames. However, this assumption is wrong. As you might guess from that comment, I'm no expert in this area,

Bug#439790: Assumes MSF offset is always 150

2007-08-27 Thread Martin Michlmayr
* Eric Gillespie [EMAIL PROTECTED] [2007-08-27 13:57]: As you might guess from that comment, I'm no expert in this area, and am not surprised I got it wrong. I use libmusicbrainz to make cue sheets now, and have abandoned mkcue. It's a dead package, unless someone else wants to take it up.

Bug#439790: Assumes MSF offset is always 150

2007-08-27 Thread Eric Gillespie
Martin Michlmayr [EMAIL PROTECTED] writes: Out of interest, how does one use libmusicbrainz for cue sheets and does it get it right? I looked at your flac-archive script, and while it uses some libmusicbrainz libraries, the cue sheet generation is quite similar to mkcue (and has the same