Package: pengupop
Version: 2.2.4-1+b1
Severity: normal

Hi,

the debian/copyright file of pengupop only says:

  You are free to distribute this software under the terms of
  the GNU General Public License, version 2 or later.
  On Debian systems, the complete text of the GNU General Public
  License can be found in /usr/share/common-licenses/GPL file.

The file bin2c.c has the following license header, though:

/*
 *  Copyright (c) 2005  adresd
 *  Copyright (c) 2005  Marcus R. Brown
 *  Copyright (c) 2005  James Forshaw
 *  Copyright (c) 2005  John Kelley
 *  Copyright (c) 2005  Jesper Svennevid
 *  All rights reserved.
 *  Redistribution and use in source and binary forms, with or without
 *  modification, are permitted provided that the following conditions
 *  are met:
 *  1. Redistributions of source code must retain the above copyright
 *     notice, this list of conditions and the following disclaimer.
 *  2. Redistributions in binary form must reproduce the above copyright
 *     notice, this list of conditions and the following disclaimer in the
 *     documentation and/or other materials provided with the distribution.
 *  3. The names of the authors may not be used to endorse or promote products
 *     derived from this software without specific prior written permission.
 *  THIS SOFTWARE IS PROVIDED BY THE AUTHORS ``AS IS'' AND ANY EXPRESS OR
 *  IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
 *  OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
 *  IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY DIRECT, INDIRECT,
 *  INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
 *  NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 *  DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 *  THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 *  (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
 *  THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */

Please also add that to the copyright file. There are also some source
files which don't have any license header, please ask upstream to
add a header for every file.

It would be nice if upstream would also state the license of the data
files explicitly (images, sounds, etc).

Also debian/copyright should mention all the copyright owners and
the respective years, e.g.

 *  Copyright (c) 2005  adresd
 *  Copyright (c) 2005  Marcus R. Brown
 *  Copyright (c) 2005  James Forshaw
 *  Copyright (c) 2005  John Kelley
 *  Copyright (c) 2005  Jesper Svennevid
etc.


Thanks, Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

Attachment: signature.asc
Description: Digital signature

Reply via email to