Package: git-buildpackage
Version: 0.4.9
Severity: normal
Tags: patch

        [EMAIL PROTECTED]:~/debsrc$ apt-get source -d git-core
        Reading package lists... Done
        Building dependency tree... Done
        Need to get 1779kB of source archives.
        Get:1 http://ftp.de.debian.org sid/main git-core 1:1.5.3.7-1 (dsc) 
[795B]
        Get:2 http://ftp.de.debian.org sid/main git-core 1:1.5.3.7-1 (tar) 
[1613kB]
        Get:3 http://ftp.de.debian.org sid/main git-core 1:1.5.3.7-1 (diff) 
[166kB]    
        Fetched 1779kB in 8s (204kB/s)                                          
       
        Download complete and in download only mode

        [EMAIL PROTECTED]:~/debsrc$ git-import-dsc git-core_1.5.3.7-1.dsc 
        Upstream version: 1.5.3.7
        Debian version: 1
        Initialized empty Git repository in .git/
        gpg: Signature made Tue 04 Dec 2007 10:47:06 AM CET using DSA key ID 
A1EE761C
        gpg: Can't check signature: public key not found
        dpkg-source: extracting git-core in 
/home/ukleinek/debsrc/tmp_fDkCA/unpack/git-core-1.5.3.7-1
        dpkg-source: unpacking git-core_1.5.3.7.orig.tar.gz
        dpkg-source: applying /home/ukleinek/debsrc/git-core_1.5.3.7-1.diff.gz
        fatal: pathspec '"gitweb/test/M\303\244rchen"' did not match any files
        git-rm returned 128
        Couldn't remove files
        Failed to import Debian package

The problem is the quoting.  That is 

        '"gitweb/test/M\303\244rchen"' 

is in old instead of 

        'gitweb/test/M\303\244rchen'

I suspect:

        [EMAIL PROTECTED]:~/debsrc/tmpfjgV1S/git-1.5.3.7$ git ls-files | grep 
gitweb/test
        "gitweb/test/M\303\244rchen"
        gitweb/test/file with spaces
        gitweb/test/file+plus+sign

So probably repo.index_files() must be taught either that a filename starting
with " is special or to use git ls-files -z

The patch below does the latter, ugly, but it works.

Best regards
Uwe

--- git_utils.py.bak    2007-12-05 14:20:34.000000000 +0100
+++ git_utils.py        2007-12-05 14:27:08.000000000 +0100
@@ -78,10 +78,10 @@
 
     def index_files(self):
         """List files in the index"""
-        out, ret = self.__git_getoutput('ls-files')
+        out, ret = self.__git_getoutput('ls-files', ['-z'])
         if ret:
             raise GitRepositoryError, "Error listing files %d" % ret
-        files = [ line.strip() for line in out ]
+        files = ''.join(out).split('\0')[:-1]
         return files
 

-- System Information:
Debian Release: 4.0
  APT prefers proposed-updates
  APT policy: (900, 'proposed-updates'), (900, 'stable'), (300, 
'testing-proposed-updates'), (300, 'testing'), (200, 'unstable'), (2, 
'experimental')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.22-3-amd64
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages git-buildpackage depends on:
ii  devscripts                 2.10.10       Scripts to make the life of a Debi
ii  git-core                   1:1.5.3.6-1.1 fast, scalable, distributed revisi
ii  python                     2.4.4-2       An interactive high-level object-o
ii  python-support             0.7.5         automated rebuilding support for p

git-buildpackage recommends no packages.

-- no debconf information

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to