Package:  dhcp3-server dhcp3-relay
Version:  3.0.4-9
Tags:     patch
User:     [EMAIL PROTECTED]
Usertags: incorrect-dependency

When testing dependency based boot sequencing, I discovered a bug in
the init.d script for dhcp3-server and dhcp3-relay.  Their
dependencies make it start too early in the boot.  They need a mounted
/usr/, and thus should depend on $remote_fs, not $local_fs.  And they
_need_ it, so it should be a required and not an optional dependency.

I threw in a dependency on $syslog for the the dhcp server, as I know
it is logging to syslog.  If the relay server is also loging to
syslog, it should depend on $syslog too.

This patch solve the issues:

diff -ur dhcp3-3.0.6.dfsg.orig/debian/dhcp3-relay.init.d 
dhcp3-3.0.6.dfsg/debian/dhcp3-relay.init.d
--- dhcp3-3.0.6.dfsg.orig/debian/dhcp3-relay.init.d     2008-01-01 
11:12:58.000000000 +0100
+++ dhcp3-3.0.6.dfsg/debian/dhcp3-relay.init.d  2008-01-01 11:14:25.000000000 
+0100
@@ -5,10 +5,8 @@

 ### BEGIN INIT INFO
 # Provides:          dhcp3-relay
-# Required-Start:    $network
-# Required-Stop:     $network
-# Should-Start:      $local_fs
-# Should-Stop:       $local_fs
+# Required-Start:    $remote_fs $network
+# Required-Stop:     $remote_fs $network
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: DHCP relay
Only in dhcp3-3.0.6.dfsg/debian: dhcp3-relay.init.d.~1~
diff -ur dhcp3-3.0.6.dfsg.orig/debian/dhcp3-server.init.d 
dhcp3-3.0.6.dfsg/debian/dhcp3-server.init.d
--- dhcp3-3.0.6.dfsg.orig/debian/dhcp3-server.init.d    2008-01-01 
11:12:58.000000000 +0100
+++ dhcp3-3.0.6.dfsg/debian/dhcp3-server.init.d 2008-01-01 11:13:53.000000000 
+0100
@@ -5,10 +5,8 @@

 ### BEGIN INIT INFO
 # Provides:          dhcp3-server
-# Required-Start:    $network
-# Required-Stop:     $network
-# Should-Start:      $local_fs
-# Should-Stop:       $local_fs
+# Required-Start:    $remote_fs $network $syslog
+# Required-Stop:     $remote_fs $network $syslog
 # Default-Start:     2 3 4 5
 # Default-Stop:      0 1 6
 # Short-Description: DHCP server

As the stop script do not seem to do anything except killing the
daemon, that task might be better left to the sendsigs script in
runlevel 0 and 6.  If this is indeed the case, I recommend removing 0
and 6 from the Default-Stop list to speed up the shutdown.

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to