Bug#465776: gitk: All-fields search also matches numeric timestamp

2010-03-14 Thread Jonathan Nieder
tags 465776 + patch thanks Frédéric Brière wrote: > (In particular, the amount of repeated code would probably give a Ruby > programmer seizures.) Ah, I imagine refactoring would be welcome. :) > So, I did the cowardly thing: I ripped the whole thing off. Hey, it > works. :) And well. Thank

Bug#465776: gitk: All-fields search also matches numeric timestamp

2010-03-14 Thread Frédéric Brière
On Sat, Mar 06, 2010 at 12:40:13PM -0600, Jonathan Nieder wrote: > > (I'd gladly submit a patch if I could, but uncommented Tcl code... > > ) > > If it were spread out over multiple files, it would not be so bad. ;-) I beg to differ. :) (In particular, the amount of repeated code would probably

Bug#465776: gitk: All-fields search also matches numeric timestamp

2010-03-06 Thread Jonathan Nieder
Hi Frédéric, Frédéric Brière wrote: > I'm not sure if this is intentional of not (I would guess not), but a > search with "All fields" and "containing" will try matching against the > numerical representation of the author/committer timestamps (but not the > timezone, it would seem). It is more

Bug#465776: gitk: All-fields search also matches numeric timestamp

2008-02-14 Thread Frédéric Brière
Package: gitk Version: 1:1.5.4.1-1 Severity: normal I'm not sure if this is intentional of not (I would guess not), but a search with "All fields" and "containing" will try matching against the numerical representation of the author/committer timestamps (but not the timezone, it would seem). (I'd