Bug#472509: mtr: UDP patch

2008-04-16 Thread Martin Pels
Hi Rogier, On Tue, 15 Apr 2008 18:35:00 +0200 Rogier Wolff [EMAIL PROTECTED] wrote: In my version we currently open sockets on line 327, drop permissions on line 333, and call srand and further things around 345. Which version are you looking at. (I'm in my 0.74 directory, which is

Bug#472509: mtr: UDP patch

2008-04-16 Thread Martin Pels
Hi Rogier, On Wed, 16 Apr 2008 11:27:00 +0200 Rogier Wolff [EMAIL PROTECTED] wrote: On Wed, Apr 16, 2008 at 11:03:19AM +0200, Martin Pels wrote: Which patch are you looking at? The wrong one apparently. Ok, I'm glad that's sorted :-) The one Mark attached to his message

Bug#472509: mtr: UDP patch

2008-04-15 Thread Martin Pels
Hi Rogier, Thanks for the reply. On Mon, 14 Apr 2008 21:09:56 +0200 Rogier Wolff [EMAIL PROTECTED] wrote: Hi guys, Looks nice. One problem I have with this is that the amount of code that is exposed to security problems has gone up a factor of ten... How much work would it be to

Bug#472509: mtr: UDP patch

2008-04-15 Thread Rogier Wolff
On Tue, Apr 15, 2008 at 04:41:15PM +0200, Martin Pels wrote: Depending on whether IP_HDRINCL is defined net_preopen() creates an icmp and udp socket, or a single raw socket. If we have two sockets it is trivial to close them in net_selectsocket(). This is actually what I did in the first

Bug#472509: mtr: UDP patch

2008-04-15 Thread Martin Pels
On Tue, 15 Apr 2008 17:15:18 +0200 Rogier Wolff [EMAIL PROTECTED] wrote: On Tue, Apr 15, 2008 at 04:41:15PM +0200, Martin Pels wrote: Depending on whether IP_HDRINCL is defined net_preopen() creates an icmp and udp socket, or a single raw socket. If we have two sockets it is trivial to

Bug#472509: mtr: UDP patch

2008-04-15 Thread Rogier Wolff
On Tue, Apr 15, 2008 at 05:56:36PM +0200, Martin Pels wrote: On Tue, 15 Apr 2008 17:15:18 +0200 Rogier Wolff [EMAIL PROTECTED] wrote: On Tue, Apr 15, 2008 at 04:41:15PM +0200, Martin Pels wrote: Depending on whether IP_HDRINCL is defined net_preopen() creates an icmp and udp socket, or

Bug#472509: mtr: UDP patch

2008-04-15 Thread Rogier Wolff
On Tue, Apr 15, 2008 at 05:56:36PM +0200, Martin Pels wrote: On Tue, 15 Apr 2008 17:15:18 +0200 Rogier Wolff [EMAIL PROTECTED] wrote: On Tue, Apr 15, 2008 at 04:41:15PM +0200, Martin Pels wrote: Depending on whether IP_HDRINCL is defined net_preopen() creates an icmp and udp socket, or

Bug#472509: mtr: UDP patch

2008-04-14 Thread Rogier Wolff
Hi guys, Looks nice. One problem I have with this is that the amount of code that is exposed to security problems has gone up a factor of ten... How much work would it be to open both the new UDP port and the old ICMP port, and discard the one we don't need? How can the program switch (with

Bug#472509: mtr: UDP patch

2008-04-14 Thread Mark Kamichoff
I wrote a patch for Mtr 0.72 to implement UDP support. You can find it attached. UDP mode is enabled using the -u commandline switch, or by typing u in the GUI. The patch has been tested on Debian testing/unstable, both on IPv4 and IPv6. I have written a patch (see attached) as well that adds

Bug#472509: mtr: UDP patch

2008-03-24 Thread Martin Pels
Subject: mtr: UDP patch Package: mtr Version: 0.72 Severity: wishlist Tags: patch Hi, I wrote a patch for Mtr 0.72 to implement UDP support. You can find it attached. UDP mode is enabled using the -u commandline switch, or by typing u in the GUI. The patch has been tested on Debian