Bug#520722: git-import-orig: filter option does not remove files from committed tarball

2009-06-12 Thread Mehdi Dogguy
Guido Günther a écrit : > > On Tue, Jun 09, 2009 at 10:41:49AM +0200, Mehdi Dogguy wrote: > [..snip..] >> +if options.filter_pristine_tar and len(options.filters) > 0: > Shouldn't this be: >if options.pristine_tar and options.filter_pristine_tar and > len(options.

Bug#520722: git-import-orig: filter option does not remove files from committed tarball

2009-06-12 Thread Guido Günther
Hi Mehdi, thanks for the update. This looks good in general, some comments are below. Could you have a look? On Tue, Jun 09, 2009 at 10:41:49AM +0200, Mehdi Dogguy wrote: [..snip..] > if options.verbose: > @@ -310,6 +311,15 @@ on howto create it otherwise use --upstream-branch to > specify

Bug#520722: git-import-orig: filter option does not remove files from committed tarball

2009-06-09 Thread Mehdi Dogguy
Guido Günther wrote: > Looks good at a first glance. Thanks! Feel free to make more intrusive > changes if you see fit. The only changes I'd like to add/fix are: - do not pass exclude option to tar when repacking since it was already applied when unpacking. - substitute .tar only in the basename!

Bug#520722: git-import-orig: filter option does not remove files from committed tarball

2009-06-09 Thread Guido Günther
On Thu, Jun 04, 2009 at 02:54:39PM +0200, Mehdi Dogguy wrote: > On 0, Mehdi Dogguy wrote: > > I implemented this idea in the attached patch. > > > > I updated my patch because I forgot to create a symlink to the new > tarball. So, here is attached my patch updated. > > --filter-pristine-tar no

Bug#520722: git-import-orig: filter option does not remove files from committed tarball

2009-06-04 Thread Mehdi Dogguy
On 0, Mehdi Dogguy wrote: > I implemented this idea in the attached patch. > I updated my patch because I forgot to create a symlink to the new tarball. So, here is attached my patch updated. --filter-pristine-tar now also works when --filter is used without --pristine-tar: It creates a packag

Bug#520722: git-import-orig: filter option does not remove files from committed tarball

2009-06-03 Thread Mehdi Dogguy
tag 520722 + patch thanks On 0, Guido Günther wrote: > git-import-orig doesn't regenerate the tarball given to pristine-tar but > always uses the pristine one given. I agree that having the possibility > to filter out files before giving it to prestine-tar might be nice in > some situations. I

Bug#520722: closed by Guido Günther (Re: Bug#520722: git-import-orig: filter option does not remove files from committed tarball)

2009-03-26 Thread Mehdi Dogguy
Guido Günther wrote: > severity 520722 wishlist > retitle 520722 git-import-orig: Regenerate upstream tarball with filter > applied before handing it to prestine-tar > thanks > > git-import-orig doesn't regenerate the tarball given to pristine-tar but > always uses the pristine one given. I agr

Bug#520722: closed by Guido Günther (Re: Bug#520722: git-import-orig: filter option does not remove files from committed tarball)

2009-03-25 Thread Guido Günther
severity 520722 wishlist retitle 520722 git-import-orig: Regenerate upstream tarball with filter applied before handing it to prestine-tar thanks On Mon, Mar 23, 2009 at 10:22:02AM +0100, Mehdi Dogguy wrote: > reopen 520722 > submitter 520722 mehdi.dog...@pps.jussieu.fr > thanks > > > The pristi

Bug#520722: closed by Guido Günther (Re: Bug#520722: git-import-orig: filter option does not remove files from committed tarball)

2009-03-23 Thread Mehdi Dogguy
reopen 520722 submitter 520722 mehdi.dog...@pps.jussieu.fr thanks > The pristine-tar branch is created by pristine-tar itself. Since it > wants to be able to regenerate the *pristine* tar it doesn't filter > anything out. > If you want that functionality please file a wishlist bug against > pristi

Bug#520722: git-import-orig: filter option does not remove files from committed tarball

2009-03-22 Thread Mehdi Dogguy
Package: git-buildpackage Version: 0.4.50 Severity: normal Hi, I noticed that git-import-orig's filter option does not remove files from committed pristine tarball. Files are actually removed in upstream branch but not in pristine-tar branch. Is it done on purpose? Cheers, -- System Informatio