Bug#544995: Allow to copy the fingerprints from the authentication dialog

[Felix Geyer]

Package: pidgin-otr
Version: 3.2.0-4
Severity: wishlist
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch

>From https://bugs.launchpad.net/ubuntu/+source/pidgin-otr/+bug/310769

> When authenticating a buddy (OTR > Authenticate Buddy) from the chat
> window, one of the options is Manual Fingerprint Verification.
> Here it lists your key and the key the other user presents.
> I believe you should be able to hilight copy these keys to paste them
> in a GPG-signed email as it suggests, rather than typing it out
> manually again.


Attaching proposed debdiff to set the label selectable.


diff -u pidgin-otr-3.2.0/debian/changelog pidgin-otr-3.2.0/debian/changelog
--- pidgin-otr-3.2.0/debian/changelog
+++ pidgin-otr-3.2.0/debian/changelog
@@ -1,3 +1,9 @@
+pidgin-otr (3.2.0-5) unstable; urgency=low
+
+  * Allow to copy the fingerprints from the authentication dialog (LP: #310769)
+
+ -- Felix Geyer <debfx-...@fobos.de>  Mon, 03 Aug 2009 23:01:55 +0200
+
 pidgin-otr (3.2.0-4) unstable; urgency=low
 
   * update pot at build time, patch from Sebastien Bacher (Closes: #518466)
diff -u pidgin-otr-3.2.0/debian/control pidgin-otr-3.2.0/debian/control
only in patch2:
unchanged:
--- pidgin-otr-3.2.0.orig/gtk-dialog.c
+++ pidgin-otr-3.2.0/gtk-dialog.c
@@ -71,6 +71,8 @@
 static int img_id_private = 0;
 static int img_id_finished = 0;
 
+static GtkLabel * fingerprint_label = 0;
+
 
 typedef struct {
     ConnContext *context;       /* The context used to fire library code */
@@ -643,11 +645,12 @@
     label = gtk_label_new(NULL);
     
     gtk_label_set_markup(GTK_LABEL(label), label_text);
-    gtk_label_set_selectable(GTK_LABEL(label), FALSE);
+    gtk_label_set_selectable(GTK_LABEL(label), TRUE);
     g_free(label_text);
     gtk_label_set_line_wrap(GTK_LABEL(label), TRUE);
     gtk_misc_set_alignment(GTK_MISC(label), 0, 0);
     gtk_box_pack_start(GTK_BOX(vbox), label, FALSE, FALSE, 0);
+    fingerprint_label = label;
         
     add_vrfy_fingerprint(vbox, vfd);
     g_signal_connect(G_OBJECT(vbox), "destroy",
@@ -677,6 +680,8 @@
         auth_data->smppair->entry = NULL;
         gtk_notebook_set_current_page (GTK_NOTEBOOK(notebook), 2);
         auth_data->smppair->smp_type = -1;
+        // workaround to prevent the text from always being selected
+        gtk_label_select_region(GTK_LABEL(fingerprint_label), 0, 0);
     }
     
 }