Package: qgit
Version: 2.3-1
Severity: minor
Tags: patch

Hi,

the provided qgit.desktop is not completely valid (see also output of
`desktop-file-validate`).
The attached patch fixes all the issues:
- the 'Encoding' key is deprecated (removed)
- the 'MimeType' key is a list, so it should end with the list separator (';')
- the 'ServiceTypes' (which should be 'X-KDE-ServiceTypes', actually) and
  'X-KDE-BrowserView-Args' keys are used by KDE, but qgit is Qt-only with no
  KDE integration, so there's little value for them.

References:
- http://www.freedesktop.org/wiki/Specifications/desktop-entry-spec
- http://www.freedesktop.org/wiki/Specifications/menu-spec

Thanks,
-- 
Pino

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (850, 'testing'), (800, 'unstable'), (750, 'experimental'), (750, 
'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.30-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages qgit depends on:
ii  git-core                     1:1.6.3.3-2 fast, scalable, distributed revisi
ii  libc6                        2.9-25      GNU C Library: Shared libraries
ii  libgcc1                      1:4.4.1-4   GCC support library
ii  libqtcore4                   4:4.5.2-2   Qt 4 core module
ii  libqtgui4                    4:4.5.2-2   Qt 4 GUI module
ii  libstdc++6                   4.4.1-4     The GNU Standard C++ Library v3
ii  libx11-6                     2:1.2.2-1   X11 client-side library
ii  libxext6                     2:1.0.4-1   X11 miscellaneous extension librar

Versions of packages qgit recommends:
pn  stgit                         <none>     (no description available)

qgit suggests no packages.

-- no debconf information
--- qgit.desktop.orig   2009-10-05 10:06:19.000000000 +0200
+++ qgit.desktop        2009-10-05 10:12:28.000000000 +0200
@@ -1,12 +1,9 @@
 [Desktop Entry]
-Encoding=UTF-8
 Name=qgit
 GenericName=git GUI viewer
 Exec=qgit
 Type=Application
 Comment=git GUI viewer
 Terminal=false
-MimeType=inode/directory
-ServiceTypes=KParts/ReadOnlyPart,Browser/View
-X-KDE-BrowserView-Args=DetailedList
+MimeType=inode/directory;
 Categories=Qt;Development;RevisionControl;

Reply via email to