Bug#550978: patch incomplete

2010-01-02 Thread Enrico Scholz
Erik Schanze schan...@gmx.de writes: http://cvs.fedoraproject.org/viewvc/rpms/gif2png/devel/gif2png-overflow.patch?revision=HEADroot=extrasview=markup solves the issue better. You're right. Thank you for your attention. fwiw, I changed my patch to abort/fail when filename length

Bug#550978: patch incomplete

2010-01-01 Thread Enrico Scholz
Hi, I am the Fedora maintainer of gif2png and think that the supplied patch is incomplete. In main(), there is done | - strcpy(name, argv[i]); | + strncpy( name, argv[i], sizeof( name ) ); | ... | strcat(name, .gif); which could still overflow 'name'.