Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-17 Thread Andres Mejia
On Sat, Feb 13, 2010 at 5:58 AM, Philipp Kern pk...@debian.org wrote: Andres, On Wed, Feb 10, 2010 at 02:46:10AM -0500, Andres Mejia wrote: The Dpkg::Arch function debarch_is() takes the first parameter as the architecture and the second parameter as the alias (wildcard). So using an alias

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-13 Thread Philipp Kern
Andres, On Wed, Feb 10, 2010 at 02:46:10AM -0500, Andres Mejia wrote: The Dpkg::Arch function debarch_is() takes the first parameter as the architecture and the second parameter as the alias (wildcard). So using an alias of any will always match true, regardless of what architecture is

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-09 Thread Philipp Kern
On Fri, Feb 05, 2010 at 01:25:21AM -0500, Andres Mejia wrote: We have some cases where we don't want that behaviour, see the patches to parse_sources.c for that. Ok. Makes sense. Actually it doesn't. When I check any against an architecture I want the behaviour that it matches e.g.

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-09 Thread Andres Mejia
On Tuesday 09 February 2010 13:41:43 Philipp Kern wrote: On Fri, Feb 05, 2010 at 01:25:21AM -0500, Andres Mejia wrote: We have some cases where we don't want that behaviour, see the patches to parse_sources.c for that. Ok. Makes sense. Actually it doesn't. When I check any against

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-06 Thread Andres Mejia
On Friday 05 February 2010 14:36:51 Philipp Kern wrote: On Fri, Feb 05, 2010 at 07:52:09PM +0100, Philipp Kern wrote: What's the command line you used? And the input data would be helpful, though. If you didn't pass an -A on the commandline to set the arch, that could cause a NULL in

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-06 Thread Philipp Kern
On Sat, Feb 06, 2010 at 12:15:39PM -0500, Andres Mejia wrote: The Packages and Sources files are current files grabbed from the Debian archive for Debian sid main. The Packages-arch-specific was grabbed from https://buildd.debian.org/quinn-diff/Packages-arch-specific. This is from a

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-05 Thread Philipp Kern
Andres, am Fri, Feb 05, 2010 at 01:25:21AM -0500 hast du folgendes geschrieben: I've attached a log showing different running times for quinn-diff with and without the dpkg-perl support on my system. Top of the log shows running time for current quinn-diff from unstable. Bottom of log shows

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-05 Thread Andres Mejia
On Friday 05 February 2010 04:54:59 Philipp Kern wrote: Andres, am Fri, Feb 05, 2010 at 01:25:21AM -0500 hast du folgendes geschrieben: I've attached a log showing different running times for quinn-diff with and without the dpkg-perl support on my system. Top of the log shows running

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-05 Thread Philipp Kern
On Fri, Feb 05, 2010 at 09:27:14AM -0500, Andres Mejia wrote: Here it is. This is on Debian sid on an amd64 box. (gdb) bt #0 strcmp () at ../sysdeps/x86_64/strcmp.S:30 #1 0x00403e17 in arch_equivalent (arch1=0x6124d0 alpha, arch2=0x0, use_equivalence=1) at utils.c:311 #2

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-05 Thread Philipp Kern
On Fri, Feb 05, 2010 at 07:52:09PM +0100, Philipp Kern wrote: What's the command line you used? And the input data would be helpful, though. If you didn't pass an -A on the commandline to set the arch, that could cause a NULL in package_architecture which propagates to NULL as the second

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-04 Thread Philipp Kern
Andres, On Tue, Dec 08, 2009 at 02:40:39PM -0500, Andres Mejia wrote: On Tue, Dec 8, 2009 at 12:08 PM, Philipp Kern pk...@debian.org wrote: On Tue, Dec 08, 2009 at 11:37:17AM -0500, Andres Mejia wrote: quinn-diff should support architecture wildcards just as support for them have been

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-04 Thread Philipp Kern
On Thu, Feb 04, 2010 at 07:19:23PM +0100, Philipp Kern wrote: I'm ok with using a Perl interpreter to determine from Packages-arch-specific (which is small compared to a Packages file) if an architecture is in a wildcarded list. However in the critical path it feels wrong. Did you already

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2010-02-04 Thread Andres Mejia
On Thursday 04 February 2010 16:33:12 Philipp Kern wrote: On Thu, Feb 04, 2010 at 07:19:23PM +0100, Philipp Kern wrote: I'm ok with using a Perl interpreter to determine from Packages-arch-specific (which is small compared to a Packages file) if an architecture is in a wildcarded list.

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2009-12-08 Thread Philipp Kern
On Tue, Dec 08, 2009 at 11:37:17AM -0500, Andres Mejia wrote: quinn-diff should support architecture wildcards just as support for them have been implemented in dpkg and sbuild. Here's a patch that will allow quinn-diff to support a Packages-arch-specific that has entries that include

Bug#560058: [buildd-tools-devel] Bug#560058: quinn-diff: should support architecture wildcards

2009-12-08 Thread Andres Mejia
On Tue, Dec 8, 2009 at 12:08 PM, Philipp Kern pk...@debian.org wrote: On Tue, Dec 08, 2009 at 11:37:17AM -0500, Andres Mejia wrote: quinn-diff should support architecture wildcards just as support for them have been implemented in dpkg and sbuild. Here's a patch that will allow quinn-diff