Bug#575917: git-core: --work-tree behaves strangely when called under .git

2011-01-21 Thread Jonathan Nieder
tags 575917 + fixed-upstream thanks Frédéric Brière wrote: Explicitly setting --work-tree without --git-dir does strange things when one is directly in (or under) the .git directory: $ pwd /tmp/git $ git init Initialized empty Git repository in /tmp/git/.git/ $ git

Bug#575917: git-core: --work-tree behaves strangely when called under .git

2010-10-19 Thread Jonathan Nieder
Hi Duy and Clemens, I keep forgetting the semantics of the setup vars. Do you remember? The result can go in Documentation/technical/api-setup.txt. Frédéric Brière wrote: $ pwd /tmp/git $ git init Initialized empty Git repository in /tmp/git/.git/ $ git --work-tree

Bug#575917: git-core: --work-tree behaves strangely when called under .git

2010-10-19 Thread Clemens Buchacher
Hi Jonathan, On Tue, Oct 19, 2010 at 01:41:24AM -0500, Jonathan Nieder wrote: I keep forgetting the semantics of the setup vars. Do you remember? All I know is that I tried to fix bugs in setup code several times, and I failed every time. I remember giving up on this particular problem in

Bug#575917: git-core: --work-tree behaves strangely when called under .git

2010-10-19 Thread Nguyen Thai Ngoc Duy
2010/10/19 Jonathan Nieder jrnie...@gmail.com: Yagh.  Given: cwd is .git dir, GIT_DIR unset, GIT_WORK_TREE=/tmp/git So cwd is /tmp/git/.git, right? Another the way to address this is to ban this case entirely. GIT_WORK_TREE should only be considered when GIT_DIR is set. I think there are

Bug#575917: git-core: --work-tree behaves strangely when called under .git

2010-10-19 Thread Nguyen Thai Ngoc Duy
2010/10/19 Nguyen Thai Ngoc Duy pclo...@gmail.com: 2010/10/19 Jonathan Nieder jrnie...@gmail.com: Yagh.  Given: cwd is .git dir, GIT_DIR unset, GIT_WORK_TREE=/tmp/git So cwd is /tmp/git/.git, right? Another the way to address this is to ban this case entirely. GIT_WORK_TREE should only be

Bug#575917: git-core: --work-tree behaves strangely when called under .git

2010-10-19 Thread Nguyen Thai Ngoc Duy
2010/10/19 Nguyen Thai Ngoc Duy pclo...@gmail.com: I once made setup_git_directory() a thin wrapper of _gently() (i.e no logic at all). What happened to that patch, hm... For archival purpose: http://thread.gmane.org/gmane.comp.version-control.git/74901 I'll make another attempt when my

Bug#575917: git-core: --work-tree behaves strangely when called under .git

2010-04-05 Thread Jonathan Nieder
found 575917 git-core/1:1.7.0.4-1 tags 575917 + upstream thanks Frédéric Brière wrote: Explicitly setting --work-tree without --git-dir does strange things when one is directly in (or under) the .git directory: Noted. I will add a test for this to Nguyễn Duy’s making-setup-sane series. You

Bug#575917: git-core: --work-tree behaves strangely when called under .git

2010-03-30 Thread Frédéric Brière
Package: git-core Version: 1:1.7.0.3-1 Severity: normal Explicitly setting --work-tree without --git-dir does strange things when one is directly in (or under) the .git directory: $ pwd /tmp/git $ git init Initialized empty Git repository in /tmp/git/.git/ $ git --work-tree