Bug#579040: RFS: zsnes (updated package - ITA)

2010-11-24 Thread Etienne Millon
On Mon, Nov 22, 2010 at 07:02:56PM -0600, Jonathan Nieder wrote: + * Add debian/README.source to document dpatch. I would have used a symlink or text pointing to /usr/share/doc/dpatch/README.source.gz for easier maintenance. I just corrected that and reuploaded the package. Thanks again.

Bug#579040: RFS: zsnes (updated package - ITA)

2010-11-23 Thread Jonathan Nieder
Etienne Millon wrote: The package builds in a clean chroot, so I thought this was good enough. If this is bad practice I will have another look at it. Yes, best practice is to explicitly declare all build-time dependencies that are not build-essential. So for example if the code uses Xlib

Bug#579040: RFS: zsnes (updated package - ITA)

2010-11-22 Thread Jonathan Nieder
Hi Etienne, Etienne Millon wrote: I have been using this package for years and it seems to need love. As I am learning how to maintain package, this seems a perfect candidate for adoption. I am preparing an upload fixing a few bugs, and will close this ITA when it's done. These are words I

Bug#579040: RFS: zsnes (updated package - ITA)

2010-11-22 Thread Etienne Millon
Hello, Thanks for this review. Are you sure the build-deps were useless? It could be that some of them are still needed but were brought in accidentally via libsdl-dev, for example. (See http://bugs.debian.org/123725) The package builds in a clean chroot, so I thought this was good enough.