Bug#594435: Quoted strings in pin specifications do not work

2010-08-30 Thread David Kalnischkies
> Is Data guaranteed to be non-empty here? If not, you should check that > first. It is as the first real line of the method checks for Data.length() < 1 and otherwise exits, so Data is at least one char long. You can still do a silly Pin: origin " which should maybe be catched as not allowed to

Bug#594435: Quoted strings in pin specifications do not work

2010-08-30 Thread Julian Andres Klode
On Mo, 2010-08-30 at 11:34 +0200, David Kalnischkies wrote: > Hi! > > 2010/8/26 Julian Andres Klode : > > On Do, 2010-08-26 at 01:38 +0100, Ben Hutchings wrote: > >> The *only* example of pinning by origin in apt_preferences(5) is: > > That was fixed in version 0.7.26~exp3 and is part of 0.8.0 wh

Bug#594435: Quoted strings in pin specifications do not work

2010-08-30 Thread Ben Hutchings
On Mon, 2010-08-30 at 11:34 +0200, David Kalnischkies wrote: > === modified file 'apt-pkg/versionmatch.cc' > --- apt-pkg/versionmatch.cc 2010-06-28 15:38:08 + > +++ apt-pkg/versionmatch.cc 2010-08-30 09:33:13 + > @@ -118,7 +118,10 @@ > > if (Type == Origin) > { > -

Bug#594435: Quoted strings in pin specifications do not work

2010-08-30 Thread David Kalnischkies
Hi! 2010/8/26 Julian Andres Klode : > On Do, 2010-08-26 at 01:38 +0100, Ben Hutchings wrote: >> The *only* example of pinning by origin in apt_preferences(5) is: That was fixed in version 0.7.26~exp3 and is part of 0.8.0 which will be in a few days in testing hopefully. > I personally do not wa

Bug#594435: Quoted strings in pin specifications do not work

2010-08-25 Thread Julian Andres Klode
severity 594435 minor thanks On Do, 2010-08-26 at 01:38 +0100, Ben Hutchings wrote: > Package: apt > Version: 0.7.25.3 > Severity: important > > The *only* example of pinning by origin in apt_preferences(5) is: > >Package: * >Pin: origin "" >Pin-Pr

Bug#594435: Quoted strings in pin specifications do not work

2010-08-25 Thread Ben Hutchings
Package: apt Version: 0.7.25.3 Severity: important The *only* example of pinning by origin in apt_preferences(5) is: Package: * Pin: origin "" Pin-Priority: 999 This implies that strings can be double-quoted and that an empty string must be. In fact,